Bug#1075793: plastimatch FTBFS with DCMTK 3.6.8
Control: tags -1 pending Hi Greg, On Thu, 11 Jul 2024 22:59:28 + (UTC) Gregory Sharp wrote: > Thank you Adrian, > > Yes this is the correct patch. I'm inclined to make a new upstream release instead of patching, but let me know. > Thanks for proposing to fix it upstream! Still, I will have to make an upload with the Debian-specific patch right now, because I am transitioning dlib and plastimatch build-depends on it. I need to achieve this transition but for sure the patch will go away when one packages the upcoming upstream version! Cheers, -- Pierre > Greg Sharp > gregsh...@geocities.com > OpenPGP_signature.asc Description: OpenPGP digital signature
Bug#1075793: plastimatch FTBFS with DCMTK 3.6.8
Thank you Adrian, Yes this is the correct patch. I'm inclined to make a new upstream release instead of patching, but let me know. Greg Sharp gregsh...@geocities.com
Bug#1075793: plastimatch FTBFS with DCMTK 3.6.8
Control: forwarded -1 https://gitlab.com/plastimatch/plastimatch/-/commit/a1a6f4da5681735544db1239ddd3d01066ce10d8 Control: tags -1 patch On Fri, Jul 05, 2024 at 11:19:57AM +0200, Mathieu Malaterre wrote: > Source: plastimatch > Version: 1.9.4+dfsg.1-2 > Severity: serious > Tags: ftbfs > > /<>/src/plastimatch/base/dcmtk_rtss.cxx: In member > function ‘void Dcmtk_rt_study::rtss_save(const char*)’: > /<>/src/plastimatch/base/dcmtk_rtss.cxx:475:46: error: > ‘DCM_ROIObservationLabel’ was not declared in this scope; did you mean > ‘DCM_ObservationNumber’? > 475 | rtroio_item->putAndInsertString (DCM_ROIObservationLabel, > | ^~~ > | DCM_ObservationNumber > > https://people.debian.org/~emollier/transitions/dcmtk/plastimatch_dcmtk.build.xz > > It has been retired: > > % cat dcmdata/include/dcmtk/dcmdata/dcdeftag.h | grep 3006 | grep 85 > #define DCM_RETIRED_ROIObservationLabel DcmTagKey(0x3006, 0x0085) The commit above (applied to src/plastimatch/base/dcmtk_rtss.cxx) firxes the build. cu Adrian
Bug#1075793: plastimatch FTBFS with DCMTK 3.6.8
Hi Mathieu, Thank you for the report. This was fixed long ago upstream, but I did not deploy a new version. Sorry for the FTBFS, that is my bad. Greg Sharp gregsh...@geocities.com
Bug#1075793: plastimatch FTBFS with DCMTK 3.6.8
Source: plastimatch Version: 1.9.4+dfsg.1-2 Severity: serious Tags: ftbfs /<>/src/plastimatch/base/dcmtk_rtss.cxx: In member function ‘void Dcmtk_rt_study::rtss_save(const char*)’: /<>/src/plastimatch/base/dcmtk_rtss.cxx:475:46: error: ‘DCM_ROIObservationLabel’ was not declared in this scope; did you mean ‘DCM_ObservationNumber’? 475 | rtroio_item->putAndInsertString (DCM_ROIObservationLabel, | ^~~ | DCM_ObservationNumber https://people.debian.org/~emollier/transitions/dcmtk/plastimatch_dcmtk.build.xz It has been retired: % cat dcmdata/include/dcmtk/dcmdata/dcdeftag.h | grep 3006 | grep 85 #define DCM_RETIRED_ROIObservationLabel DcmTagKey(0x3006, 0x0085)
