Bug#311044: 311044: numlockx: toggle option would be a nice add-on

2005-10-03 Thread Chris Vanden Berghe

 Done. Please use -c (and preferably also -p) next time you create a patch.


Great, thanks.  And, I will.

Cheers,
Chris.


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Bug#311044: 311044: numlockx: toggle option would be a nice add-on

2005-10-03 Thread Lubos Lunak
On Saturday 01 of October 2005 12:47, Chris Vanden Berghe wrote:
> >  Feel free to.
>
> Here you go.
>
> Best regards,
> Chris.

 Done. Please use -c (and preferably also -p) next time you create a patch.

-- 
Lubos Lunak
KDE developer
-
SuSE CR, s.r.o.  e-mail: [EMAIL PROTECTED] , [EMAIL PROTECTED]
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Bug#311044: 311044: numlockx: toggle option would be a nice add-on

2005-10-01 Thread Chris Vanden Berghe

 Feel free to.


Here you go.

Best regards,
Chris.
59a60
> "toggle - toggles the NumLock on and off in X\n"
132a134,151
> 
> int xkb_toggle()
> {
> unsigned int mask;
> unsigned int numlockState;
>   XkbStateRec xkbState;
> if( !xkb_init())
> return 0;
> mask = xkb_numlock_mask();
> if( mask == 0 )
> return 0;
>   XkbGetState( dpy, XkbUseCoreKbd, &xkbState);
>   numlockState = xkbState.locked_mods & mask;
>   if (numlockState) XkbLockModifiers ( dpy, XkbUseCoreKbd, mask, 
> 0);
>   else XkbLockModifiers ( dpy, XkbUseCoreKbd, mask, mask);
> return 1;
> }
> 
176a196,200
> 
> void xtest_toggle()
> {
> xtest_change_numlock();
> }
200a225,235
> void numlock_toggle()
> {
> #ifdef HAVE_XKB
> if( xkb_toggle())
> return;
> #endif
> #ifdef HAVE_XTEST
> xtest_toggle();
> #endif
> }
> 
211a247
> usage( argv[ 0 ] );
219a256,257
> else if( strcmp( argv[ 1 ], "toggle" ) == 0 )
> numlock_toggle();


Bug#311044: 311044: numlockx: toggle option would be a nice add-on

2005-09-30 Thread Martin-Éric Racine
tags 311044 wontfix
thanks

pe, 2005-09-30 kello 16:17 +0200, Lubos Lunak kirjoitti:
> On Thursday 22 of September 2005 16:34, Martin-Éric Racine wrote:
> > pe, 2005-09-02 kello 08:46 +0200, Chris Vanden Berghe kirjoitti:
> > > The wishlist-bug I opened proposes a 'toggle' option (next to the
> > > existing 'on' and 'off' options) that changes the numlock state.  So,
> > > turns it off when it's on, and turns it on when it's off.
> >
> > That wishlist concerns the upstream software, not the Debian packaging,
> > so I'm hereby forwarding him the idea.
> 
>  The very first version of numlockx actually works only that way, so you can 
> use just that: http://www.linux.cz/lists/archive/linux/68637.html . But quite 
> frankly I don't quite see the point of being able to flip the state.

Me neither.  

This software's purpose is not to compensate for a broken key, it is  to
automatically enable the NumLock status whenever starting an X session.

I don't oppose the addition of this toggle feature, but I honestly don't
see the need for it either.

However... 

I notice that the bug reporter's intended usage goes one step beyond:
it would add an applet to either KDE or GNOME's taskbar to toggle the
status of the NumLock key.  That feels more involved.

Anyhow, if someone ever submits a patch to upstream that adds the toggle
action, without affecting current behaviour, I will gladly package it.

-- 
Martin-Éric Racine
http://q-funk.iki.fi




Bug#311044: 311044: numlockx: toggle option would be a nice add-on

2005-09-30 Thread Lubos Lunak
On Friday 30 of September 2005 16:54, Chris Vanden Berghe wrote:
> Anyway, just a thought... leave it if you don't like it, but it's
> probably trivially added, right?
>

 Feel free to.

-- 
Lubos Lunak
KDE developer
-
SuSE CR, s.r.o.  e-mail: [EMAIL PROTECTED] , [EMAIL PROTECTED]
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Bug#311044: 311044: numlockx: toggle option would be a nice add-on

2005-09-30 Thread Chris Vanden Berghe

Hi,

Well, I defined an icon in my panel to put the numlock off (the normal 
keyboard numlock button doesn't work for some reason).  This is 
convenient because typing 'numlockx off' is not easy/possible when my 
laptop keyboard is in numlocked mode.


Sometimes I also have to put it on... this I _can_ type (as my laptop 
keyboard is in normal mode then), but it would be easy if I could reuse 
the icon that is already available to just toggle the mode.


Another use would be in a script where you want to flash the numlock to 
call for attention...


Anyway, just a thought... leave it if you don't like it, but it's 
probably trivially added, right?


Cheers,
Chris.

---
 The very first version of numlockx actually works only that way, so you can 
use just that: http://www.linux.cz/lists/archive/linux/68637.html . But quite 
frankly I don't quite see the point of being able to flip the state.



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Bug#311044: 311044: numlockx: toggle option would be a nice add-on

2005-09-30 Thread Lubos Lunak
On Thursday 22 of September 2005 16:34, Martin-Éric Racine wrote:
> pe, 2005-09-02 kello 08:46 +0200, Chris Vanden Berghe kirjoitti:
> > The wishlist-bug I opened proposes a 'toggle' option (next to the
> > existing 'on' and 'off' options) that changes the numlock state.  So,
> > turns it off when it's on, and turns it on when it's off.
>
> That wishlist concerns the upstream software, not the Debian packaging,
> so I'm hereby forwarding him the idea.

 The very first version of numlockx actually works only that way, so you can 
use just that: http://www.linux.cz/lists/archive/linux/68637.html . But quite 
frankly I don't quite see the point of being able to flip the state.


-- 
Lubos Lunak
KDE developer
-
SuSE CR, s.r.o.  e-mail: [EMAIL PROTECTED] , [EMAIL PROTECTED]
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/



Bug#311044: 311044: numlockx: toggle option would be a nice add-on

2005-09-22 Thread Martin-Éric Racine
pe, 2005-09-02 kello 08:46 +0200, Chris Vanden Berghe kirjoitti:

> The wishlist-bug I opened proposes a 'toggle' option (next to the
> existing 'on' and 'off' options) that changes the numlock state.  So,
> turns it off when it's on, and turns it on when it's off.

That wishlist concerns the upstream software, not the Debian packaging,
so I'm hereby forwarding him the idea.

-- 
Martin-Éric Racine
http://q-funk.iki.fi