Bug#315636: sqwebmail: Doesn't parse out extra data in the comments field of /etc/passwd

2005-06-29 Thread Willi Mann



The code in courier-authlib looks completely different to me. I suggest to
bring up this problem on courier-users.


It seems it was removed completely. While the original version removed the 
commas on the end, it now takes the whole original field:


eee ee Eeee,,2, [EMAIL PROTECTED]

I'll post to courier-users soon.

Willi


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#315636: sqwebmail: Doesn't parse out extra data in the comments field of /etc/passwd

2005-06-28 Thread Stefan Hornburg
On Sat, 25 Jun 2005 13:14:14 +0200
Willi Mann [EMAIL PROTECTED] wrote:

 
  OK, the problem really was wrong parsing of the GECOS field. The patch 
  is attached. Do you know how to recompile courier?
 
 Note to racke and me: I'm not sure whether this problem applies to 0.50 and 
 above. I failed to find a similar piece of code. If it's entirely removed, 
 the bug is even bigger there.

The code in courier-authlib looks completely different to me. I suggest to
bring up this problem on courier-users.

Bye
Racke


-- 
LinuXia Systems = http://www.linuxia.de/
Expert Interchange Consulting and System Administration
ICDEVGROUP = http://www.icdevgroup.org/
Interchange Development Team



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#315636: sqwebmail: Doesn't parse out extra data in the comments field of /etc/passwd

2005-06-26 Thread Pete de Zwart
Willi Mann wrote:
 OK, the problem really was wrong parsing of the GECOS field. The patch
 is attached. Do you know how to recompile courier?

Yup, that sorted the problem out, I patched the file, built the package
from source and reinstalled the authdaemon and it no longer has the
GECOS information as part of the username.

Great stuff Willi.

Regards,

Pete de Zwart.

-- 
Pete de Zwart BCompSc (SDS)
GPATShttp://www.gpats.com.au/
Ph: +61 2 9211 3195 Fax: +61 2 9211 1947



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#315636: sqwebmail: Doesn't parse out extra data in the comments field of /etc/passwd

2005-06-25 Thread Willi Mann

Willi Mann schrieb:

Pete de Zwart schrieb:


Hi Willi,

Couier-authdaemon is using the out of the box debian config, is
there a specific file I can check for you?



I just wanted to make sure I search in the right module (authpam). I'll 
do that later today unless someone else comes up with a 
solution/explanation.


OK, the problem really was wrong parsing of the GECOS field. The patch is 
attached. Do you know how to recompile courier?


Willi
--- success.c.old	2005-06-25 11:00:23.0 +0200
+++ success.c	2005-06-25 12:09:08.0 +0200
@@ -70,11 +70,12 @@
 	}
 	strcat(strcpy(authfullname_buf, AUTHFULLNAME=), authfullname);
 
-	/* Get rid of GECOS crud */
+	/* Get rid of GECOS crud, we only need the first field */
 
-	p=authfullname_buf+strlen(authfullname_buf);
-	while (*--p == ',')
-		*p=0;
+	p=authfullname_buf;
+	while (*p != ','  *p != '\0')
+		p++;
+	*p=0;
 	putenv(authaddr_buf);
 	putenv(authfullname_buf);
 }


Bug#315636: sqwebmail: Doesn't parse out extra data in the comments field of /etc/passwd

2005-06-25 Thread Willi Mann


OK, the problem really was wrong parsing of the GECOS field. The patch 
is attached. Do you know how to recompile courier?


Note to racke and me: I'm not sure whether this problem applies to 0.50 and 
above. I failed to find a similar piece of code. If it's entirely removed, 
the bug is even bigger there.


Willi


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#315636: sqwebmail: Doesn't parse out extra data in the comments field of /etc/passwd

2005-06-25 Thread Pete de Zwart
Sure, I'll do it on Monday when I'm back in the office and let you know the
results of the compiled debain source package and if it has resolved the
issue.

Pete de Zwart. 

-Original Message-
From: Willi Mann [mailto:[EMAIL PROTECTED] 
Sent: Saturday, 25 June 2005 8:39 PM
To: Pete de Zwart; [EMAIL PROTECTED]
Subject: Re: Bug#315636: sqwebmail: Doesn't parse out extra data in the
comments field of /etc/passwd

Willi Mann schrieb:
 Pete de Zwart schrieb:
 
 Hi Willi,

 Couier-authdaemon is using the out of the box debian config, is
 there a specific file I can check for you?
 
 
 I just wanted to make sure I search in the right module (authpam). I'll 
 do that later today unless someone else comes up with a 
 solution/explanation.

OK, the problem really was wrong parsing of the GECOS field. The patch is 
attached. Do you know how to recompile courier?

Willi


smime.p7s
Description: S/MIME cryptographic signature


Bug#315636: sqwebmail: Doesn't parse out extra data in the comments field of /etc/passwd

2005-06-24 Thread Pete de Zwart
Package: sqwebmail
Version: 0.47-4
Severity: normal


sqwebmail doesn't parse out any extra elements from the comments field after 
the name.

It should only read up to before the first comma, then ignore the rest.

For example, this is my entry in /etc/passwd:

dezwart:x:1000:1000:Pete de Zwart0411 648 
655:/home/dezwart:/bin/bash

Thus, sqwebmail believed my name is:

Pete de Zwart0411 648 655

Where as, it should only use:

Pete de Zwart

Having to change the From: field for each e-mail is a bit of a pain.

Regards,

Pete de Zwart.

-- System Information:
Debian Release: 3.1
Architecture: i386 (i686)
Kernel: Linux 2.6.12
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages sqwebmail depends on:
ii  apache [httpd]  1.3.33-6 versatile, high-performance HTTP s
ii  courier-authdaemon  0.47-4   Courier Mail Server - Authenticati
ii  courier-base0.47-4   Courier Mail Server - Base system
ii  courier-maildrop0.47-4   Courier Mail Server - Mail deliver
ii  cron3.0pl1-86management of regular background p
ii  exim4   4.50-8   metapackage to ease exim MTA (v4) 
ii  exim4-daemon-heavy [mail-tr 4.50-8   exim MTA (v4) daemon with extended
ii  expect  5.42.1-1.2   A program that talks to other pr
ii  ibritish [ispell-dictionary 3.1.20.0-4   A British English dictionary for i
ii  ispell  3.1.20.0-4   International Ispell (an interacti
ii  libc6   2.3.2.ds1-22 GNU C Library: Shared libraries an
ii  libfam0c102 2.7.0-6  client library to control the FAM 
ii  libgdbm31.8.3-2  GNU dbm database routines (runtime

-- debconf information:
  sqwebmail/install-www-backup: symlink
* sqwebmail/install-www: symlink
* sqwebmail/calendarmode: local
* sqwebmail/dictionary: british


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#315636: sqwebmail: Doesn't parse out extra data in the comments field of /etc/passwd

2005-06-24 Thread Willi Mann

Pete de Zwart schrieb:

Package: sqwebmail
Version: 0.47-4
Severity: normal


sqwebmail doesn't parse out any extra elements from the comments field after 
the name.

It should only read up to before the first comma, then ignore the rest.

For example, this is my entry in /etc/passwd:

dezwart:x:1000:1000:Pete de Zwart0411 648 
655:/home/dezwart:/bin/bash

Thus, sqwebmail believed my name is:

Pete de Zwart0411 648 655

Where as, it should only use:

Pete de Zwart


Did your change anything concerning the used authentication modules?

Willi


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#315636: sqwebmail: Doesn't parse out extra data in the comments field of /etc/passwd

2005-06-24 Thread Pete de Zwart
Hi Willi,

Couier-authdaemon is using the out of the box debian config, is
there a specific file I can check for you?

Regards,

Pete de Zwart.

-Original Message-
From: Willi Mann [mailto:[EMAIL PROTECTED] 
Sent: Friday, 24 June 2005 7:25 PM
To: Pete de Zwart; [EMAIL PROTECTED]
Subject: Re: Bug#315636: sqwebmail: Doesn't parse out extra data in the
comments field of /etc/passwd

Did your change anything concerning the used authentication modules?

Willi



smime.p7s
Description: S/MIME cryptographic signature


Bug#315636: sqwebmail: Doesn't parse out extra data in the comments field of /etc/passwd

2005-06-24 Thread Willi Mann

Pete de Zwart schrieb:

Hi Willi,

Couier-authdaemon is using the out of the box debian config, is
there a specific file I can check for you?


I just wanted to make sure I search in the right module (authpam). I'll do 
that later today unless someone else comes up with a solution/explanation.


Willi


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]