Bug#319109: cupsys-driver-gutenprint: syntax error on local ppd file

2005-07-20 Thread Roger Leigh
Andrew Pimlott [EMAIL PROTECTED] writes:

 Package: cupsys-driver-gutenprint
 Version: 4.3.99+cvs20050715-1
 Severity: normal

 I just upgraded to cupsys-driver-gutenprint, purging
 cupsys-driver-gimpprint and cupsys-driver-gimpprint-data.  In the
 output, I got a whole bunch of lines Writing ..., and then:

 sh: -c: line 0: syntax error near unexpected token `('
 sh: -c: line 0: `egrep -i -l Gutenprint|Gimp-Print 
 /etc/cups/ppd/Color-LaserJet-4600-v3010.107-Postscript-(recommended).ppd'
 No Gutenprint PPD files to update.

 /etc/cups/ppd/Color-LaserJet-4600-v3010.107-Postscript-(recommended).ppd
 was a file I found via linuxprinting.org and installed with
 gnome-cups-add.

 The error comes from /usr/sbin/cups-genppdupdate.5.0, and it looks like
 someone was sloppy around line 93.  If you can assume a newer perl, I
 believe you should be able to use something like

 open PPDFILES, '-|', qw( egrep -i -l ), Gutenprint|Gimp-Print, @ppdglob

 to avoid shell quoting problems.  Actually, it seems like

 open PPDFILES, egrep -i -l \Gutenprint|Gimp-Print\ *.{ppd,PPD}|

 might do just as well.

Thanks for the report.  This is actually a regression from
cupsys-driver-gimpprint, which I must have forgotten to commit
upstream.

See
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=302434archive=yes

I'll add the patch back in.  Would you be willing to test the
packages?


Thanks,
Roger

-- 
Roger Leigh
Printing on GNU/Linux?  http://gimp-print.sourceforge.net/
Debian GNU/Linuxhttp://www.debian.org/
GPG Public Key: 0x25BFB848.  Please sign and encrypt your mail.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#319109: cupsys-driver-gutenprint: syntax error on local ppd file

2005-07-20 Thread Roger Leigh
Andrew Pimlott [EMAIL PROTECTED] writes:

 On Wed, Jul 20, 2005 at 08:49:14PM +0100, Roger Leigh wrote:
 I'll add the patch back in.  Would you be willing to test the
 packages?

 thanks and sure

If you patch /usr/sbin/cups-genppdupdate.5.0 with the following patch,
and then try running it (as root), does it then run without error?

Thanks,
Roger


--- /usr/sbin/cups-genppdupdate.5.0 2005-07-18 19:17:52.0 +0100
+++ cups-genppdupdate.5.0   2005-07-20 21:10:50.780033880 +0100
@@ -93,7 +93,7 @@
 my @ppdglob = glob($ppd_dir/*.{ppd,PPD});
 my $ppdlist = join ' ', @ppdglob;
 if (@ppdglob) {
-open PPDFILES, egrep -i -l \Gutenprint|Gimp-Print\ $ppdlist| or die 
can't grep $ppd_dir/*: $!;
+open PPDFILES, '-|', 'egrep', '-i', '-l', 'Gutenprint|Gimp-Print', 
@ppdglob or die can't grep $ppd_dir/*: $!;
 while (PPDFILES) {
chomp;
push @ppd_files,  $_;

-- 
Roger Leigh
Printing on GNU/Linux?  http://gimp-print.sourceforge.net/
Debian GNU/Linuxhttp://www.debian.org/
GPG Public Key: 0x25BFB848.  Please sign and encrypt your mail.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#319109: cupsys-driver-gutenprint: syntax error on local ppd file

2005-07-20 Thread Andrew Pimlott
On Wed, Jul 20, 2005 at 08:49:14PM +0100, Roger Leigh wrote:
 I'll add the patch back in.  Would you be willing to test the
 packages?

thanks and sure


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#319109: cupsys-driver-gutenprint: syntax error on local ppd file

2005-07-19 Thread Andrew Pimlott
Package: cupsys-driver-gutenprint
Version: 4.3.99+cvs20050715-1
Severity: normal

I just upgraded to cupsys-driver-gutenprint, purging
cupsys-driver-gimpprint and cupsys-driver-gimpprint-data.  In the
output, I got a whole bunch of lines Writing ..., and then:

sh: -c: line 0: syntax error near unexpected token `('
sh: -c: line 0: `egrep -i -l Gutenprint|Gimp-Print 
/etc/cups/ppd/Color-LaserJet-4600-v3010.107-Postscript-(recommended).ppd'
No Gutenprint PPD files to update.

/etc/cups/ppd/Color-LaserJet-4600-v3010.107-Postscript-(recommended).ppd
was a file I found via linuxprinting.org and installed with
gnome-cups-add.

The error comes from /usr/sbin/cups-genppdupdate.5.0, and it looks like
someone was sloppy around line 93.  If you can assume a newer perl, I
believe you should be able to use something like

open PPDFILES, '-|', qw( egrep -i -l ), Gutenprint|Gimp-Print, @ppdglob

to avoid shell quoting problems.  Actually, it seems like

open PPDFILES, egrep -i -l \Gutenprint|Gimp-Print\ *.{ppd,PPD}|

might do just as well.

Andrew

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.8-2-686
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages cupsys-driver-gutenprint depends on:
ii  cupsys  1.1.23-11Common UNIX Printing System(tm) - 
ii  libc6   2.3.2.ds1-22 GNU C Library: Shared libraries an
ii  libcupsimage2   1.1.23-11Common UNIX Printing System(tm) - 
ii  libcupsys2-gnutls10 1.1.23-11Common UNIX Printing System(tm) - 
ii  libgutenprint2  4.3.99+cvs20050715-1 runtime for the Gutenprint printer
ii  libjpeg62   6b-10The Independent JPEG Group's JPEG 
ii  libperlmenu-perl4.0-2Menu and Template (curses-based) U
ii  libpng12-0  1.2.8rel-1   PNG library - runtime
ii  libtiff43.7.3-1  Tag Image File Format (TIFF) libra
ii  perl5.8.7-4  Larry Wall's Practical Extraction 
ii  zlib1g  1:1.2.2-9compression library - runtime

Versions of packages cupsys-driver-gutenprint recommends:
ii  gs-esp [postscript-viewer]7.07.1-9   The Ghostscript PostScript interpr
ii  gs-gpl [postscript-viewer]8.15-1 The GPL Ghostscript PostScript int
ii  gv [postscript-viewer]1:3.6.1-12 PostScript and PDF viewer for X
ii  kghostview [postscript-viewer 4:3.3.2-2  PostScript viewer for KDE

-- no debconf information


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]