Bug#326891: freeradius: postinst script could be faster

2005-09-07 Thread Guido Trotter 
On Wed, Sep 07, 2005 at 01:12:42AM +1000, Paul TBBle Hampson wrote:


 Nice catch. However, I went with
 find /var/log/freeradius \( ! -user freerad -o ! -group freerad \) -exec 
 chown freerad:freerad {} \;
 as otherwise it'll do the exec only in the ! -group freerad case.
 
 It'll be in FreeRADIUS 1.0.5's release, (any time now) and so will be fixed in
 Debian upon upload of 1.0.5-1.
 

Ok, that's great, thank you! I'm maintaining a stable backport of freeradius and
that will help being efficient when I upgrade on the production servers! (I did
that because of the fact that the security issues in freeradius described in
http://www.freeradius.org/security.html that probably affected debian stable too
were not addressed by any security team DSA... Do you know why, and if they
will?)

Thanks!

Guido



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#326891: freeradius: postinst script could be faster

2005-09-07 Thread Nicolas Baradakis 
Guido Trotter wrote:

 I'm maintaining a stable backport of freeradius and that will help
 being efficient when I upgrade on the production servers! (I did
 that because of the fact that the security issues in freeradius
 described in http://www.freeradius.org/security.html that probably
 affected debian stable too were not addressed by any security team
 DSA... Do you know why, and if they will?)

The FreeRADIUS package in Sarge (version 1.0.2-4) already contains the
fixes for security issues disclosed on freeradius.org.

http://packages.debian.org/changelogs/pool/main/f/freeradius/freeradius_1.0.2-4/changelog.html

-- 
Nicolas Baradakis


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#326891: freeradius: postinst script could be faster

2005-09-06 Thread Guido Trotter 
Package: freeradius
Version: 1.0.4-2
Severity: wishlist
Tags: patch

Hi!

The freeradius postinst script does a:
 find /var/log/freeradius -exec chown freerad {} \; -exec chgrp freerad {} \;

Which can be slow, especially if there are lots of nas and logs.
This small patch makes one less call to -exec and avoids doing the work
if it's already ok, thus making the process a lot faster:

--- freeradius.postinst.orig2005-09-06 14:20:33.062435472 +0200
+++ freeradius.postinst 2005-09-06 14:20:53.259365072 +0200
@@ -38,7 +38,7 @@

find /etc/freeradius -type f -exec chgrp freerad {} \; -exec chmod 640 
{} \;
find /etc/freeradius -type d -exec chgrp freerad {} \; -exec chmod 2750 
{} \;
-   find /var/log/freeradius -exec chown freerad {} \; -exec chgrp freerad 
{} \;
+   find /var/log/freeradius ! -user freerad -o ! -group freerad -exec 
chown freerad:freerad {} \;

if [ $2 =  ] ; then
action=start

Thanks!

Guido


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#326891: freeradius: postinst script could be faster

2005-09-06 Thread Paul TBBle Hampson 
tags 326891 +fixed-upstream
Thankyou Mr Bug Control Robot.

On Tue, Sep 06, 2005 at 02:26:11PM +0200, Guido Trotter wrote:
 -   find /var/log/freeradius -exec chown freerad {} \; -exec chgrp 
 freerad {} \;
 +   find /var/log/freeradius ! -user freerad -o ! -group freerad -exec 
 chown freerad:freerad {} \;

Nice catch. However, I went with
find /var/log/freeradius \( ! -user freerad -o ! -group freerad \) -exec chown 
freerad:freerad {} \;
as otherwise it'll do the exec only in the ! -group freerad case.

It'll be in FreeRADIUS 1.0.5's release, (any time now) and so will be fixed in
Debian upon upload of 1.0.5-1.

Thanks. ^_^

-- 
Paul TBBle Hampson, [EMAIL PROTECTED]
8th year CompSci/Asian Studies student, ANU

Shorter .sig for a more eco-friendly paperless office.


pgp7MkaNUDzMm.pgp
Description: PGP signature