Bug#327797: bins: contains paths from the build process

2005-10-15 Thread Ludovic Rousseau
Hello Martin,

This patch is included in bins (1.1.29-2) but the bug is still open and
it is an RC bug.

Did you forget to close it in debian/changelog or I am missing
something?

Bye,

Le Monday 12 September 2005 à 17:37:36, Martin Michlmayr a écrit:
> * Adam Lackorzynski <[EMAIL PROTECTED]> [2005-09-12 11:28]:
> > the bins script file contains paths from the build process making it
> > unusable because it cannot find its styles etc and therefore does not work:
> > 
> > ~# grep tbm /usr/bin/bins
> > my $localePath = 
> > "/home/tbm/tmp/src/b/new/bins-1.1.29/debian/bins/usr/share/locale"; # Base 
> > locale path  (for I18N)
> >  globalDataDir   => 
> > "/home/tbm/tmp/src/b/new/bins-1.1.29/debian/bins/usr/share/bins", # System 
> > wide data directory
> > 
> > It looks like this is a design issue in install.sh which always
> > prepends DESTDIR instead of only doing so when operating on files and
> > not when replacing paths in the binaries.
> 
> Jérôme, can you please apply this patch.
> 
> --- install.sh~   2005-09-12 17:34:57.0 +0100
> +++ install.sh2005-09-12 17:35:27.0 +0100
> @@ -24,8 +24,9 @@
>  GLOBAL_RC="$RC"
>  
>  DESTDIR=`echo "$DESTDIR"|sed 's%/$%%'`
> -PREFIX=$DESTDIR/`echo "$PREFIX"|sed 's%^/%%'`
>  PREFIX=`echo "$PREFIX"|sed 's%/$%%'`
> +GLOBAL_SHARE="$PREFIX/share"
> +PREFIX=$DESTDIR/`echo "$PREFIX"|sed 's%^/%%'`
>  ETC=$DESTDIR/`echo "$ETC"|sed 's%^/%%'`
>  ETC=`echo "$ETC"|sed 's%/$%%'`
>  RC=$DESTDIR/`echo "$RC"|sed 's%^/%%'`
> @@ -227,7 +228,7 @@
>  do
>echo -n " $FILE"
>ed "$FILE"  -1,\$s%/usr/local/share%$SHARE%g
> +1,\$s%/usr/local/share%$GLOBAL_SHARE%g
>  1,\$s%/etc/bins%$GLOBAL_RC%g
>  wq
>  EoF

-- 
 Dr. Ludovic Rousseau[EMAIL PROTECTED]
 -- Normaliser Unix c'est comme pasteuriser le camembert, L.R. --



Bug#327797: bins: contains paths from the build process

2005-09-12 Thread Martin Michlmayr
* Adam Lackorzynski <[EMAIL PROTECTED]> [2005-09-12 11:28]:
> the bins script file contains paths from the build process making it
> unusable because it cannot find its styles etc and therefore does not work:
> 
> ~# grep tbm /usr/bin/bins
> my $localePath = 
> "/home/tbm/tmp/src/b/new/bins-1.1.29/debian/bins/usr/share/locale"; # Base 
> locale path  (for I18N)
>  globalDataDir   => 
> "/home/tbm/tmp/src/b/new/bins-1.1.29/debian/bins/usr/share/bins", # System 
> wide data directory
> 
> It looks like this is a design issue in install.sh which always
> prepends DESTDIR instead of only doing so when operating on files and
> not when replacing paths in the binaries.

Jérôme, can you please apply this patch.

--- install.sh~ 2005-09-12 17:34:57.0 +0100
+++ install.sh  2005-09-12 17:35:27.0 +0100
@@ -24,8 +24,9 @@
 GLOBAL_RC="$RC"
 
 DESTDIR=`echo "$DESTDIR"|sed 's%/$%%'`
-PREFIX=$DESTDIR/`echo "$PREFIX"|sed 's%^/%%'`
 PREFIX=`echo "$PREFIX"|sed 's%/$%%'`
+GLOBAL_SHARE="$PREFIX/share"
+PREFIX=$DESTDIR/`echo "$PREFIX"|sed 's%^/%%'`
 ETC=$DESTDIR/`echo "$ETC"|sed 's%^/%%'`
 ETC=`echo "$ETC"|sed 's%/$%%'`
 RC=$DESTDIR/`echo "$RC"|sed 's%^/%%'`
@@ -227,7 +228,7 @@
 do
   echo -n " $FILE"
   ed "$FILE" 

Bug#327797: bins: contains paths from the build process

2005-09-12 Thread Martin Michlmayr
* Adam Lackorzynski <[EMAIL PROTECTED]> [2005-09-12 11:28]:
> It looks like this is a design issue in install.sh which always
> prepends DESTDIR instead of only doing so when operating on files and
> not when replacing paths in the binaries.

That's possible since I made some changes to install.sh recently.
Sorry about that and thanks for the report.  I'll look into this later
today and upload a fixed package.

-- 
Martin Michlmayr
http://www.cyrius.com/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Bug#327797: bins: contains paths from the build process

2005-09-12 Thread Adam Lackorzynski
Package: bins
Version: 1.1.29-1
Severity: grave
Justification: renders package unusable

Hi,

the bins script file contains paths from the build process making it
unusable because it cannot find its styles etc and therefore does not work:

~# grep tbm /usr/bin/bins
my $localePath = 
"/home/tbm/tmp/src/b/new/bins-1.1.29/debian/bins/usr/share/locale"; # Base 
locale path  (for I18N)
 globalDataDir   => 
"/home/tbm/tmp/src/b/new/bins-1.1.29/debian/bins/usr/share/bins", # System wide 
data directory

It looks like this is a design issue in install.sh which always
prepends DESTDIR instead of only doing so when operating on files and
not when replacing paths in the binaries.



-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages bins depends on:
ii  libhtml-clean-perl  0.8-8Cleans up HTML code for web browse
ii  libhtml-parser-perl 3.45-2   A collection of modules that parse
ii  libhtml-template-perl   2.6-2HTML::Template : A module for usin
ii  libimage-info-perl  1.16-2   allows extraction of meta informat
ii  libimage-size-perl  2.992-1  determine the size of images in se
ii  libio-string-perl   1.05-1   Emulate IO::File interface for in-
ii  libjpeg-progs   6b-10Programs for manipulating JPEG fil
ii  liblocale-gettext-perl  1.05-1   Using libc functions for internati
ii  libtext-iconv-perl  1.4-1converts between character sets in
ii  libtext-unaccent-perl   1.08-1   provides functions to remove accen
ii  libtimedate-perl1.1600-4 Time and date functions for Perl
ii  liburi-perl 1.35-1   Manipulates and accesses URI strin
ii  libxml-enno-perl [libxml-xq 1.05-3   Perl modules for working with XML
ii  libxml-grove-perl   0.46alpha-11 Perl module for accessing parsed *
ii  libxml-handler-yawriter-per 0.23-5   Perl module for writing XML docume
ii  libxml-perl 0.08-1   Perl modules for working with XML
ii  libxml-writer-perl  0.600-1  Perl module for writing XML docume
ii  perlmagick  6:6.2.3.6-3  A perl interface to the libMagick 

bins recommends no packages.

-- no debconf information

Adam
-- 
Adam [EMAIL PROTECTED]
  Lackorzynski http://os.inf.tu-dresden.de/~adam/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]