Bug#331299: exim4: bashisms in init script

2005-10-03 Thread Marc Haber 
On Sun, Oct 02, 2005 at 11:40:29PM +0100, Adam D. Barratt wrote:
 The ==, otoh, *is* non-compliant and a Bashism.

Thanks for spotting this, fixed in svn.

Greetings
Marc

-- 
-
Marc Haber | I don't trust Computers. They | Mailadresse im Header
Mannheim, Germany  |  lose things.Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#331299: exim4: bashisms in init script

2005-10-02 Thread Justin Pryzby 
Package: exim4
Severity: normal
Version: 4.52-1
File: /etc/init.d/exim4

The exim4 initscript /etc/init.d/exim4 uses:

#!/bin/sh

and

kill_all_exims()
{
  SIG=${1:-TERM}
  for pid in $(pidof $NAME); do
if [ $(readlink /proc/$pid/root) == / ]; then
  kill -$SIG $pid
fi
  done
}

Isn't '$(' a bashism (That's what the vim maintainer said in #319825)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#331299: exim4: bashisms in init script

2005-10-02 Thread Marc Haber 
On Sun, Oct 02, 2005 at 05:31:17PM -0400, Justin Pryzby wrote:
 Isn't '$(' a bashism (That's what the vim maintainer said in #319825)

As far as I know, $( is POSIX.

Greetings
Marc

-- 
-
Marc Haber | I don't trust Computers. They | Mailadresse im Header
Mannheim, Germany  |  lose things.Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#331299: exim4: bashisms in init script

2005-10-02 Thread Adam D. Barratt 
On Sun, 2005-10-02 at 17:31 -0400, Justin Pryzby wrote:
 Package: exim4
 Severity: normal
 Version: 4.52-1
 File: /etc/init.d/exim4
 
 The exim4 initscript /etc/init.d/exim4 uses:
 
 #!/bin/sh
[...]
 if [ $(readlink /proc/$pid/root) == / ]; then
[...]
 Isn't '$(' a bashism (That's what the vim maintainer said in #319825)

No, $() should be supported by any POSIX-compliant shell; it's a shall
in the standard. See
http://www.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_06_03

The ==, otoh, *is* non-compliant and a Bashism.

Regards,

Adam


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]