Bug#341117: Please drop the dangerous libssl and libcrypto deps

2005-11-29 Thread Raphaël Enrici
Loic Minier wrote:
 Package: pgadmin3
 Version: 1.2.2-1
 Severity: important
 Tags: patch
 
 Hi,
 
  This situation can cause random segfaults:
 bee% ldd =pgadmin3 | grep ssl
 libssl.so.0.9.7 = /usr/lib/i686/cmov/libssl.so.0.9.7 (0xb7eec000)
 libssl.so.0.9.8 = /usr/lib/i686/cmov/libssl.so.0.9.8 (0xb73fc000)
 
  This is due to the fact that pgadmin is linked with -lssl and -lcrypto,
  and also with -lpq which itself is linked to -lssl... but with
  differing versions.
 
  The attached patch removes the usage of -lssl and -lcrypto when
  dynamically linking pgadmin with libpq, as is the case in Debian.  It's
  really a one liner, but also reruns autoconf.  The result is that:
  Depends: pgadmin3-data (= 1.2.2-1), libc6 (= 2.3.5-1), libgcc1 (=
  1:4.0.1), libpq4, libssl0.9.7, libstdc++6 (= 4.0.1), libwxgtk2.6-0 (=
  2.6.1.2)
 Becomes:
  Depends: pgadmin3-data (= 1.2.2-1.1), libc6 (= 2.3.5-1), libgcc1 (=
  1:4.0.2), libpq4, libstdc++6 (= 4.0.2-4), libwxgtk2.6-0 (= 2.6.1.2)
 
  Let me know if you want me to do a NMU.
 

Hi Loic,

I didn't test myself what you explain here... However it makes sens and
I would appreciate you to NMU. I'm currently working on 1.4.0 release
and will take care of this for the new upstream release. I'll also
contact upstream developer to see how we could enhance the autoconf part
to automagically detect such situation.

Cheers,
Raphaël



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#341117: Please drop the dangerous libssl and libcrypto deps

2005-11-29 Thread Loic Minier
tags 341117 + pending
thanks

On mar, nov 29, 2005, Raphaël Enrici wrote:
 I didn't test myself what you explain here... However it makes sens and
 I would appreciate you to NMU. I'm currently working on 1.4.0 release
 and will take care of this for the new upstream release. I'll also
 contact upstream developer to see how we could enhance the autoconf part
 to automagically detect such situation.

 Ok, I'll upload that.

-- 
Loïc Minier [EMAIL PROTECTED]
What do we want? BRAINS!When do we want it? BRAINS!



Bug#341117: Please drop the dangerous libssl and libcrypto deps

2005-11-28 Thread Loic Minier
Package: pgadmin3
Version: 1.2.2-1
Severity: important
Tags: patch

Hi,

 This situation can cause random segfaults:
bee% ldd =pgadmin3 | grep ssl
libssl.so.0.9.7 = /usr/lib/i686/cmov/libssl.so.0.9.7 (0xb7eec000)
libssl.so.0.9.8 = /usr/lib/i686/cmov/libssl.so.0.9.8 (0xb73fc000)

 This is due to the fact that pgadmin is linked with -lssl and -lcrypto,
 and also with -lpq which itself is linked to -lssl... but with
 differing versions.

 The attached patch removes the usage of -lssl and -lcrypto when
 dynamically linking pgadmin with libpq, as is the case in Debian.  It's
 really a one liner, but also reruns autoconf.  The result is that:
 Depends: pgadmin3-data (= 1.2.2-1), libc6 (= 2.3.5-1), libgcc1 (=
 1:4.0.1), libpq4, libssl0.9.7, libstdc++6 (= 4.0.1), libwxgtk2.6-0 (=
 2.6.1.2)
Becomes:
 Depends: pgadmin3-data (= 1.2.2-1.1), libc6 (= 2.3.5-1), libgcc1 (=
 1:4.0.2), libpq4, libstdc++6 (= 4.0.2-4), libwxgtk2.6-0 (= 2.6.1.2)

 Let me know if you want me to do a NMU.

   Bye,
-- 
Loïc Minier [EMAIL PROTECTED]
--- pgadmin3-1.2.2/debian/changelog
+++ pgadmin3-1.2.2/debian/changelog
@@ -1,3 +1,13 @@
+pgadmin3 (1.2.2-1.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Patch the configure macros to not link against libssl and libcrypto since
+SSL support is provided by libpq, not libssl, and this dependency
+shouldn't be hardcoded; re-run autoconf.
+[acinclude.m4, configure]
+
+ -- Loic Minier [EMAIL PROTECTED]  Mon, 28 Nov 2005 13:51:20 +0100
+
 pgadmin3 (1.2.2-1) unstable; urgency=low
 
   * New upstream release (closes: #288171, #278644, #278855, #250991).
--- pgadmin3-1.2.2.orig/configure
+++ pgadmin3-1.2.2/configure
@@ -982,7 +982,7 @@
 else
   echo $as_me: WARNING: no configuration information is in $ac_dir 2
 fi
-cd $ac_popdir
+cd $ac_popdir
   done
 fi
 
@@ -2406,8 +2406,7 @@
   cat conftest.err 5
   echo $as_me:$LINENO: \$? = $ac_status 5
   (exit $ac_status); } 
-{ ac_try='test -z $ac_c_werror_flag
-|| test ! -s conftest.err'
+{ ac_try='test -z $ac_c_werror_flag   || test ! -s 
conftest.err'
   { (eval echo $as_me:$LINENO: \$ac_try\) 5
   (eval $ac_try) 25
   ac_status=$?
@@ -2465,8 +2464,7 @@
   cat conftest.err 5
   echo $as_me:$LINENO: \$? = $ac_status 5
   (exit $ac_status); } 
-{ ac_try='test -z $ac_c_werror_flag
-|| test ! -s conftest.err'
+{ ac_try='test -z $ac_c_werror_flag   || test ! -s 
conftest.err'
   { (eval echo $as_me:$LINENO: \$ac_try\) 5
   (eval $ac_try) 25
   ac_status=$?
@@ -2582,8 +2580,7 @@
   cat conftest.err 5
   echo $as_me:$LINENO: \$? = $ac_status 5
   (exit $ac_status); } 
-{ ac_try='test -z $ac_c_werror_flag
-|| test ! -s conftest.err'
+{ ac_try='test -z $ac_c_werror_flag   || test ! -s 
conftest.err'
   { (eval echo $as_me:$LINENO: \$ac_try\) 5
   (eval $ac_try) 25
   ac_status=$?
@@ -2637,8 +2634,7 @@
   cat conftest.err 5
   echo $as_me:$LINENO: \$? = $ac_status 5
   (exit $ac_status); } 
-{ ac_try='test -z $ac_c_werror_flag
-|| test ! -s conftest.err'
+{ ac_try='test -z $ac_c_werror_flag   || test ! -s 
conftest.err'
   { (eval echo $as_me:$LINENO: \$ac_try\) 5
   (eval $ac_try) 25
   ac_status=$?
@@ -2683,8 +2679,7 @@
   cat conftest.err 5
   echo $as_me:$LINENO: \$? = $ac_status 5
   (exit $ac_status); } 
-{ ac_try='test -z $ac_c_werror_flag
-|| test ! -s conftest.err'
+{ ac_try='test -z $ac_c_werror_flag   || test ! -s 
conftest.err'
   { (eval echo $as_me:$LINENO: \$ac_try\) 5
   (eval $ac_try) 25
   ac_status=$?
@@ -2728,8 +2723,7 @@
   cat conftest.err 5
   echo $as_me:$LINENO: \$? = $ac_status 5
   (exit $ac_status); } 
-{ ac_try='test -z $ac_c_werror_flag
-|| test ! -s conftest.err'
+{ ac_try='test -z $ac_c_werror_flag   || test ! -s 
conftest.err'
   { (eval echo $as_me:$LINENO: \$ac_try\) 5
   (eval $ac_try) 25
   ac_status=$?
@@ -3087,8 +3081,7 @@
   cat conftest.err 5
   echo $as_me:$LINENO: \$? = $ac_status 5
   (exit $ac_status); } 
-{ ac_try='test -z $ac_cxx_werror_flag
-|| test ! -s conftest.err'
+{ ac_try='test -z $ac_cxx_werror_flag || 
test ! -s conftest.err'
   { (eval echo $as_me:$LINENO: \$ac_try\) 5
   (eval $ac_try) 25
   ac_status=$?
@@ -3146,8 +3139,7 @@
   cat conftest.err 5
   echo $as_me:$LINENO: \$? = $ac_status 5
   (exit $ac_status); } 
-{ ac_try='test -z $ac_cxx_werror_flag
-|| test ! -s conftest.err'
+{ ac_try='test -z $ac_cxx_werror_flag || 
test ! -s conftest.err'
   { (eval echo $as_me:$LINENO: \$ac_try\) 5
   (eval $ac_try) 25
   ac_status=$?
@@ -3218,8 +3210,7 @@
   cat conftest.err 5
   echo