Bug#347858: [Pkg-xfce-devel] Bug#347858: xfdesktop4: scaled option for bg image slightly off
On lun, 2007-05-28 at 13:17 -0400, Dylan Thurston wrote: 1280 and 854 are nearly relatively prime; I doubt you'll be able to reproduce the problem on your screen. The problem is not a 1px border on one or the other edge, the problem is a 1px border on _both_ edges. Indeed, (854/801)*1200 = 1279.400749063670412 which is correctly rounded to to 1279, so the behaviour you report is correct. I now have a 4/3 display, so I tried to reproduce this. I have a SXGA+ display (1400×1050), but even scaling to 1024×768, then choosing the sunset2.jpg background, scaled, I can't reproduce this. Could you retry and report back? (sorry for the delay…) Cheers, -- Yves-Alexis signature.asc Description: This is a digitally signed message part
Bug#347858: [Pkg-xfce-devel] Bug#347858: xfdesktop4: scaled option for bg image slightly off
On Mon, Apr 28, 2008 at 08:34:20PM +0200, Yves-Alexis Perez wrote: On lun, 2007-05-28 at 13:17 -0400, Dylan Thurston wrote: 1280 and 854 are nearly relatively prime; I doubt you'll be able to reproduce the problem on your screen. The problem is not a 1px border on one or the other edge, the problem is a 1px border on _both_ edges. Indeed, (854/801)*1200 = 1279.400749063670412 which is correctly rounded to to 1279, so the behaviour you report is correct. I now have a 4/3 display, so I tried to reproduce this. I have a SXGA+ display (1400×1050), but even scaling to 1024×768, then choosing the sunset2.jpg background, scaled, I can't reproduce this. Could you retry and report back? (sorry for the delay…) I just retried, and the behaviour seems to have been fixed. Best, Dylan Thurston -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#347858: [Pkg-xfce-devel] Bug#347858: xfdesktop4: scaled option for bg image slightly off
Please keep [EMAIL PROTECTED] on CC:, thanks On dim, 2007-05-27 at 21:22 -0400, Dylan Thurston wrote: On Sun, May 27, 2007 at 06:52:48PM +0200, Yves-Alexis Perez wrote: On ven, 2006-01-13 at 11:26 +0100, Yves-Alexis Perez wrote: When I use xfce to set my backdrop on my screen (dimensions 1024x768) to an image which is 1000x750 using the scaled option, the image is not quite scaled properly: I see a 1-pixel-wide border where the background color shows through along the right and bottom edges. Surely scaled means that at least one dimension should be scaled to the full available space? I can't reproduce this, here the scale option works as it should (only one dimension is ajusted, the other one lets see the background color). Could you provide a screenshot, and possibly the wallpaper you used ? Do you have any progress on this, or should we consider the bug fixed? I'm sorry, I never got the earlier e-mail for some reason. I just tried it again, and verified that the bug still exists in xfdesktop4 4.4.1-2. I've attached a screenshot of the buggy behaviour, and the backdrop. Note that I have only observed this bug with this specific scaling. I really can't reproduce this: http://heracles.corsac.net/~corsac/debian/xfce/sunset.png but I don't have a 4:3 display. If you resize manually the picture to be 1024x768 does this still happen? I'll try to trigger the bug by resizing a 1280x854 backdrop to something less and let xfdesktop resize it. Regards, -- Yves-Alexis -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#347858: [Pkg-xfce-devel] Bug#347858: Bug#347858: xfdesktop4: scaled option for bg image slightly off
forwarded #347858 http://bugzilla.xfce.org/show_bug.cgi?id=3299 thanks On lun, 2007-05-28 at 09:17 +0200, Yves-Alexis Perez wrote: I'll try to trigger the bug by resizing a 1280x854 backdrop to something less and let xfdesktop resize it. I have just checked with a 1200x801 wallpaper. I don't have the 1px problem at bottom edge, but I have it on the right edge, so it's reproducible. I've forwarded the bug upstream, and will keep you informed. Regards, -- Yves-Alexis -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#347858: xfdesktop4: scaled option for bg image slightly off
tags 347858 +patch
thanks
On Mon, May 28, 2007 at 09:38:28AM +0200, Yves-Alexis Perez wrote:
I have just checked with a 1200x801 wallpaper. I don't have the 1px
problem at bottom edge, but I have it on the right edge, so it's
reproducible. I've forwarded the bug upstream, and will keep you
informed.
1200/801 is not exactly the same as 1280/854, so it's not clear your
behaviour is actually a bug. (Do you really have a 1280 x 854
display?)
I've attached a proposed fix. I've compiled and installed it, but
haven't yet checked it on a 1024x768 screen.
Peace,
Dylan Thurston
--- xfce-backdrop.c 2007-05-28 11:47:14.0 -0400
+++ xfce-backdrop.c.orig 2007-05-28 11:47:47.0 -0400
@@ -525,7 +525,7 @@
{
GdkPixbuf *final_image, *image = NULL, *tmp;
gint i, j;
-gint w, h, iw = 0, ih = 0, sw, sh;
+gint w, h, iw = 0, ih = 0;
XfceBackdropImageStyle istyle;
gint dx, dy, xo, yo;
gdouble xscale, yscale;
@@ -641,22 +641,18 @@
yscale = (gdouble)h / ih;
if(xscale yscale) {
yscale = xscale;
- sw = w;
- sh = ih * yscale;
xo = 0;
-yo = (h - sh) / 2;
+yo = (h - (ih * yscale)) / 2;
} else {
xscale = yscale;
- sw = iw * xscale;
- sh = h;
-xo = (w - sw) / 2;
+xo = (w - (iw * xscale)) / 2;
yo = 0;
}
dx = xo;
dy = yo;
gdk_pixbuf_composite(image, final_image, dx, dy,
-sw, sh, xo, yo, xscale, yscale,
+iw * xscale, ih * yscale, xo, yo, xscale, yscale,
interp, 255);
break;
signature.asc
Description: Digital signature
Bug#347858: xfdesktop4: scaled option for bg image slightly off
On lun, 2007-05-28 at 11:56 -0400, Dylan Thurston wrote: On Mon, May 28, 2007 at 09:38:28AM +0200, Yves-Alexis Perez wrote: I have just checked with a 1200x801 wallpaper. I don't have the 1px problem at bottom edge, but I have it on the right edge, so it's reproducible. I've forwarded the bug upstream, and will keep you informed. 1200/801 is not exactly the same as 1280/854, so it's not clear your behaviour is actually a bug. (Do you really have a 1280 x 854 display?) 12O0/800 = 1,49812734082397 1280/854 = 1,49882903981265 And yes, I have a 1280x854 display. I've attached a proposed fix. I've compiled and installed it, but haven't yet checked it on a 1024x768 screen. I'll try it and report back (and maybe submit upstream for advice if it work) -- Yves-Alexis -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#347858: xfdesktop4: scaled option for bg image slightly off
On Mon, May 28, 2007 at 06:29:17PM +0200, Yves-Alexis Perez wrote: On lun, 2007-05-28 at 11:56 -0400, Dylan Thurston wrote: On Mon, May 28, 2007 at 09:38:28AM +0200, Yves-Alexis Perez wrote: I have just checked with a 1200x801 wallpaper. I don't have the 1px problem at bottom edge, but I have it on the right edge, so it's reproducible. I've forwarded the bug upstream, and will keep you informed. 1200/801 is not exactly the same as 1280/854, so it's not clear your behaviour is actually a bug. (Do you really have a 1280 x 854 display?) 12O0/800 = 1,49812734082397 1280/854 = 1,49882903981265 And yes, I have a 1280x854 display. 1280 and 854 are nearly relatively prime; I doubt you'll be able to reproduce the problem on your screen. The problem is not a 1px border on one or the other edge, the problem is a 1px border on _both_ edges. Indeed, (854/801)*1200 = 1279.400749063670412 which is correctly rounded to to 1279, so the behaviour you report is correct. Peace, Dylan signature.asc Description: Digital signature
Bug#347858: [Pkg-xfce-devel] Bug#347858: xfdesktop4: scaled option for bg image slightly off
On ven, 2006-01-13 at 11:26 +0100, Yves-Alexis Perez wrote: When I use xfce to set my backdrop on my screen (dimensions 1024x768) to an image which is 1000x750 using the scaled option, the image is not quite scaled properly: I see a 1-pixel-wide border where the background color shows through along the right and bottom edges. Surely scaled means that at least one dimension should be scaled to the full available space? I can't reproduce this, here the scale option works as it should (only one dimension is ajusted, the other one lets see the background color). Could you provide a screenshot, and possibly the wallpaper you used ? Do you have any progress on this, or should we consider the bug fixed? Regards, -- Yves-Alexis -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#347858: [Pkg-xfce-devel] Bug#347858: xfdesktop4: scaled option for bg image slightly off
Dylan Thurston wrote: Package: xfdesktop4 Version: 4.2.3-1 Severity: normal When I use xfce to set my backdrop on my screen (dimensions 1024x768) to an image which is 1000x750 using the scaled option, the image is not quite scaled properly: I see a 1-pixel-wide border where the background color shows through along the right and bottom edges. Surely scaled means that at least one dimension should be scaled to the full available space? I can't reproduce this, here the scale option works as it should (only one dimension is ajusted, the other one lets see the background color). Could you provide a screenshot, and possibly the wallpaper you used ? -- Yves-Alexis Perez signature.asc Description: OpenPGP digital signature
Bug#347858: xfdesktop4: scaled option for bg image slightly off
Package: xfdesktop4 Version: 4.2.3-1 Severity: normal When I use xfce to set my backdrop on my screen (dimensions 1024x768) to an image which is 1000x750 using the scaled option, the image is not quite scaled properly: I see a 1-pixel-wide border where the background color shows through along the right and bottom edges. Surely scaled means that at least one dimension should be scaled to the full available space? -- System Information: Debian Release: testing/unstable APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable') Architecture: i386 (i686) Shell: /bin/sh linked to /bin/bash Kernel: Linux 2.6.14y Locale: LANG=C, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Versions of packages xfdesktop4 depends on: ii libatk1.0-0 1.10.3-1 The ATK accessibility toolkit ii libc6 2.3.5-11 GNU C Library: Shared libraries an ii libglib2.0-0 2.8.5-1The GLib library of C routines ii libgtk2.0-0 2.8.9-2The GTK+ graphical user interface ii libice6 6.9.0.dfsg.1-3 Inter-Client Exchange library ii libpango1.0-0 1.10.2-1 Layout and rendering of internatio ii libsm66.9.0.dfsg.1-3 X Window System Session Management ii libstartup-notification0 0.8-1 library for program launch feedbac ii libx11-6 6.9.0.dfsg.1-3 X Window System protocol client li ii libxfce4mcs-client-2 4.2.3-1Client library for Xfce4 configure ii libxfce4util-14.2.3.2-1 Utility functions library for Xfce ii libxfcegui4-3 4.2.3-1Basic GUI C functions for Xfce4 ii libxml2 2.6.23-1 GNOME XML library ii procps1:3.2.6-2 /proc file system utilities ii xfce4-mcs-manager 4.2.3-1Settings manager for Xfce4 ii xfce4-utils 4.2.3-1Various tools for Xfce ii xlibs 6.9.0.dfsg.1-3 X Window System client libraries m ii zlib1g1:1.2.3-9 compression library - runtime xfdesktop4 recommends no packages. -- no debconf information -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
