Bug#360411: ltsp-server: SECURITY variable broke silently

2006-04-01 Thread Jeff 
Package: ltsp-server
Version: 0.82debian2
Severity: normal

when I made a file /etc/ltsp/ltsp-build-client.conf so I could put in
multiple repositories (see previous bug report), I kept in stuff from
/usr/share/ltsp/ltsp-build-client.conf that I clearly shouldn't have. A
default configuration that works and can be edited might be a good
thing. But more importantly, when ltsp-build-client fails, it should
report an error. If you define the SECURITY variables that are in
/usr/share/ltsp/ltsp-build-client.conf in
/etc/ltsp/ltsp-build-client.conf, ltsp-build-client just returns without
an error.

-- System Information:
Debian Release: 3.1
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.8-3-686
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages ltsp-server depends on:
ii  atftpd   0.7-7   advanced TFTP server
ii  debconf [debconf-2.0 1.4.30.13   Debian configuration management sy
ii  debconf-utils1.4.30.13   debconf utilities
ii  debootstrap  0.2.45-0.2  Bootstrap a basic Debian system
ii  esound-clients   0.2.35-2Enlightened Sound Daemon - clients
ii  iproute  20041019-3  Professional tools to control the 
ii  mknbi1.4.3-2 Create tagged images for Etherboot
ii  netkit-inetd 0.10-10 The Internet Superserver
ii  nfs-kernel-server1:1.0.6-3.1 Kernel NFS server support
ii  ssh  1:3.8.1p1-8.sarge.4 Secure rlogin/rsh/rcp replacement 
ii  syslinux 2.11-0.1Bootloader for Linux/i386 using MS

Versions of packages ltsp-server recommends:
ii  ssh  1:3.8.1p1-8.sarge.4 Secure rlogin/rsh/rcp replacement 

-- debconf information:
  ltsp-server/build_client: false


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#360411: [Pkg-ltsp-devel] Bug#360411: ltsp-server: SECURITY variable broke silently

2006-04-01 Thread Petter Reinholdtsen 
[Jeff]
 when I made a file /etc/ltsp/ltsp-build-client.conf so I could put
 in multiple repositories (see previous bug report), I kept in stuff
 from /usr/share/ltsp/ltsp-build-client.conf that I clearly shouldn't
 have.

Yes.  Only the configuration you need to override should be in
/etc/ltsp/ltsp-build-client.conf.  There is no need to copy the
content of /usr/share/ltsp/ltsp-build-client.conf, as both files are
read by ltsp-build-client.

 A default configuration that works and can be edited might be a good
 thing.

The default configuration work alright.  We should not include a file
in /etc/ltsp/ in the package, as this will make it harder to upgrade
the package when the package-default configuration changes.

 But more importantly, when ltsp-build-client fails, it should report
 an error. If you define the SECURITY variables that are in
 /usr/share/ltsp/ltsp-build-client.conf in
 /etc/ltsp/ltsp-build-client.conf, ltsp-build-client just returns
 without an error.

It is supposed to report an error.  Or at least I thought I had
implemnted that, but I see that was in another LTSP-related script.

I suggest adding code like this to ltsp-build-client, to get it to
report if the build was ok or not when it terminates:

  on_exit() {
[...]
if [ true = $run_successfull ] ; then
echo info: conversion ended successfully
else
echo error: conversion ended abnormally
fi
  }
  trap on_exit EXIT
  [...]
  run_successfull=true # report success to on_exit()
  exit 0


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]