Bug#364048: qof_0.6.4-1(amd64/unstable): FTBFS on 64bit architectures
On Friday 21 April 2006 11:36 pm, Frederik Schueler wrote: On Fri, Apr 21, 2006 at 07:45:20PM +0100, Neil Williams wrote: Could you test this patch for me? I would like to, but the patch does not apply. Investigating by hand, it seems the diff is against an even newer version than in 0.6.4-1: :-( The second patch I sent has been reported to fail by other 64bit testers so I've got - what I hope - is the proper solution and it's tested against the original source. Sorry for the hassle. I was considering a new machine anyway and it looks like it should be a 64bit system! :-) If you need further help... :) I think so! -- Neil Williams = http://www.data-freedom.org/ http://www.nosoftwarepatents.com/ http://www.linux.codehelp.co.uk/ --- qof-0.6.4/qof/test/test-date.c 2005-10-23 12:58:18.0 +0100 +++ /opt/working/qof/qof/test/test-date.c 2006-04-22 19:35:09.0 +0100 @@ -61,15 +61,16 @@ check_time (Timespec ts, gboolean always if (!ok || always_print) { fprintf (stderr, - \n%lld:%lld - %s -\n%lld:%lld - (diff of %lld secs %lld nsecs)\n, - (long long int) ts.tv_sec, - (long long int) ts.tv_nsec, + \n% G_GINT64_FORMAT :%ld - %s -\n +% G_GINT64_FORMAT :%ld + (diff of % G_GINT64_FORMAT secs %ld nsecs)\n, + ts.tv_sec, + ts.tv_nsec, str, - (long long int) ts_2.tv_sec, - (long long int) ts_2.tv_nsec, - (long long int) (ts.tv_sec - ts_2.tv_sec), - (long long int) (ts.tv_nsec - ts_2.tv_nsec)); + ts_2.tv_sec, + ts_2.tv_nsec, + (ts.tv_sec - ts_2.tv_sec), + (ts.tv_nsec - ts_2.tv_nsec)); if (!ok) { @@ -93,8 +94,8 @@ check_conversion (const char * str, Time if ((expected_ts.tv_sec != ts.tv_sec) || (expected_ts.tv_nsec != ts.tv_nsec)) { fprintf (stderr, - \nmis-converted \%s\ to %lld.%09ld seconds\n - \twas expecting %lld.%09ld seconds\n, + \nmis-converted \%s\ to % G_GINT64_FORMAT .%09ld seconds\n + \twas expecting % G_GINT64_FORMAT .%09ld seconds\n, str, ts.tv_sec, ts.tv_nsec, expected_ts.tv_sec, expected_ts.tv_nsec); failure (misconverted timespec); pgpeKG7NIbvCi.pgp Description: PGP signature
Bug#364048: qof_0.6.4-1(amd64/unstable): FTBFS on 64bit architectures
Hello, On Sat, Apr 22, 2006 at 08:08:36PM +0100, Neil Williams wrote: The second patch I sent has been reported to fail by other 64bit testers so I've got - what I hope - is the proper solution and it's tested against the original source. it works now :-) Best regards Frederik Schueler -- ENOSIG signature.asc Description: Digital signature
Bug#364048: qof_0.6.4-1(amd64/unstable): FTBFS on 64bit architectures
Package: qof Version: 0.6.4-1 Severity: serious Hello, There was an error while trying to autobuild your package: creating test-book-merge cc -DHAVE_CONFIG_H -I. -I. -I../.. -I. -I../ -I../../qof -I../../lib/libsql -I.. -I../.. -I../../.. -I../../qof -I/usr/include/libxml2 -I/usr/include/libgda-1.2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -Werror -Wmissing-prototypes -Wmissing-declarations -g -Wall -O2 -g2 -Wall -c test-date.c cc1: warnings being treated as errors test-date.c: In function 'check_conversion': test-date.c:99: warning: format '%lld' expects type 'long long int', but argument 4 has type 'guint64' test-date.c:99: warning: format '%lld' expects type 'long long int', but argument 6 has type 'guint64' make[4]: *** [test-date.o] Error 1 make[4]: Leaving directory `/build/buildd/qof-0.6.4/qof/test' make[3]: *** [all-recursive] Error 1 make[3]: Leaving directory `/build/buildd/qof-0.6.4/qof' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/build/buildd/qof-0.6.4' make[1]: *** [all] Error 2 make[1]: Leaving directory `/build/buildd/qof-0.6.4' make: *** [debian/stamp-makefile-build] Error 2 A full build log can be found at: http://buildd.debian.org/build.php?arch=amd64pkg=qofver=0.6.4-1 Best regards Frederik Schueler -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#364048: qof_0.6.4-1(amd64/unstable): FTBFS on 64bit architectures
Hi Frederick, Could you test this patch for me? I hope it's simply a typo in the selection of the unsigned macro instead of the signed. I can then arrange to include the patch in a -2 upload. Thanks. -- Neil Williams = http://www.data-freedom.org/ http://www.nosoftwarepatents.com/ http://www.linux.codehelp.co.uk/ ? test-date.c.patch Index: test-date.c === RCS file: /var/lib/cvs/qof/qof/test/test-date.c,v retrieving revision 1.10 diff -p -u -b -B -r1.10 test-date.c --- test-date.c 17 Apr 2006 22:09:15 - 1.10 +++ test-date.c 21 Apr 2006 18:42:46 - @@ -61,9 +61,9 @@ check_time (Timespec ts, gboolean always if (!ok || always_print) { fprintf (stderr, - \n% G_GUINT64_FORMAT :% G_GUINT64_FORMAT - %s -\n - % G_GUINT64_FORMAT :% G_GUINT64_FORMAT - (diff of % G_GUINT64_FORMAT secs % G_GUINT64_FORMAT nsecs)\n, + \n% G_GINT64_FORMAT :% G_GINT64_FORMAT - %s -\n + % G_GINT64_FORMAT :% G_GINT64_FORMAT + (diff of % G_GINT64_FORMAT secs % G_GINT64_FORMAT nsecs)\n, (long long int) ts.tv_sec, (long long int) ts.tv_nsec, str, @@ -94,8 +94,8 @@ check_conversion (const char * str, Time if ((expected_ts.tv_sec != ts.tv_sec) || (expected_ts.tv_nsec != ts.tv_nsec)) { fprintf (stderr, - \nmis-converted \%s\ to % G_GUINT64_FORMAT .%09ld seconds\n - \twas expecting % G_GUINT64_FORMAT .%09ld seconds\n, + \nmis-converted \%s\ to % G_GINT64_FORMAT .%09ld seconds\n + \twas expecting % G_GINT64_FORMAT .%09ld seconds\n, str, ts.tv_sec, ts.tv_nsec, expected_ts.tv_sec, expected_ts.tv_nsec); failure (misconverted timespec); pgpylpXW6zQz4.pgp Description: PGP signature
Bug#364048: qof_0.6.4-1(amd64/unstable): FTBFS on 64bit architectures
Hi Frederick, Try this one instead! (Oops, sent you a patch made against a local copy instead of the released source.) -- Neil Williams = http://www.data-freedom.org/ http://www.nosoftwarepatents.com/ http://www.linux.codehelp.co.uk/ --- qof-0.6.4/qof/test/test-date.c 2005-10-23 12:58:18.0 +0100 +++ /opt/working/qof/qof/test/test-date.c 2006-04-21 19:40:32.0 +0100 @@ -61,8 +61,9 @@ check_time (Timespec ts, gboolean always if (!ok || always_print) { fprintf (stderr, - \n%lld:%lld - %s -\n%lld:%lld - (diff of %lld secs %lld nsecs)\n, + \n% G_GINT64_FORMAT :% G_GINT64_FORMAT - %s -\n + % G_GINT64_FORMAT :% G_GINT64_FORMAT + (diff of % G_GINT64_FORMAT secs % G_GINT64_FORMAT nsecs)\n, (long long int) ts.tv_sec, (long long int) ts.tv_nsec, str, @@ -93,8 +94,8 @@ check_conversion (const char * str, Time if ((expected_ts.tv_sec != ts.tv_sec) || (expected_ts.tv_nsec != ts.tv_nsec)) { fprintf (stderr, - \nmis-converted \%s\ to %lld.%09ld seconds\n - \twas expecting %lld.%09ld seconds\n, + \nmis-converted \%s\ to % G_GINT64_FORMAT .%09ld seconds\n + \twas expecting % G_GINT64_FORMAT .%09ld seconds\n, str, ts.tv_sec, ts.tv_nsec, expected_ts.tv_sec, expected_ts.tv_nsec); failure (misconverted timespec); pgpmnSsHovqOK.pgp Description: PGP signature
Bug#364048: qof_0.6.4-1(amd64/unstable): FTBFS on 64bit architectures
Hello, On Fri, Apr 21, 2006 at 07:45:20PM +0100, Neil Williams wrote: Could you test this patch for me? I would like to, but the patch does not apply. Investigating by hand, it seems the diff is against an even newer version than in 0.6.4-1: if (!ok || always_print) { fprintf (stderr, \n%lld:%lld - %s -\n%lld:%lld (diff of %lld secs %lld nsecs)\n, (long long int) ts.tv_sec, (long long int) ts.tv_nsec, str, [...] ? test-date.c.patch Index: test-date.c === RCS file: /var/lib/cvs/qof/qof/test/test-date.c,v retrieving revision 1.10 diff -p -u -b -B -r1.10 test-date.c --- test-date.c 17 Apr 2006 22:09:15 - 1.10 +++ test-date.c 21 Apr 2006 18:42:46 - @@ -61,9 +61,9 @@ check_time (Timespec ts, gboolean always if (!ok || always_print) { fprintf (stderr, - \n% G_GUINT64_FORMAT :% G_GUINT64_FORMAT - %s -\n - % G_GUINT64_FORMAT :% G_GUINT64_FORMAT - (diff of % G_GUINT64_FORMAT secs % G_GUINT64_FORMAT nsecs)\n, + \n% G_GINT64_FORMAT :% G_GINT64_FORMAT - %s -\n + % G_GINT64_FORMAT :% G_GINT64_FORMAT + (diff of % G_GINT64_FORMAT secs % G_GINT64_FORMAT nsecs)\n, (long long int) ts.tv_sec, (long long int) ts.tv_nsec, str, @@ -94,8 +94,8 @@ check_conversion (const char * str, Time if ((expected_ts.tv_sec != ts.tv_sec) || (expected_ts.tv_nsec != ts.tv_nsec)) { fprintf (stderr, - \nmis-converted \%s\ to % G_GUINT64_FORMAT .%09ld seconds\n - \twas expecting % G_GUINT64_FORMAT .%09ld seconds\n, + \nmis-converted \%s\ to % G_GINT64_FORMAT .%09ld seconds\n + \twas expecting % G_GINT64_FORMAT .%09ld seconds\n, str, ts.tv_sec, ts.tv_nsec, expected_ts.tv_sec, expected_ts.tv_nsec); failure (misconverted timespec); it looks like a fix for the fix. If you need further help... :) best regards Frederik Schueler -- ENOSIG signature.asc Description: Digital signature