Bug#365332: libdvdread

2006-05-03 Thread Daniel Baumann 
Stephen Gran wrote:
> Daniel, can you make sure to increment the shlibs accordingly?  I am
> going to have to use some new functions from this version.

sure.

-- 
Address:Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:  [EMAIL PROTECTED]
Internet:   http://people.panthera-systems.net/~daniel-baumann/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Bug#365332: libdvdread

2006-05-03 Thread Stephen Gran 
This one time, at band camp, Bj|rn Englund said:
> Sorry for the delay but now 
> I have released libdvdread-0.9.6.
> Hopefully the dvdbackup patch will work now :)

Good news, thank you.

Daniel, can you make sure to increment the shlibs accordingly?  I am
going to have to use some new functions from this version.

Thanks,
-- 
 -
|   ,''`.Stephen Gran |
|  : :' :[EMAIL PROTECTED] |
|  `. `'Debian user, admin, and developer |
|`- http://www.debian.org |
 -


signature.asc
Description: Digital signature

Bug#365332: libdvdread

2006-05-03 Thread Bj|rn Englund 
Sorry for the delay but now 
I have released libdvdread-0.9.6.
Hopefully the dvdbackup patch will work now :)

/Bj|rn 


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Bug#365332: libdvdread

2006-04-30 Thread Bj|rn Englund 
Sun Apr 30 2006, Stephen Gran wrote:
> This one time, at band camp, Björn Englund said:
> > I forgot to attach the patch in the previous email, here it is.
> 
> > +   dvd_stat_t statbuf;
> > +   
> > +   if ( DVDFileStat(_dvd, 0, DVD_READ_INFO_FILE, &statbuf) != -1 ) {
> 
> The struct dvd_stat_t and the function DVDFileStat appear not to be
> defined in the libdvdread headers, so this patch doesn't work as I expected
> it to.  Or is this patch based on a version of dvdbackup where these are
> defined in dvdbackup itself?  Being dead upstream, it has probably
> forked significantly in different people's hands.
> 
As I wrote in the previous email, this patch works with the cvs of libdvdread
which will be released as libdvdread-0.9.6 next week (probably tomorrow).

And I am pretty sure dvdbackup is the only program that is using udffindfile,
I have not seen any comments about it for other programs. And it was not
included in the installed header files in 0.9.4.

/Bj|rn

Bug#365332: libdvdread

2006-04-30 Thread Stephen Gran 
This one time, at band camp, Bj|rn Englund said:
> Sun Apr 30 2006, Stephen Gran wrote:
> > This one time, at band camp, Björn Englund said:
> > > I forgot to attach the patch in the previous email, here it is.
> > 
> > > + dvd_stat_t statbuf;
> > > + 
> > > + if ( DVDFileStat(_dvd, 0, DVD_READ_INFO_FILE, &statbuf) != -1 ) {
> > 
> > The struct dvd_stat_t and the function DVDFileStat appear not to be
> > defined in the libdvdread headers, so this patch doesn't work as I expected
> > it to.  Or is this patch based on a version of dvdbackup where these are
> > defined in dvdbackup itself?  Being dead upstream, it has probably
> > forked significantly in different people's hands.
> > 
> As I wrote in the previous email, this patch works with the cvs of libdvdread
> which will be released as libdvdread-0.9.6 next week (probably tomorrow).

Oh, I see - I misunderstood that part.  Sorry about that.  I will retest
after the new libdvdread is released.

> And I am pretty sure dvdbackup is the only program that is using udffindfile,
> I have not seen any comments about it for other programs.

OK - as I said, if we are fairly sure that dvdbackup is the only one,
then it's likely not a problem.  I was bringing it up because it is
common practice, so as to avoid problems with apps we don't know about.

> And it was not included in the installed header files in 0.9.4.

True.  Well, I leave to to your discretion, then.

Take care,
-- 
 -
|   ,''`.Stephen Gran |
|  : :' :[EMAIL PROTECTED] |
|  `. `'Debian user, admin, and developer |
|`- http://www.debian.org |
 -


signature.asc
Description: Digital signature

Bug#365332: libdvdread

2006-04-30 Thread Stephen Gran 
This one time, at band camp, Björn Englund said:
> I forgot to attach the patch in the previous email, here it is.

> + dvd_stat_t statbuf;
> + 
> + if ( DVDFileStat(_dvd, 0, DVD_READ_INFO_FILE, &statbuf) != -1 ) {

The struct dvd_stat_t and the function DVDFileStat appear not to be
defined in the libdvdread headers, so this patch doesn't work as I expected
it to.  Or is this patch based on a version of dvdbackup where these are
defined in dvdbackup itself?  Being dead upstream, it has probably
forked significantly in different people's hands.

Thanks again,
-- 
 -
|   ,''`.Stephen Gran |
|  : :' :[EMAIL PROTECTED] |
|  `. `'Debian user, admin, and developer |
|`- http://www.debian.org |
 -


signature.asc
Description: Digital signature

Bug#365332: libdvdread

2006-04-29 Thread Stephen Gran 
This one time, at band camp, Björn Englund said:
> Sat Apr 29 2006, Daniel Baumann wrote:
> > Hi,
> > 
> > we have some problems[0] in Debian with the libdvdread 0.9.5. It seems,
> > that the UDFFindFile (and some others) are no longer exportet. Is this
> > done intenionally or accidently?
> > 
> > If intenionally, how about bumping the soname to reflect this changes?
> > If accidently, how about releasing a fixed tarball (0.9.5a or similar)?
> > 
> UDFFindFile was not (intentionally) exported in 0.9.4 either.
> Just some patch that was floating around and to my knowledge only used
> by one project(dvdbackup). I made a patch for that project to use other
> functions instead of udffindfile. This will work against the cvs version of
> libdvdread which will be 0.9.6. I sent the patch to the author of
> dvdbackup but I don't know if he received it or has applied it.

Hi there.  I am the Debian maintainer of dvdbackup.  It is my impression
that upstream dvdbackup has disappeared.  At the very least, they don't
answer my patches.

I am happy to apply the patch you sent (thanks for that, by the way) but
I do feel a bit like the soname should change when exported symbols are
dropped, even if they were accidentally exported.  If dvdbackup is
definitely the only piece of software using a symbol that was supposed
to be internal, then I agree, I'll just apply the patch and move on.
But it is difficult to be sure, and that's why I mention it.

> Are there any other projects in debian that are using UDFFindFile
> or other functions that aren't exported?

I will attempt to look in the morning and see if I can identify any
others.

> I'm going to release 0.9.6 next week (small fixes for macos/bsd and
> some extra functions to get the information needed by dvdbackup) so
> you could maybe apply the attached patch to dvdbackup in debian then?
> Does this seem ok ?

I will definitely apply the patch and get it uploaded shortly.  It is
just other unidentified software suites I am worried about.

Thanks very much,
-- 
 -
|   ,''`.Stephen Gran |
|  : :' :[EMAIL PROTECTED] |
|  `. `'Debian user, admin, and developer |
|`- http://www.debian.org |
 -


signature.asc
Description: Digital signature

Bug#365332: libdvdread

2006-04-29 Thread Björn Englund 
Sat Apr 29 2006, Daniel Baumann wrote:
> Hi,
> 
> we have some problems[0] in Debian with the libdvdread 0.9.5. It seems,
> that the UDFFindFile (and some others) are no longer exportet. Is this
> done intenionally or accidently?
> 
> If intenionally, how about bumping the soname to reflect this changes?
> If accidently, how about releasing a fixed tarball (0.9.5a or similar)?
> 
UDFFindFile was not (intentionally) exported in 0.9.4 either.
Just some patch that was floating around and to my knowledge only used
by one project(dvdbackup). I made a patch for that project to use other
functions instead of udffindfile. This will work against the cvs version of
libdvdread which will be 0.9.6. I sent the patch to the author of
dvdbackup but I don't know if he received it or has applied it.

Are there any other projects in debian that are using UDFFindFile
or other functions that aren't exported?

I'm going to release 0.9.6 next week (small fixes for macos/bsd and
some extra functions to get the information needed by dvdbackup) so
you could maybe apply the attached patch to dvdbackup in debian then?
Does this seem ok ?

/Bj|rn






-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Bug#365332: libdvdread

2006-04-29 Thread Björn Englund 
I forgot to attach the patch in the previous email, here it is.

/Bj|rn

--- dvdbackup.c.orig2006-03-02 19:09:52.0 +0100
+++ dvdbackup.c 2006-03-02 20:14:25.0 +0100
@@ -30,6 +30,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -1656,15 +1657,14 @@
 
 
/* DVD Video files */
-   charfilename[MAXNAME];
-   int size;
+   dvd_stat_t statbuf;
 
/*DVD ifo handler*/
ifo_handle_t *  vmg_ifo=NULL;
 
/* The Title Set Info struct*/
title_set_info_t * title_set_info;
-
+   
/*  Open main info file */
vmg_ifo = ifoOpen( _dvd, 0 );
if( !vmg_ifo ) {
@@ -1687,10 +1687,9 @@
 
/* Find VIDEO_TS.IFO is present - must be present since we did a ifo 
open 0*/
 
-   sprintf(filename,"/VIDEO_TS/VIDEO_TS.IFO");
-
-   if ( UDFFindFile(_dvd, filename, &size) != 0 ) {
-   title_set_info->title_set[0].size_ifo = size;
+   
+   if ( DVDFileStat(_dvd, 0, DVD_READ_INFO_FILE, &statbuf) != -1 ) {
+   title_set_info->title_set[0].size_ifo = statbuf.size;
} else {
DVDFreeTitleSetInfo(title_set_info);
return(0);
@@ -1700,20 +1699,18 @@
 
/* Find VIDEO_TS.VOB if present*/
 
-   sprintf(filename,"/VIDEO_TS/VIDEO_TS.VOB");
 
-   if ( UDFFindFile(_dvd, filename, &size) != 0 ) {
-   title_set_info->title_set[0].size_menu = size;
+   if ( DVDFileStat(_dvd, 0, DVD_READ_MENU_VOBS, &statbuf) != -1 ) {
+   title_set_info->title_set[0].size_menu = statbuf.size;
} else {
title_set_info->title_set[0].size_menu = 0 ;
}
 
/* Find VIDEO_TS.BUP if present */
 
-   sprintf(filename,"/VIDEO_TS/VIDEO_TS.BUP");
 
-   if ( UDFFindFile(_dvd, filename, &size) != 0 ) {
-   title_set_info->title_set[0].size_bup = size;
+   if (DVDFileStat(_dvd, 0, DVD_READ_INFO_BACKUP_FILE, &statbuf) != -1) {
+   title_set_info->title_set[0].size_bup = statbuf.size;
} else {
DVDFreeTitleSetInfo(title_set_info);
return(0);
@@ -1745,10 +1742,9 @@
}
 
 
-   sprintf(filename,"/VIDEO_TS/VTS_%02i_0.IFO",counter + 
1);
 
-   if ( UDFFindFile(_dvd, filename, &size) != 0 ) {
-   title_set_info->title_set[counter + 1].size_ifo 
= size;
+   if ( DVDFileStat(_dvd, counter + 1, DVD_READ_INFO_FILE, 
&statbuf) != -1) {
+   title_set_info->title_set[counter+1].size_ifo = 
statbuf.size;
} else {
DVDFreeTitleSetInfo(title_set_info);
return(0);
@@ -1761,10 +1757,9 @@
 
/* Find VTS_XX_0.VOB if present*/
 
-   sprintf(filename,"/VIDEO_TS/VTS_%02i_0.VOB", counter + 
1);
 
-   if ( UDFFindFile(_dvd, filename, &size) != 0 ) {
-   title_set_info->title_set[counter + 
1].size_menu = size;
+   if ( DVDFileStat(_dvd, counter + 1, DVD_READ_MENU_VOBS, 
&statbuf) != -1) {
+   title_set_info->title_set[counter + 
1].size_menu = statbuf.size;
} else {
title_set_info->title_set[counter + 
1].size_menu = 0 ;
}
@@ -1776,13 +1771,12 @@
 
 
/* Find all VTS_XX_[1 to 9].VOB files if they are 
present*/
-
-   for( i = 0; i < 9; ++i ) {
-   sprintf(filename,"/VIDEO_TS/VTS_%02i_%i.VOB", 
counter + 1, i + 1 );
-   if(UDFFindFile(_dvd, filename, &size) == 0 ) {
-   break;
+   i = 0;
+   if ( DVDFileStat(_dvd, counter + 1, 
DVD_READ_TITLE_VOBS, &statbuf) != -1) {
+   for ( i = 0; i < statbuf.nr_parts; ++i) {
+   title_set_info->title_set[counter + 
1].size_vob[i] = statbuf.parts_size[i];
}
-   title_set_info->title_set[counter + 
1].size_vob[i] = size;
+
}
title_set_info->title_set[counter + 
1].number_of_vob_files = i;
 
@@ -1791,10 +1785,9 @@
}
 
 
-   sprintf(filename,"/VIDEO_TS/VTS_%02i_0.BUP", counter + 
1);
 
-   if ( UDFFindFile(_dvd, filename, &size) != 0 ) {
-   title_set_info->title_set[counter +1].size_bup 
= size;
+   if ( DVDFileStat(_dvd, counter + 1, 
DVD_READ_INFO_BACKUP_FILE, &statbuf) != -1) {
+   title_set_info->title_set[counter + 1].size_bup 
= statbuf.size;
} else {