Bug#383124: umountnfs.sh: Patch to also unmount filesystems on network block devices
tags 383123 + patch tags 383124 + patch thanks > It calls umount unconditionally, as I couldn't see any harm in doing > it this way. I do not like this approach. It bypasses the error reporting code. Can you try this patch and see if it work too? Index: debian/changelog === --- debian/changelog(revisjon 826) +++ debian/changelog(arbeidskopi) @@ -25,6 +25,7 @@ * Split killall5, last, lastb, mesg and pidof out of the sysvinit package into a new sysvutils package to make it easier to replace init. (Closes: #385722) + * Umount netdev file systems in umountnfs.sh. (Closes: #383124) -- Petter Reinholdtsen <[EMAIL PROTECTED]> Wed, 26 Jul 2006 11:37:23 +0200 Index: debian/initscripts/etc/init.d/umountnfs.sh === --- debian/initscripts/etc/init.d/umountnfs.sh (revisjon 815) +++ debian/initscripts/etc/init.d/umountnfs.sh (arbeidskopi) @@ -45,7 +45,7 @@ exec 9<&0
Bug#383124: umountnfs.sh: Patch to also unmount filesystems on network block devices
[Andrew Pollock] > Dammit. This is what I get for waiting so long to test it. No, this > does not work, because you're parsing /proc/mounts, not /etc/fstab, > so you don't get the _netdev option. It no workee. Thanks for testing. I suggest we solve this by letting umountnfs use /etc/mtab, and umountfs use /proc/mounts. I believe mtab will include the _netdev option. This should make sure all file systems are umounted, and handle netdevices correctly too. Can you test this and send a patch if it work? -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#383124: umountnfs.sh: Patch to also unmount filesystems on network block devices
Package: initscripts Version: 2.86.ds1-15 Severity: normal This bug also relates to #383073, feel free to merge if you see fit. Please find attached a patch that will unmount filesystems on network block devices as well. It calls umount unconditionally, as I couldn't see any harm in doing it this way. regards Andrew -- System Information: Debian Release: testing/unstable APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing') Architecture: i386 (i686) Shell: /bin/sh linked to /bin/bash Kernel: Linux 2.6.15-1-686 Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8) Versions of packages initscripts depends on: ii debianutils 2.15.2 Miscellaneous utilities specific t ii e2fsprogs 1.38+1.39-WIP-2005.12.31-1 ext2 file system utilities and lib ii libc6 2.3.6-7GNU C Library: Shared libraries ii lsb-base 3.0-15 Linux Standard Base 3.0 init scrip ii mount 2.12r-6Tools for mounting and manipulatin initscripts recommends no packages. -- no debconf information --- /etc/init.d/umountnfs.sh.orig 2006-08-14 20:56:55.0 -0700 +++ /etc/init.d/umountnfs.sh2006-08-14 20:58:03.0 -0700 @@ -69,6 +69,7 @@ umount $FLAGS $DIRS fi ES=$? + umount -a -O _netdev [ "$VERBOSE" = no ] || log_action_end_msg $ES }
