Bug#389057: ircd-hybrid: Please rework the servlink-path-notice debconf template
severity 389057 minor tags 389057 - wontfix tags 389057 + pending tags 389439 + pending thanks On Sun, Sep 24, 2006 at 01:45:48AM +0200, Thomas Huriaux wrote: - debconf misuse/abuse I can understand that one now with the finally correct explaination you displayed in your reply. Thanks. Sorry, without knowing the package that looked like an error. But I was obviously wrong and the severity should be raised or the template removed. I have to fix the upgrade path for etch, so in the mean time, I am willing to remove the template and setup a note in README.Debian. Cheers, -- .''`. Aurélien GÉRÔME : :' : `. `'` Free Software Developer `- Unix Sys Net Admin signature.asc Description: Digital signature
Bug#389057: ircd-hybrid: Please rework the servlink-path-notice debconf template
Package: ircd-hybrid Version: 1:7.2.2-2 Severity: minor Tags: patch Hi, I've found the following problems with the ircd-hybrid/servlink-path-notice template: * the error type seems to be more appropriate for this template. See also the recent discussion on debian-devel about note templates displayed with a low or medium priority. * the following line in your config file: if [ -f /etc/ircd-hybrid/ircd.conf ]; then tests the existance of the ircd.conf file, so the adjective possibly is pointless * the following line in your config file: if egrep -q '[\t ]*[^#]+servlink_path' /etc/ircd-hybrid/ircd.conf; tests if there is a servlink_path directive, so the if-then construction of your sentence is pointless. A patch with a suggested rephrasing is attached. May I take the opportunity of this bug to ask you to send a request for review of the French translation to debian-l10n-french? Cheers, -- Thomas Huriaux --- ircd-hybrid.templates.orig 2006-09-23 18:11:57.0 +0200 +++ ircd-hybrid.templates 2006-09-23 18:13:01.0 +0200 @@ -1,8 +1,8 @@ Template: ircd-hybrid/servlink-path-notice -Type: note -_Description: ircd-hybrid should not configure servlink_path variable - If your possibly existing ircd.conf that you may wish to import contains a - servlink_path directive, either change it to: +Type: error +_Description: servlink_path variable not configurable + Your existing ircd.conf that you may wish to import contains a + servlink_path directive. Either change it to: . servlink_path = /usr/lib/ircd-hybrid/servlink; . signature.asc Description: Digital signature
Bug#389057: ircd-hybrid: Please rework the servlink-path-notice debconf template
severity 389057 wishlist tags 389057 wontfix thanks On Sat, Sep 23, 2006 at 06:31:01PM +0200, Thomas Huriaux wrote: I've found the following problems with the ircd-hybrid/servlink-path-notice template: * the error type seems to be more appropriate for this template. See also the recent discussion on debian-devel about note templates displayed with a low or medium priority. This is *not* an error type, but really a note. Moreover, this only happens with the SSL-enabled build which is *not* in the archive, but the build system is provided for the users' convenience. Therefore, you will *not* see it with the standard Debian package present in the archive. * the following line in your config file: if [ -f /etc/ircd-hybrid/ircd.conf ]; then tests the existance of the ircd.conf file, so the adjective possibly is pointless I think it reflects the reality better, because this message occurs *if* the config file exists. * the following line in your config file: if egrep -q '[\t ]*[^#]+servlink_path' /etc/ircd-hybrid/ircd.conf; tests if there is a servlink_path directive, so the if-then construction of your sentence is pointless. Same comment here, because it occurs *if* the config file contains the servlink_path directive. For those two points, it is needed to inform the user why he got the message. May I take the opportunity of this bug to ask you to send a request for review of the French translation to debian-l10n-french? This is weird, because I did not touch any templates when revving up the package to the new upstream release, so it is accurrate. Feel free to do it yourself. In any case, this is my understanding of this nonsense bug to my mind. Joshua, feel free to remove the wontfix tag and to fix it accordingly to your belief of what you wrote back then as a native speaker. :) Cheers, -- .''`. Aurélien GÉRÔME : :' : `. `'` Free Software Developer `- Unix Sys Net Admin signature.asc Description: Digital signature
Bug#389057: ircd-hybrid: Please rework the servlink-path-notice debconf template
On Sun, Sep 24, 2006 at 12:50:32AM +0200, Thomas Huriaux wrote: Note that I mentioned different problems here (I opened only one bug as they were for only one template, but seeing how you reacted once again, I should have done it another way). Here is a clear list for Joshua if Another way? he wants to fix it: - debconf misuse/abuse I can understand that one now with the finally correct explaination you displayed in your reply. Thanks. - use of a text obviously written for another code Can you explain that one? What code are you talking about? - malformed title (this was only in the patch: a sentence without a period does not make it a correct title) Same here. Cheers, -- .''`. Aurélien GÉRÔME : :' : `. `'` Free Software Developer `- Unix Sys Net Admin signature.asc Description: Digital signature
Bug#389057: ircd-hybrid: Please rework the servlink-path-notice debconf template
Aurélien GÉRÔME [EMAIL PROTECTED] (23/09/2006): severity 389057 wishlist tags 389057 wontfix thanks I think you misunderstood my bug and have not read my patch. On Sat, Sep 23, 2006 at 06:31:01PM +0200, Thomas Huriaux wrote: I've found the following problems with the ircd-hybrid/servlink-path-notice template: * the error type seems to be more appropriate for this template. See also the recent discussion on debian-devel about note templates displayed with a low or medium priority. This is *not* an error type, but really a note. Moreover, this only happens with the SSL-enabled build which is *not* in the archive, but the build system is provided for the users' convenience. Therefore, you will *not* see it with the standard Debian package present in the archive. If this is not an error, raise the priority. If having this line in the configuration file does not justify a high severity for the debconf template, remove it. * the following line in your config file: if [ -f /etc/ircd-hybrid/ircd.conf ]; then tests the existance of the ircd.conf file, so the adjective possibly is pointless I think it reflects the reality better, because this message occurs *if* the config file exists. So if the config file *does* exist, you tell the user that the file *may* exist? I would tell the user it *does* exist. * the following line in your config file: if egrep -q '[\t ]*[^#]+servlink_path' /etc/ircd-hybrid/ircd.conf; tests if there is a servlink_path directive, so the if-then construction of your sentence is pointless. Same comment here, because it occurs *if* the config file contains the servlink_path directive. So if the config file *does* contain the servlink_path directive, you tell the user that the file *may* contain the servlink_path directive? I would tell the user it *does* contain the servlink_path directive. For those two points, it is needed to inform the user why he got the message. May I take the opportunity of this bug to ask you to send a request for review of the French translation to debian-l10n-french? This is weird, because I did not touch any templates when revving up the package to the new upstream release, so it is accurrate. Feel free to do it yourself. I'll update and review it. In any case, this is my understanding of this nonsense bug to my mind. No, this nonsense bug about this nonsense template is because Christian used a 4-days old list for the MBF about debconf abuse, and I updated the list today to find new ones. This template was not db_input'ed in the previous binary package of ircd-hybrid, and was therefore not included in the MBF. Joshua, feel free to remove the wontfix tag and to fix it accordingly to your belief of what you wrote back then as a native speaker. :) Note that I mentioned different problems here (I opened only one bug as they were for only one template, but seeing how you reacted once again, I should have done it another way). Here is a clear list for Joshua if he wants to fix it: - debconf misuse/abuse - use of a text obviously written for another code - malformed title (this was only in the patch: a sentence without a period does not make it a correct title) -- Thomas Huriaux signature.asc Description: Digital signature
Bug#389057: ircd-hybrid: Please rework the servlink-path-notice debconf template
Aurélien GÉRÔME [EMAIL PROTECTED] (24/09/2006): On Sun, Sep 24, 2006 at 12:50:32AM +0200, Thomas Huriaux wrote: Note that I mentioned different problems here (I opened only one bug as they were for only one template, but seeing how you reacted once again, I should have done it another way). Here is a clear list for Joshua if Another way? Opening different bugs, to avoid having everything marked as wontfix. I won't clone a bug marked as wontfix. he wants to fix it: - debconf misuse/abuse I can understand that one now with the finally correct explaination you displayed in your reply. Thanks. Sorry, without knowing the package that looked like an error. But I was obviously wrong and the severity should be raised or the template removed. - use of a text obviously written for another code Can you explain that one? What code are you talking about? The code I quoted in my first mail: |if [ -f /etc/ircd-hybrid/ircd.conf ]; then | if egrep -q '[\t ]*[^#]+servlink_path' /etc/ircd-hybrid/ircd.conf; | then If this code wasn't there, I could have understood the possibly existing and the if [...] contains. I therefore assume that these two checks have been added only after the text of the template was written. - malformed title (this was only in the patch: a sentence without a period does not make it a correct title) Same here. The short description of a note/error/text template should be considered as a title (see the dev-ref). In my patch, there is |-_Description: ircd-hybrid should not configure servlink_path variable |+_Description: servlink_path variable not configurable to make the short description a valid title. Cheers, -- Thomas Huriaux signature.asc Description: Digital signature
