Bug#391810: gtkpod: Deadly slow operation on NFS-mounted volumes

[Mikhail Gusarov]

tag 391810 +patch
thanks

mp3info.c improperly calculates chunk size in mp3s (as deduced from
reading source code and this documentation:
http://www.oreilly.com/catalog/mp3/chapter/ch02.html), which resulted
in 1000 lseek(2)s file for each mp3 frame.

Attached is the patch which fixes this ugly behavior.

-- 
JID: [EMAIL PROTECTED]
--- gtkpod-0.99.4.orig/src/mp3file.c
+++ gtkpod-0.99.4/src/mp3file.c
@@ -204,7 +204,7 @@
 
 
 static gint mp3file_header_bitrate(MP3Header *h) {
-return bitrate[h-version  1][3-h-layer][h-bitrate];
+return bitrate[h-version  1][3-h-layer][h-bitrate] * 1000;
 }
 
 

Bug#391810: gtkpod: Deadly slow operation on NFS-mounted volumes

[Mikhail Gusarov]

Package: gtkpod
Version: 0.99.4-1
Severity: normal

gtkpod does mad things when adds files to the database. Excerpt from strace:


_llseek(10, 17629184, [17629184], SEEK_SET) = 0

50 times more _llseek with SAME arguments

_llseek(10, 17629184, [17629184], SEEK_SET) = 0
read(10, [EMAIL PROTECTED]..., 32768) = 32768
_llseek(10, 17661952, [17661952], SEEK_SET) = 0

50 times more _llseek with same arguments

_llseek(10, 17661952, [17661952], SEEK_SET) = 0
read(10, \274\326!l\276\315bT\226FR\20\17+d/\31\20\377\372\202\304..., 32768) 
= 32768


etc for every 32 kbytes of file. This is slow even on local file, and
deadly slow for NFS-mounted volumes.

-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (800, 'testing'), (700, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/dash
Kernel: Linux 2.6.17-2-686
Locale: LANG=C, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8)

Versions of packages gtkpod depends on:
ii  libatk1.0-01.12.2-1  The ATK accessibility toolkit
ii  libc6  2.3.6.ds1-4   GNU C Library: Shared libraries
ii  libcairo2  1.2.4-1   The Cairo 2D vector graphics libra
ii  libfontconfig1 2.4.1-2   generic font configuration library
ii  libglade2-01:2.6.0-2.1   library to load .glade files at ru
ii  libglib2.0-0   2.12.3-2  The GLib library of C routines
ii  libgpod0   0.3.2-1.1 a library to read and write songs 
ii  libgtk2.0-02.8.20-1  The GTK+ graphical user interface 
ii  libid3tag0 0.15.1b-8 ID3 tag reading library from the M
ii  libpango1.0-0  1.14.4-2  Layout and rendering of internatio
ii  libx11-6   2:1.0.0-9 X11 client-side library
ii  libxcursor11.1.7-4   X cursor management library
ii  libxext6   1:1.0.1-2 X11 miscellaneous extension librar
ii  libxi6 1:1.0.1-3 X11 Input extension library
ii  libxinerama1   1:1.0.1-4.1   X11 Xinerama extension library
ii  libxml22.6.26.dfsg-3 GNOME XML library
ii  libxrandr2 2:1.1.0.2-4   X11 RandR extension library
ii  libxrender11:0.9.1-3 X Rendering Extension client libra
ii  zlib1g 1:1.2.3-13compression library - runtime

gtkpod recommends no packages.

-- no debconf information


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]