Bug#396778: mpdscribble: "Plugin bug" triggered by bulk submissions
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Kuno Woudt wrote: > On Thu, Nov 02, 2006 at 08:44:17PM +, Darac Marjal wrote: >> When attempting to submit a large number of songs, the submission may be >> rejected with the comment "Plugin bug: Not all request variables are set - >> got 2 parameters." > > This sounds like the submit data was truncated, I'm not sure what > last.fm does if that happens -- but I assume data could be lost, so > I do not think throttling is a solution. > > I just looked it up in http://www.audioscrobbler.net/wiki/Protocol1.1 , > which says "If you try to submit more than 10 tracks at once, some of > them may not be accepted.". So, I expect changing the MAX_SUBMIT_COUNT > to 10 should solve the problem. > > I'll try to have a closer look this weekend. > > -- Kuno. > It appears that, if the submission is rejected, the tracks remain in the cache (so the cache will grow without end), so data's not actually lost. But thanks for taking a look anyway. - -- Paul Saunders | PGP: 0xCC9A6F67 | http://www.darac.org.uk aka Darac Marjal | ICQ:4161505 |[EMAIL PROTECTED] - You're already carrying the sphere! -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iQIVAwUBRUs/2qB7YbRsd8TGAQr1NxAAkrA6MxFwijA74towMYjlRSOy+srwVQPF f9V1/Ea3DxDNFJ0X2+K9BtNrJJN/gIn+Cnw+HImZ+WZ1Jjg8vPHr9rkYWBIGPyMt GUrFRE+GIzMpkVYyqQ5iNhaZytnFOGsaHZEH4mfk09s63KkS9Ysjfyih0RMrRUjh sGKyfnaOwbvRzsaDhPB/ChPd3EAQe1/IJ7pC606pwTXjg+Y/tFUynxZFbgNVPfes anXE3RsdiFkIojAtgQn5rW26g85XmWYrC5pq0+0VQ3dhFIq4JEpclClryW1hwUo7 /2eNmj6gSNk9TltWx9W59LHojWZFLYW/P3Zsfo3dbcP6XT2Xlt1F309XVHpFJCra XkNhifPQTCjvk5JeiEKQcK09sBdzjpOjkluFLAIZGn7N0YqW58g1LGVTnZv3V1Jd dvQVifNoN+FngX+atl767nlWIpRQv1Zs1HGr/QsX+uvTy8SM6iYY1igcxnzkMh02 B9dIbvAhaZK433Gm/xrztGVzuW+qAMheYuH+Qm8x5on/sCamysyPpKOuhFDxPWtn ZXtcqlM+w6LQnewRZb9jwLTZGGU1Xeo2/UVdw3wSzySO32Gr0tjLszLnGBttv4U/ xY+8ATBY2mkh9g35YLx+2p0fqreuAxqbdh+7sONISEW5QQlye0m2zOK3wOxtIAwV zLXIF/40qBM= =qjz/ -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#396778: mpdscribble: "Plugin bug" triggered by bulk submissions
On Thu, Nov 02, 2006 at 08:44:17PM +, Darac Marjal wrote: > When attempting to submit a large number of songs, the submission may be > rejected with the comment "Plugin bug: Not all request variables are set - > got 2 parameters." This sounds like the submit data was truncated, I'm not sure what last.fm does if that happens -- but I assume data could be lost, so I do not think throttling is a solution. I just looked it up in http://www.audioscrobbler.net/wiki/Protocol1.1 , which says "If you try to submit more than 10 tracks at once, some of them may not be accepted.". So, I expect changing the MAX_SUBMIT_COUNT to 10 should solve the problem. I'll try to have a closer look this weekend. -- Kuno. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#396778: mpdscribble: "Plugin bug" triggered by bulk submissions
Package: mpdscribble
Version: 0.2.10-1
Severity: important
Tags: patch
When attempting to submit a large number of songs, the submission may be
rejected with the comment "Plugin bug: Not all request variables are set - got
2 parameters."
The attached patch will slowly reduce then number of submitted songs
until a level is reached where audioscrobbler accepts the submission.
-- System Information:
Debian Release: 4.0
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.17
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Versions of packages mpdscribble depends on:
ii adduser3.99 Add and remove users and groups
ii debconf [debconf-2.0] 1.5.8 Debian configuration management sy
ii libc6 2.3.6.ds1-7 GNU C Library: Shared libraries
ii libglib2.0-0 2.12.4-1 The GLib library of C routines
ii libgnutls131.4.4-2 the GNU TLS library - runtime libr
ii libsoup2.2-8 2.2.96-1 an HTTP library implementation in
ii libxml22.6.27.dfsg-1 GNOME XML library
ii logrotate 3.7.1-3 Log rotation utility
ii lsb-base 3.1-18Linux Standard Base 3.1 init scrip
mpdscribble recommends no packages.
-- debconf information:
* mpdscribble/user: darac
* mpdscribble/systemwide: true
--- mpdscribble-0.2.10/as.c 2006-05-28 12:22:18.0 +0100
+++ mpdscribble-0.2.10.new/as.c 2006-11-02 20:01:06.926305300 +
@@ -41,7 +41,7 @@
#define AS_HOST "http://post.audioscrobbler.com/";
/* don't submit more than this amount of songs in a batch. */
-#define MAX_SUBMIT_COUNT 50
+int MAX_SUBMIT_COUNT = 50;
typedef enum
{
@@ -238,6 +238,11 @@
char *start = line + strlen (FAILED);
if (*start)
warning ("submission rejected: %s", start);
+ if (strncmp(line, "Plugin bug", 10) && MAX_SUBMIT_COUNT >= 2)
+ {
+ MAX_SUBMIT_COUNT--;
+ notice("reducing bulk submission to %d items", MAX_SUBMIT_COUNT);
+ }
else
warning ("submission rejected");
}
