Bug#399970: successfull use of asterisk + misdn
Simon Richter escribió:
Hi,
Victor Seva wrote:
now I have a version [0] that builds over 2.6.23-1. I've made changes
from your
1.1.6-1 version diff attached.
I have explicitly avoided adding the mISDN init system to the debian
package, as it is bedly designed and if packaged according to Debian
policy, will have to be supported for a very long time (this is the main
thing I want to see fixed before I think mISDN is ready for a stable
release: you can get the kernel to crash by loading modules in the wrong
order, and requiring an XML based init system to work around that is not
a solution.
I'm not an expert and I have no opinion about this matter.
There are a few spots I disagree with (replacing ${source:Version} with
${Source-Version} for example), and I'm not sure explicitly passing
EXTRA_CFLAGS and the CONFIG_* variables on the command line instead of
in the environment does much to keep the logs readable. I'm going to
steal the 2.6.23 patch (the SVN version of the package already uses
dpatch, yay), but I disagree with the device ownership hack (you cannot
do anything with just read permissions anyway, so revoking the o+r
doesn't do anything, and I do not believe that the dialout group
should have low-level ISDN access).
I didn't know that misdn-kernel is now on pkg-voip's svn. Now I used quilt
instead dpatch.
Testing the upstream's patch with passing the variables in the environment
didn't built the module package but using CONFIGS variable on the command line
just builds fine.
Patch from svn attached.
Thanks
--
-
| ,''`. Victor Seva |
| : :' : [EMAIL PROTECTED] |
| `. `' PGP Key ID: 0xDD12F253 |
|`-Debian user, admin and contributor |
-
diff -ruN --exclude=.svn ../trunk-debian/debian/changelog misdn-kernel-1.1.7/debian/changelog
--- ../trunk-debian/debian/changelog 2008-01-15 10:23:32.0 +
+++ misdn-kernel-1.1.7/debian/changelog 2008-01-15 11:09:09.0 +
@@ -1,3 +1,12 @@
+misdn-kernel (1.1.7-2.1) UNRELEASED; urgency=low
+
+ * Non-maintainer upload.
+ * add patch from upstream to build with kernel = 2.6.23
+ * add variable CONFIGS and MISDNVERSION variables from Makefile's upstream.
+Adding EXTRA_CFLAGS using CONFIGS varialble.
+
+ -- Victor Seva [EMAIL PROTECTED] Tue, 15 Jan 2008 11:06:39 +
+
misdn-kernel (1.1.7-2) UNRELEASED; urgency=low
* debian/rules:
diff -ruN --exclude=.svn ../trunk-debian/debian/patches/2_6_23_fix misdn-kernel-1.1.7/debian/patches/2_6_23_fix
--- ../trunk-debian/debian/patches/2_6_23_fix 1970-01-01 00:00:00.0 +
+++ misdn-kernel-1.1.7/debian/patches/2_6_23_fix 2008-01-15 10:41:21.0 +
@@ -0,0 +1,74 @@
+Index: misdn-kernel-1.1.7/drivers/isdn/hardware/mISDN/capi.c
+===
+--- misdn-kernel-1.1.7.orig/drivers/isdn/hardware/mISDN/capi.c 2008-01-15 10:39:36.0 +
misdn-kernel-1.1.7/drivers/isdn/hardware/mISDN/capi.c 2008-01-15 10:40:42.0 +
+@@ -258,7 +258,11 @@
+ #else
+ sizeof(_cmsg),
+ #endif
+-0, 0, NULL, NULL);
++0, 0, NULL
++#ifdef MISDN_COMPAT_KMEMCACHE
++, NULL
++#endif
++);
+ if (!mISDN_cmsg_cp) {
+ CapiCachesFree();
+ return(-ENOMEM);
+@@ -269,7 +273,12 @@
+ #else
+ sizeof(AppPlci_t),
+ #endif
+-0, 0, NULL, NULL);
++0, 0, NULL
++#ifdef MISDN_COMPAT_KMEMCACHE
++, NULL
++#endif
++);
++
+ if (!mISDN_AppPlci_cp) {
+ CapiCachesFree();
+ return(-ENOMEM);
+@@ -280,7 +289,11 @@
+ #else
+ sizeof(Ncci_t),
+ #endif
+-0, 0, NULL, NULL);
++0, 0, NULL
++#ifdef MISDN_COMPAT_KMEMCACHE
++, NULL
++#endif
++);
+ if (!mISDN_ncci_cp) {
+ CapiCachesFree();
+ return(-ENOMEM);
+@@ -291,7 +304,12 @@
+ #else
+ sizeof(SSProcess_t),
+ #endif
+-0, 0, NULL, NULL);
++0, 0, NULL
++#ifdef MISDN_COMPAT_KMEMCACHE
++, NULL
++#endif
++);
++
+ if (!mISDN_sspc_cp) {
+ CapiCachesFree();
+ return(-ENOMEM);
+Index: misdn-kernel-1.1.7/drivers/isdn/hardware/mISDN/udevice.c
+===
+--- misdn-kernel-1.1.7.orig/drivers/isdn/hardware/mISDN/udevice.c 2008-01-15 10:39:50.0 +
misdn-kernel-1.1.7/drivers/isdn/hardware/mISDN/udevice.c 2008-01-15 10:40:42.0 +
+@@ -2025,9 +2025,8 @@
+ if ((err = mISDN_unregister(udev_obj))) {
+ printk(KERN_ERR Can't unregister UserDevice(%d)\n, err);
+ }
+- if ((err = unregister_chrdev(mISDN_MAJOR, mISDN))) {
+- printk(KERN_WARNING mISDN: devices busy on remove\n);
+- }
++
++ unregister_chrdev(mISDN_MAJOR, mISDN);
+ #ifdef CONFIG_DEVFS_FS
+ devfs_remove(mISDN);
+ #endif
diff -ruN --exclude=.svn ../trunk-debian/debian/patches/series
Bug#399970: successfull use of asterisk + misdn
Hi,
Victor Seva wrote:
now I have a version [0] that builds over 2.6.23-1. I've made changes from your
1.1.6-1 version diff attached.
I have explicitly avoided adding the mISDN init system to the debian
package, as it is bedly designed and if packaged according to Debian
policy, will have to be supported for a very long time (this is the main
thing I want to see fixed before I think mISDN is ready for a stable
release: you can get the kernel to crash by loading modules in the wrong
order, and requiring an XML based init system to work around that is not
a solution.
There are a few spots I disagree with (replacing ${source:Version} with
${Source-Version} for example), and I'm not sure explicitly passing
EXTRA_CFLAGS and the CONFIG_* variables on the command line instead of
in the environment does much to keep the logs readable. I'm going to
steal the 2.6.23 patch (the SVN version of the package already uses
dpatch, yay), but I disagree with the device ownership hack (you cannot
do anything with just read permissions anyway, so revoking the o+r
doesn't do anything, and I do not believe that the dialout group
should have low-level ISDN access).
I've not tested the 2.6.23 modules. I have not a testing machine. Can you take a
look over this changes?
Not easily at the moment, because I have the main testing box used for
Windows driver testing at the moment.
Simon
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#399970: successfull use of asterisk + misdn
Hi, Victor Seva wrote: You should not create a dynamic library for the mISDN userspace. yes you are right. mISDN is not SONAME versioned. But I don't know how to package properly a library which is not versioned and this is my innocent way to use mISDN with asterisk. In my packages, I'm building a static library that has been compiled with -fPIC, and just accept that if there are ever multiple users of mISDN on the system, the code will be duplicated. Simon -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#399970: successfull use of asterisk + misdn
Simon Richter wrote:
I think he already did. Since I'm at work now, I cannot look at the
packages properly, do these already include fixes to compile with 2.6.23?
Hi Simon,
now I have a version [0] that builds over 2.6.23-1. I've made changes from your
1.1.6-1 version diff attached.
I've not tested the 2.6.23 modules. I have not a testing machine. Can you take a
look over this changes?
Thanks
[0] http://linuxmaniac.torreviejawireless.org/debian/misdn-kernel/1.1.7_simon/
--
-
| ,''`. Victor Seva |
| : :' : [EMAIL PROTECTED] |
| `. `' PGP Key ID: 0xDD12F253 |
|`-Debian user, admin and contributor |
-
diff -ruN --exclude=.svn simon/debian/changelog ../trunk/debian/changelog
--- simon/debian/changelog 2008-01-09 09:33:33.0 +0100
+++ ../trunk/debian/changelog 2008-01-09 18:00:48.0 +0100
@@ -1,6 +1,18 @@
-misdn-kernel (1.1.6-1) experimental; urgency=low
+misdn-kernel (1.1.7-1.1) experimental; urgency=low
+ * Non-maintainer upload.
* New upstream release
+ * added new misdn-config package
+ * added patch from upstream fixing build on 2.6.23
+ * added patch to use perms compatible with asterisk
+ * added CONFIGS variable to rules-template. Removed exports
+ * added MISDNVERSION variable to rules-template.
+
+ -- Victor Seva [EMAIL PROTECTED] Wed, 9 Jan 2008 18:00:44 +0100
+
+misdn-kernel (1.1.6-1) experimental; urgency=low
+
+ * New upstream release
* Add missing dependency misdn-source - debhelper
-- Simon Richter [EMAIL PROTECTED] Sun, 04 Nov 2007 02:03:05 +0100
diff -ruN --exclude=.svn simon/debian/control ../trunk/debian/control
--- simon/debian/control 2008-01-09 09:33:33.0 +0100
+++ ../trunk/debian/control 2008-01-09 18:07:44.0 +0100
@@ -2,15 +2,15 @@
Section: comm
Priority: extra
Maintainer: Simon Richter [EMAIL PROTECTED]
-Build-Depends: debhelper (= 5.0.0)
+Build-Depends: debhelper (= 5.0.0), dpatch
Standards-Version: 3.7.2
Package: misdn-source
Architecture: all
Depends: make, debhelper ( 4)
Recommends: module-assistant | kernel-package
-Conflicts: misdn-kernel-source ( ${source:Version})
-Replaces: misdn-kernel-source ( ${source:Version})
+Conflicts: misdn-kernel-source ( ${Source-Version})
+Replaces: misdn-kernel-source ( ${Source-Version})
Provides: misdn-kernel-source
Description: Source code for the mISDN modules
The modular ISDN drivers are the bleeding edge implementation of ISDN support
@@ -30,3 +30,13 @@
.
You need this package if you intend to compile userspace applications that
access mISDN specific interfaces.
+
+Package: misdn-config
+Architecture: all
+Depends: xsltproc
+Description: init-script to auto-configure and load the mISDN kernel drivers
+ This script makes it easy to configure and activate mISDN compatible
+ adapter cards. It scans an eyecandy config file named mISDN.conf
+ for your card and port settings, then it loads the driver modules properly.
+ The mISDN.conf can also be autogenerated by the mISDN script.
+
diff -ruN --exclude=.svn simon/debian/control-template ../trunk/debian/control-template
--- simon/debian/control-template 2008-01-09 09:33:33.0 +0100
+++ ../trunk/debian/control-template 2008-01-09 18:09:26.0 +0100
@@ -7,6 +7,7 @@
Package: misdn-modules-@@Kernel-Version@@
Architecture: any
Provides: misdn-modules
+Depends: bc, pciutils
Description: mISDN modules for Linux (kernel @@Kernel-Version@@)
The modular ISDN drivers are the bleeding edge implementation of ISDN support
in the Linux kernel. The most prominent new feature is support for ISDN cards
@@ -14,7 +15,7 @@
.
This package contains the compiled kernel modules for @@Kernel-Version@@
.
- If you have compiled your own kernel, you will most likely need to build your
- own mISDN modules. The misdn-source package has been provided for use with
- module-assistant or make-kpkg to produce a version of misdn-kernel-module for
- your kernel.
+ If you have compiled your own kernel, you will most likely need to build
+ your own misdn-kernel-modules. The misdn-kernel-source package has been
+ provided for use with the Debian kernel-package utility to produce a version
+ of misdn-kernel-module for your kernel.
diff -ruN --exclude=.svn simon/debian/linux-headers-misdn.install ../trunk/debian/linux-headers-misdn.install
--- simon/debian/linux-headers-misdn.install 2008-01-09 09:33:33.0 +0100
+++ ../trunk/debian/linux-headers-misdn.install 2007-12-18 12:15:06.0 +0100
@@ -1 +1 @@
-include/linux usr/include
+include/linux/*.h usr/include/linux
diff -ruN --exclude=.svn simon/debian/misdn-config.dirs ../trunk/debian/misdn-config.dirs
--- simon/debian/misdn-config.dirs 1970-01-01 01:00:00.0 +0100
+++ ../trunk/debian/misdn-config.dirs
Bug#399970: successfull use of asterisk + misdn
Tzafrir Cohen escribió: On Mon, Jan 07, 2008 at 07:28:12PM +0100, Victor Seva wrote: I'm using my own packages, based on your work, of misdn-kernel and misdn-user with asterisk. I don't know anything about libraries so ... But I'm building asterisk with no problems with thouse packages. I hope this could help someone. http://linuxmaniac.torreviejawireless.org/debian/misdn-kernel/ http://linuxmaniac.torreviejawireless.org/debian/misdn-user/ http://linuxmaniac.torreviejawireless.org/debian/asterisk/ Thanks. What changes are needed in the Asterisk package to properly support misdn? Any way to integrate them in the main package? I'm only adding my libmisdnuser-dev and libmisdnuser0 to Build-Depends. -- - | ,''`. Victor Seva | | : :' : [EMAIL PROTECTED] | | `. `' PGP Key ID: 0xDD12F253 | |`-Debian user, admin and contributor | - diff -ruN --exclude=.svn trunk-debian/debian/changelog trunk/debian/changelog --- trunk-debian/debian/changelog 2008-01-07 12:23:05.0 +0100 +++ trunk/debian/changelog 2008-01-07 12:35:01.0 +0100 @@ -1,3 +1,10 @@ +asterisk (1:1.4.17~dfsg-2.1) unstable; urgency=low + + * Non-maintainer upload. + * etch build + chan_misdn with zaptel 1.4.7.1 + + -- Victor Seva [EMAIL PROTECTED] Mon, 7 Jan 2008 12:34:38 +0100 + asterisk (1:1.4.17~dfsg-2) unstable; urgency=low * Allow building vs. libc-client2007 (Closes: #458877). diff -ruN --exclude=.svn trunk-debian/debian/control trunk/debian/control --- trunk-debian/debian/control 2008-01-07 12:23:05.0 +0100 +++ trunk/debian/control 2008-01-07 12:33:15.0 +0100 @@ -3,7 +3,7 @@ Section: comm Maintainer: Debian VoIP Team [EMAIL PROTECTED] Uploaders: Mark Purcell [EMAIL PROTECTED], Kilian Krause [EMAIL PROTECTED], Tzafrir Cohen [EMAIL PROTECTED], Faidon Liambotis [EMAIL PROTECTED] -Build-Depends: debhelper (= 5), quilt, zlib1g-dev, libreadline5-dev, libgsm1-dev, libssl-dev, libtonezone-dev (= 1:1.4.1~0), bison, libasound2-dev, libpq-dev, unixodbc-dev, libpri-dev (= 1.4.1-1), libvpb-dev, zaptel-source (= 1:1.4.1~0), autotools-dev, libnewt-dev, libsqlite-dev, libspeex-dev, graphviz, libcurl4-openssl-dev | libcurl-dev, doxygen, gsfonts, libpopt-dev, libopenh323-dev (= 1.17.4-1), libiksemel-dev, libradiusclient-ng-dev, freetds-dev, libvorbis-dev, libsnmp-dev, libc-client2007-dev | libc-client-dev, libcap-dev +Build-Depends: debhelper (= 5), quilt, zlib1g-dev, libreadline5-dev, libgsm1-dev, libssl-dev, libtonezone-dev (= 1:1.4.1~0), bison, libasound2-dev, libpq-dev, unixodbc-dev, libpri-dev (= 1.4.1-1), libvpb-dev, zaptel-source (= 1:1.4.1~0), autotools-dev, libnewt-dev, libsqlite-dev, libspeex-dev, graphviz, libcurl4-openssl-dev | libcurl-dev, doxygen, gsfonts, libpopt-dev, libopenh323-dev (= 1.17.4-1), libiksemel-dev, libradiusclient-ng-dev, freetds-dev, libvorbis-dev, libsnmp-dev, libc-client2007-dev | libc-client-dev, libcap-dev, libmisdnuser-dev, libmisdnuser0 Standards-Version: 3.7.3 Homepage: http://www.asterisk.org/ Vcs-Svn: svn://svn.debian.org/pkg-voip/asterisk/trunk/
Bug#399970: successfull use of asterisk + misdn
Victor Seva wrote: Thanks. What changes are needed in the Asterisk package to properly support misdn? Any way to integrate them in the main package? I'm only adding my libmisdnuser-dev and libmisdnuser0 to Build-Depends. This sounds interesting. Simon's opinion is that mISDN is immature for inclusion to Debian. Could you share your work of the packages please? Simon, care to join us? :) Regards, Faidon -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#399970: successfull use of asterisk + misdn
Hi, Faidon Liambotis wrote: I'm only adding my libmisdnuser-dev and libmisdnuser0 to Build-Depends. This sounds interesting. Simon's opinion is that mISDN is immature for inclusion to Debian. Indeed, and I stand by that. I have two systems (i386 and powerpc) where the kernel immediately crashes when mISDN_core is loaded. While I can sort of understand the crash on powerpc (shoddy programming leads to endianness problems), I think at least on i386 it should work. Could you share your work of the packages please? I think he already did. Since I'm at work now, I cannot look at the packages properly, do these already include fixes to compile with 2.6.23? Simon, care to join us? :) Sure, I'm here. :-) Simon -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#399970: successfull use of asterisk + misdn
Hi, Victor Seva wrote: I'm only adding my libmisdnuser-dev and libmisdnuser0 to Build-Depends. You should not create a dynamic library for the mISDN userspace. Simon -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#399970: successfull use of asterisk + misdn
Simon Richter escribió: Hi, Victor Seva wrote: I'm only adding my libmisdnuser-dev and libmisdnuser0 to Build-Depends. You should not create a dynamic library for the mISDN userspace. Simon Hi Simon, yes you are right. mISDN is not SONAME versioned. But I don't know how to package properly a library which is not versioned and this is my innocent way to use mISDN with asterisk. I'm sure you that your work is better but I needed a new version of mISDN in order to build chan_misdn and finally I can do it and use it without to much trouble. If my work or any help can be of use, I am more than happy to collaborate. -- - | ,''`. Victor Seva | | : :' : [EMAIL PROTECTED] | | `. `' PGP Key ID: 0xDD12F253 | |`-Debian user, admin and contributor | -
Bug#399970: successfull use of asterisk + misdn
Simon Richter escribió: I think he already did. Since I'm at work now, I cannot look at the packages properly, do these already include fixes to compile with 2.6.23? no. I'm now working on it. -- - | ,''`. Victor Seva | | : :' : [EMAIL PROTECTED] | | `. `' PGP Key ID: 0xDD12F253 | |`-Debian user, admin and contributor | -
Bug#399970: successfull use of asterisk + misdn
I'm using my own packages, based on your work, of misdn-kernel and misdn-user with asterisk. I don't know anything about libraries so ... But I'm building asterisk with no problems with thouse packages. I hope this could help someone. http://linuxmaniac.torreviejawireless.org/debian/misdn-kernel/ http://linuxmaniac.torreviejawireless.org/debian/misdn-user/ http://linuxmaniac.torreviejawireless.org/debian/asterisk/ -- - | ,''`. Victor Seva | | : :' : [EMAIL PROTECTED] | | `. `' PGP Key ID: 0xDD12F253 | |`-Debian user, admin and contributor | - -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#399970: successfull use of asterisk + misdn
On Mon, Jan 07, 2008 at 07:28:12PM +0100, Victor Seva wrote: I'm using my own packages, based on your work, of misdn-kernel and misdn-user with asterisk. I don't know anything about libraries so ... But I'm building asterisk with no problems with thouse packages. I hope this could help someone. http://linuxmaniac.torreviejawireless.org/debian/misdn-kernel/ http://linuxmaniac.torreviejawireless.org/debian/misdn-user/ http://linuxmaniac.torreviejawireless.org/debian/asterisk/ Thanks. What changes are needed in the Asterisk package to properly support misdn? Any way to integrate them in the main package? -- Tzafrir Cohen icq#16849755 jabber:[EMAIL PROTECTED] +972-50-7952406 mailto:[EMAIL PROTECTED] http://www.xorcom.com iax:[EMAIL PROTECTED]/tzafrir -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
