Bug#401672: thunar: FTBFS on hurd-i386: PATH_MAX issue
* Michael Banck <[EMAIL PROTECTED]>, [2006-12-05 11:41 +0100]: > thunar-vfs-io-local.c:840: error: 'PATH_MAX' undeclared (first use in this > function) > thunar-vfs-io-local.c:840: error: (Each undeclared identifier is reported > only once > thunar-vfs-io-local.c:840: error: for each function it appears in.) > thunar-vfs-io-local.c:840: warning: unused variable 'src_path' > make[4]: *** [libthunar_vfs_1_la-thunar-vfs-io-local.lo] Error 1 > make[4]: Leaving directory `/build/buildd/thunar-0.4.0rc1/thunar-vfs' > > PATH_MAX is not defined on GNU/Hurd, as no limit exists. Thunar uses > THUNAR_VFS_PATH_MAXSTRLEN in all other similar situation AFAICT, so just > using it here (it gets defined to PATH_MAX on systems which have it > anyway) seems like a straight-forward fix to me, patch attached. Michael, could you please check if the version of thunar currently in sid fixes this issue? Thanks. ciao, ema -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#401672: thunar: FTBFS on hurd-i386: PATH_MAX issue
Package: thunar Version: 0.4.0rc1-2 Severity: important Tags: patch Hi, thunar fails to build on hurd-i386: Automatic build of thunar_0.4.0rc1-2 on beethoven by sbuild/hurd-i386 85 Build started at 20061204-2007 ** [...] Checking correctness of source dependencies... Toolchain package versions: libc0.3-dev_2.3.6.ds1-5 gcc-4.1_4.1.1-20 g++-4.1_4.1.1-20 binutils_2.17-3 libstdc++6-4.1-dev_4.1.1-20 libstdc++6_4.1.1-20 Start building -- gpg: Signature made Fri Sep 29 14:33:09 2006 CEST using DSA key ID DF5CE2B4 gpg: Can't check signature: public key not found dpkg-source: extracting thunar in thunar-0.4.0rc1 dpkg-source: unpacking thunar_0.4.0rc1.orig.tar.gz dpkg-source: applying /org/buildd/build/thunar_0.4.0rc1-2.diff.gz dpkg-buildpackage: source package is thunar dpkg-buildpackage: source version is 0.4.0rc1-2 dpkg-buildpackage: host architecture hurd-i386 dpkg-buildpackage: source version without epoch 0.4.0rc1-2 [...] debian/rules build [...] cc -DHAVE_CONFIG_H -I. -I. -I.. -I.. -DEXO_API_SUBJECT_TO_CHANGE -DEXO_DISABLE_DEPRECATED -DG_LOG_DOMAIN=\"thunar-vfs\" -DLIBEXECDIR=\"/usr/lib/thunar\" -DSN_API_NOT_YET_FROZEN -DTHUNAR_VFS_COMPILATION -DTHUNAR_VFS_VERSION_API=\"1\" -NDEBUG -DG_DISABLE_CAST_CHECKS -DHAVE_GNUC_VISIBILITY -I/usr/include/exo-0.3 -I/usr/include/gtk-2.0 -I/usr/include/xfce4 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/libpng12 -D_REENTRANT -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/fam -I/usr/include/libpng12 -I/usr/include/startup-notification-1.0 -g -Wall -O2 -c thunar-vfs-io-local.c -fPIC -DPIC -o .libs/libthunar_vfs_1_la-thunar-vfs-io-local.o cc: unrecognized option '-NDEBUG' thunar-vfs-io-local.c: In function '_thunar_vfs_io_local_rename': thunar-vfs-io-local.c:840: error: 'PATH_MAX' undeclared (first use in this function) thunar-vfs-io-local.c:840: error: (Each undeclared identifier is reported only once thunar-vfs-io-local.c:840: error: for each function it appears in.) thunar-vfs-io-local.c:840: warning: unused variable 'src_path' make[4]: *** [libthunar_vfs_1_la-thunar-vfs-io-local.lo] Error 1 make[4]: Leaving directory `/build/buildd/thunar-0.4.0rc1/thunar-vfs' PATH_MAX is not defined on GNU/Hurd, as no limit exists. Thunar uses THUNAR_VFS_PATH_MAXSTRLEN in all other similar situation AFAICT, so just using it here (it gets defined to PATH_MAX on systems which have it anyway) seems like a straight-forward fix to me, patch attached. cheers, Michael --- thunar-0.4.0rc1/thunar-vfs/thunar-vfs-io-local.c.orig 2006-12-04 20:32:29.0 +0100 +++ thunar-0.4.0rc1/thunar-vfs/thunar-vfs-io-local.c2006-12-04 20:32:48.0 +0100 @@ -837,7 +837,7 @@ gsizedata_length; gchar *data; gchar *key; - gcharsrc_path[PATH_MAX + 1]; + gcharsrc_path[THUNAR_VFS_PATH_MAXSTRLEN]; gchar *dir_name; gchar *dst_name; gchar *dst_path;
Bug#401672: [Pkg-xfce-devel] Bug#401672: thunar: FTBFS on hurd-i386: PATH_MAX issue
On mar, 2006-12-05 at 11:41 +0100, Michael Banck wrote: > Package: thunar > Version: 0.4.0rc1-2 > Severity: important > Tags: patch > > PATH_MAX is not defined on GNU/Hurd, as no limit exists. Thunar uses > THUNAR_VFS_PATH_MAXSTRLEN in all other similar situation AFAICT, so just > using it here (it gets defined to PATH_MAX on systems which have it > anyway) seems like a straight-forward fix to me, patch attached. Thank you for your report. It seems that upstream has came to the same conclusion, as your patch is already applied upstream. Well, at least they have replaced PATH_MAX by THUNAR_VFS_PATH_MAXSTRLEN. This version (0.5) will be uploaded soon, so I don't think it's worth uploading a patched version of 0.4. Thanks anyway -- Yves-Alexis -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
