Bug#402328: #402328 - check --config file for existance

[Steve Kemp]

  The code already reads the file only if it exists:

   readConfigurationFile( $path ) if ( -e $path );

  That is the same as:

if ( -e $path ) { readConfigurationFile( $path ); }

  I think that aborting if the file doesn't exist is too strong
 a reaction.. so I'm inclined to ignore it!

Steve
-- 


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#402328: #402328 - check --config file for existance

[Henning Sprang]

Steve Kemp wrote:
 [...]
   I think that aborting if the file doesn't exist is too strong
  a reaction..

There is technically no use to give a non-existing config file - that is
clear because it's just ignored, if it doesn't exist - no action is taken.

So, if a user gives --config with an unexisting file it is therefore
very likely a typo, which the user wants to be warned as fast as
possible. In this case, there's no use to run the install until the end
with an unwanted configuration - the user wants to run again, with the
right config file.

If not error is given, and not stopped, it takes a long while to find
out that the wrong configuration is installed.

Henning


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#402328: #402328 - check --config file for existance

[Steve Kemp]

On Sat, Dec 09, 2006 at 06:17:40PM +0100, Henning Sprang wrote:

 So, if a user gives --config with an unexisting file it is therefore
 very likely a typo, which the user wants to be warned as fast as
 possible. In this case, there's no use to run the install until the end
 with an unwanted configuration - the user wants to run again, with the
 right config file.

  OK you've persuaded me.  Patch applied.

Steve
-- 


signature.asc
Description: Digital signature