Bug#402725: rss2email: r2e run does not check for errors on mail submission

2006-12-12 Thread Hilko Bengen
Package: rss2email
Version: 1:2.60-1.1
Severity: grave

r2e run does not mind when the MTA does not accept messages. It
happily marks articles as processed, even when it got a non-zero
return from sendmail or a 4xx or 5xx from the SMTP connection.

I'll try to come up with a patch for this issue.

Cheers,
-Hilko

-- System Information:
Debian Release: 4.0
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-1-686
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages rss2email depends on:
ii  python2.4.4-1An interactive high-level object-o
ii  python-feedparser 4.1-6  Universal Feed Parser for Python
ii  python-support0.5.6  automated rebuilding support for p

rss2email recommends no packages.

-- no debconf information


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#402725: rss2email: r2e run does not check for errors on mail submission

2006-12-12 Thread Joey Hess
Hilko Bengen wrote:
 r2e run does not mind when the MTA does not accept messages. It
 happily marks articles as processed, even when it got a non-zero
 return from sendmail or a 4xx or 5xx from the SMTP connection.

Actually, if no mail is sent over the SMTP connection, smtplib.sendmail
should raise an SMTPRecipientsRefused exception. This exception is
trapped and rss2email exits with an error message.

In the case of sendmail failing to run, it seems to indeed ignore
nonzero exit status.

 I'll try to come up with a patch for this issue.

There's definitly room for improvement and I would appreciate a patch.


I don't feel that this bug actually qualifies as grave severity. The
potential for actual data loss depends on obscure situations where the
data in the rss feed/blog vanishes after rss2email consumes it. Relying
on an email system as the only way to retreive data is a bad assumption
to make today; you'll lose data anyway even if rss2email doesn't fail,
due to bogus spam traps, etc.

-- 
see shy jo


signature.asc
Description: Digital signature


Bug#402725: rss2email: r2e run does not check for errors on mail submission

2006-12-12 Thread Hilko Bengen
Joey Hess [EMAIL PROTECTED] writes:

 Actually, if no mail is sent over the SMTP connection,
 smtplib.sendmail should raise an SMTPRecipientsRefused exception.
 This exception is trapped and rss2email exits with an error message.

I'll need to check that. (I only experienced the bug with the sendmail
interface).

 I don't feel that this bug actually qualifies as grave severity. The
 potential for actual data loss depends on obscure situations where
 the data in the rss feed/blog vanishes after rss2email consumes it.

My issue is not so much about mails getting lost here, but rather
about the combination of 

(a) the state file being worthless WRT what messages need to be
fetched without the user noticing
and
(b) the state file not easily being read and modified with a text
editor.

 Relying on an email system as the only way to retreive data is a bad
 assumption to make today; you'll lose data anyway even if rss2email
 doesn't fail, due to bogus spam traps, etc.

I still maintain that mail (and state) loss due to a simple return
code not being checked is entirely rss2email's fault.

If fetchmail or a tool with similar goals behaved like this where it
could be avoided, there would be little doubt that this is
unacceptable and needs to be fixed.

Cheers,
-Hilko


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]