Bug#410300: [Alpine-alpha] Debian Bug#410300: alpine: addressbook sort-order cannot be changed

2007-03-07 Thread Asheesh Laroia

On Sun, 11 Feb 2007, Asheesh Laroia wrote:

A Debian user reported this problem with Alpine 0.81 and that it persists 
in Alpine 0.82:


The line addrbook-sort-rule=nickname in .pinerc hass no effect. The 
addressbook will still sorted by the default fullname-with-lists-last.


I can report that this bug persists in Alpine 0.83.  I'm CC:ing the Debian 
bug, which can be viewed on the web at 
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=410300 .


It's particulary confusing because it looks like reasonable logic is in 
place around line 2348-2352 of pith/adrbklib.c.


I don't mean to be a whiner, even though I've posted a couple of bugs 
lately; rather, thanks for all the great work that's being put into 
Alpine!


-- Asheesh.

--
Once is happenstance,
Twice is coincidence,
Three times is enemy action.
-- Auric Goldfinger


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#410300: [Alpine-alpha] Debian Bug#410300: alpine: addressbook sort-order cannot be changed

2007-03-07 Thread Steve Hubert

On Wed, 7 Mar 2007, Asheesh Laroia wrote:


On Sun, 11 Feb 2007, Asheesh Laroia wrote:

A Debian user reported this problem with Alpine 0.81 and that it persists 
in Alpine 0.82:


The line addrbook-sort-rule=nickname in .pinerc hass no effect. The 
addressbook will still sorted by the default fullname-with-lists-last.


I can report that this bug persists in Alpine 0.83.  I'm CC:ing the Debian 
bug, which can be viewed on the web at 
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=410300 .


It's particulary confusing because it looks like reasonable logic is in place 
around line 2348-2352 of pith/adrbklib.c.


I don't mean to be a whiner, even though I've posted a couple of bugs lately; 
rather, thanks for all the great work that's being put into Alpine!


-- Asheesh.


Thanks for your persistence. Here's a patch.

Steve

Index: pith/adrbklib.c
===
--- pith/adrbklib.c (revision 473)
+++ pith/adrbklib.c (working copy)
@@ -382,6 +382,10 @@
 if(!ab-fp)
   goto bail_out;

+ab-sort_rule = sort_rule;
+if(pab-access == ReadOnly)
+  ab-sort_rule = AB_SORT_RULE_NONE;
+
 if(ab){
/* allocate header for expanded lists list */
ab-exp  = (EXPANDED_S *)fs_get(sizeof(EXPANDED_S));


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]