Bug#410392: interactive/preseed=true doesn't work as expected

2007-02-10 Thread Joey Hess
Robert Millan wrote:
> On Sat, Feb 10, 2007 at 09:40:28PM +0100, Robert Millan wrote:
> > 
> > How about a prefix to mark individual variables as interactive ?  E.g.
> > "_hostname=xxx".
> 
> Or maybe a shortcut to "seen" would be more consistent:
> 
>   hostname/seen=false

Won't work, since order isn't preserved. The _hostname could work, on
irc we came up with the idea of var?=value to do the same thing. Some
sort of syntactic sugar of this sort seems unavoidable, unfortnatly
(unless we want to parse /proc/cmsline by hand).

-- 
see shy jo


signature.asc
Description: Digital signature


Bug#410392: interactive/preseed=true doesn't work as expected

2007-02-10 Thread Robert Millan
On Sat, Feb 10, 2007 at 09:40:28PM +0100, Robert Millan wrote:
> 
> How about a prefix to mark individual variables as interactive ?  E.g.
> "_hostname=xxx".

Or maybe a shortcut to "seen" would be more consistent:

  hostname/seen=false

-- 
Robert Millan

My spam trap is [EMAIL PROTECTED]  Note: this address is only intended
for spam harvesters.  Writing to it will get you added to my black list.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Bug#410392: interactive/preseed=true doesn't work as expected

2007-02-10 Thread Robert Millan
On Sat, Feb 10, 2007 at 02:59:07PM -0500, Joey Hess wrote:
> > 16:15 < nyu> no, that wasn't enough..
> > 16:16 < nyu> I observed that the order of my parameters (locale=xx 
> > interactive/preseed=true hostname=xx) is altered in /var/lib/preseed/log
> > 16:16 < nyu> where the order is hostname, locale, then interactive/preseed
> > 16:16 < nyu> could that be related?
> 
> Yes, I had not realised that this is parsing the output of set, so
> there's no guaranteed order, and preseeding it on and then off won't
> work. The best I can do is check for interactive/preseed first and have
> it apply to everything on the command line if set. I may need to
> reconsider and use a different syntax.

How about a prefix to mark individual variables as interactive ?  E.g.
"_hostname=xxx".

-- 
Robert Millan

My spam trap is [EMAIL PROTECTED]  Note: this address is only intended
for spam harvesters.  Writing to it will get you added to my black list.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Bug#410392: interactive/preseed=true doesn't work as expected

2007-02-10 Thread Frans Pop
On Saturday 10 February 2007 12:46, Robert Millan wrote:
> 16:00 < nyu> joeyh: your last change to interactive/preseed isn't
> working.  I believe it's due to the line in env2debconf that reads 'if
> [ "$SEEN" ]; then' instead of 'if [ "$SEEN" = 1 ]; then'.  I haven't
> tried, though, but that line is clearly wrong ('[' makes no distinction
> between "0" and "1")

Fixed in SVN.

> 16:15 < nyu> no, that wasn't enough.. 
> 16:16 < nyu> I observed that the order of my parameters (locale=xx
> interactive/preseed=true hostname=xx) is altered in
> /var/lib/preseed/log
> 16:16 < nyu> where the order is hostname, locale, then
> interactive/preseed 
> 16:16 < nyu> could that be related? 

Yes, that could well be. env2debconf parses the output of 'set' and AFAIK 
that will list environment variables in alphabetical order, not the order 
in which they were set.


pgpMwr6sG8bLi.pgp
Description: PGP signature


Bug#410392: interactive/preseed=true doesn't work as expected

2007-02-10 Thread Joey Hess
Robert Millan wrote:
> 16:00 < nyu> joeyh: your last change to interactive/preseed isn't working.  I 
> believe it's due to the line in env2debconf that reads 'if [ "$SEEN" ]; then'
>  instead of 'if [ "$SEEN" = 1 ]; then'.  I haven't tried, though, 
> but that line is clearly wrong ('[' makes no distinction between "0" and "1")

Fixed.

> 16:15 < nyu> no, that wasn't enough..
> 16:16 < nyu> I observed that the order of my parameters (locale=xx 
> interactive/preseed=true hostname=xx) is altered in /var/lib/preseed/log
> 16:16 < nyu> where the order is hostname, locale, then interactive/preseed
> 16:16 < nyu> could that be related?

Yes, I had not realised that this is parsing the output of set, so
there's no guaranteed order, and preseeding it on and then off won't
work. The best I can do is check for interactive/preseed first and have
it apply to everything on the command line if set. I may need to
reconsider and use a different syntax.

-- 
see shy jo


signature.asc
Description: Digital signature


Bug#410392: interactive/preseed=true doesn't work as expected

2007-02-10 Thread Robert Millan
Package: preseed
Severity: normal

Writing it down in a bug report so that it isn't forgotten.

16:00 < nyu> joeyh: your last change to interactive/preseed isn't working.  I 
believe it's due to the line in env2debconf that reads 'if [ "$SEEN" ]; then'
 instead of 'if [ "$SEEN" = 1 ]; then'.  I haven't tried, though, 
but that line is clearly wrong ('[' makes no distinction between "0" and "1")
16:15 < nyu> no, that wasn't enough..
16:16 < nyu> I observed that the order of my parameters (locale=xx 
interactive/preseed=true hostname=xx) is altered in /var/lib/preseed/log
16:16 < nyu> where the order is hostname, locale, then interactive/preseed
16:16 < nyu> could that be related?

-- System Information:
Debian Release: 4.0
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-3-amd64
Locale: LANG=ca_AD.UTF-8, LC_CTYPE=ca_AD.UTF-8 (charmap=UTF-8)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]