Bug#417861: Did not set wishlist severity

2007-04-17 Thread Don Armstrong
On Tue, 17 Apr 2007, Bastian Venthur wrote:
> I think it should be more robust against such cases. If there is a
> stop/quit/--/ etc line in the mail, it could try to process as much
> of the found pseudoheaders above this line as possible. This
> shouldn't be hard to implement and wouldn't hurt either.

The pseudoheader processing processes psuedoheaders until it
encounters an invalid one, then it stops. It probably should be
slightly more forgiving, but it can't be too forgiving or it'll end up
trying to parse the rest of the message with hard-to-interpret
results.

I'll think about ignoring blank pseudoheaders and probably end up
implementing it.


Don Armstrong
 
-- 
Never underestimate the power of human stupidity. 
 -- Robert Heinlein

http://www.donarmstrong.com  http://rzlab.ucr.edu


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Bug#417861: Did not set wishlist severity

2007-04-16 Thread Bastian Venthur
Anthony Towns schrieb:
> On Thu, Apr 05, 2007 at 04:45:27PM +0200, Bastian Venthur wrote:
>> Am 05.04.2007 03:51 schrieb Charles Plessy:
>>> I used reportbug-ng to send a wishlist bug, but it appears with the
>>> Normal ones.
>>> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=417581
>> Hmm, I see what you mean, the BTS seems to think this bug is normal. I
>> doubt this is a bug of reportbug-ng I think it should be a bug for
>> debbugs, since it ignored the severity in this case.
> 
> Pseudoheaders are required to have some contents, so when debbugs saw
> "Version:" without an actual version, it stopped looking at them. That's
> a reportbug-ng bug, and the ultimate cause of this. I've no idea if we
> want to change debbugs to deal more nicely with empty pseudo-headers, but
> reportbug-ng definitely shouldn't be generating them.

RNG doesn't generate empty pseudo headers anymore. But the problem was
not debbugs ignoring the empty Version:-line (which would be fine), but
the whole rest after this line including the severity.

I think it should be more robust against such cases. If there is a
stop/quit/--/ etc line in the mail, it could try to process as much of
the found pseudoheaders above this line as possible. This shouldn't be
hard to implement and wouldn't hurt either.

But anyway, this bug is fixed on my side, so do whatever you want with
this hint :)


Cheers,

Bastian

-- 
Bastian Venthur  http://venthur.de
Debian Developer venthur at debian org



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Bug#417861: Did not set wishlist severity

2007-04-16 Thread Anthony Towns
On Thu, Apr 05, 2007 at 04:45:27PM +0200, Bastian Venthur wrote:
> Am 05.04.2007 03:51 schrieb Charles Plessy:
> > I used reportbug-ng to send a wishlist bug, but it appears with the
> > Normal ones.
> > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=417581
> Hmm, I see what you mean, the BTS seems to think this bug is normal. I
> doubt this is a bug of reportbug-ng I think it should be a bug for
> debbugs, since it ignored the severity in this case.

Pseudoheaders are required to have some contents, so when debbugs saw
"Version:" without an actual version, it stopped looking at them. That's
a reportbug-ng bug, and the ultimate cause of this. I've no idea if we
want to change debbugs to deal more nicely with empty pseudo-headers, but
reportbug-ng definitely shouldn't be generating them.

Cheers,
aj



signature.asc
Description: Digital signature


Bug#417861: Did not set wishlist severity

2007-04-05 Thread Bastian Venthur
Am 05.04.2007 03:51 schrieb Charles Plessy:
> I used reportbug-ng to send a wishlist bug, but it appears with the
> Normal ones.
> 
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=417581

Hmm, I see what you mean, the BTS seems to think this bug is normal. I
doubt this is a bug of reportbug-ng I think it should be a bug for
debbugs, since it ignored the severity in this case.


I'm CC'ing the debbugs-devels to see what they think.

Dear debbugs-devels: Charles reported a bug as "whishlist" but the BTS
seems to think it is of severity "normal"

The control lines where:

Package: bugs.debian.org
Version:
Severity: wishlist

Is there a problem with empty Version:-lines?



Cheers and happy eastern,

Bastian


-- 
Bastian Venthur  http://venthur.de
Debian Developer venthur at debian org



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Bug#417861: Did not set wishlist severity

2007-04-04 Thread Charles Plessy
Package: reportbug-ng
Version: 0.2007.03.29
Severity: normal

Dear Bastian,

I used reportbug-ng to send a wishlist bug, but it appears with the
Normal ones.

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=417581

Have a nice day,

-- Charles Plessy, Wako, Saitama, Japan

--- System information. ---
Architecture: powerpc
Kernel:   Linux 2.6.18-4-powerpc64

Debian Release: 4.0
  500 unstabledebian.jox.be 
  500 testing security.debian.org 
  500 testing ftp.jp.debian.org 

--- Package information. ---
Depends (Version) | Installed
=-+-===
python| 2.4.4-2
python-central (>= 0.5.8) | 0.5.12
python-qt3| 3.16-1.2


-- 
-- 
Charles Plessy
http://charles.plessy.org
Wako, Saitama, Japan


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]