Bug#420180: Pass SHELL=/bin/bash

[Loïc Minier]

Package: ipw3945-source
Followup-For: Bug #420180

Hi,

 Here's a patch to pass SHELL=/bin/bash when calling the upstream
 Makefile; it worked fine for me.

 I'll bump the severity to important as we're currently discussing
 making dash the default /bin/sh.

   Bye,

 PS: you might want to honor $(MAKE) clean failures.

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.22-1-686 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages ipw3945-source depends on:
ii  bzip2 1.0.3-7high-quality block-sorting file co
ii  debhelper 5.0.53 helper programs for debian/rules
ii  dpatch2.0.26 patch maintenance system for Debia
ii  make  3.81-3 The GNU version of the make util
ii  module-assistant  0.10.11tool to make module package creati

ipw3945-source recommends no packages.

-- no debconf information

-- 
Loïc Minier
diff -u ipw3945-1.2.1/debian/changelog ipw3945-1.2.1/debian/changelog
--- ipw3945-1.2.1/debian/changelog
+++ ipw3945-1.2.1/debian/changelog
@@ -1,3 +1,10 @@
+ipw3945 (1.2.1-2.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Pass SHELL=/bin/bash to the upstream Makefile which expects bash.
+
+ -- Loic Minier [EMAIL PROTECTED]  Sat, 04 Aug 2007 11:04:44 +0200
+
 ipw3945 (1.2.1-2) unstable; urgency=low
 
   * Applied patch from Egon [EMAIL PROTECTED] to fix potential driver lockup
diff -u ipw3945-1.2.1/debian/rules ipw3945-1.2.1/debian/rules
--- ipw3945-1.2.1/debian/rules
+++ ipw3945-1.2.1/debian/rules
@@ -63,7 +63,7 @@
 	dh_clean -k
 
 	# Build the module
-	$(MAKE) modules KSRC=$(KSRC) KVER=$(KVERS)
+	$(MAKE) modules SHELL=/bin/bash KSRC=$(KSRC) KVER=$(KVERS)
 
 	# Install the module
 	install -D -m 0644 ipw3945.ko debian/$(PACKAGE)-$(KVERS)/lib/modules/$(KVERS)/kernel/drivers/net/wireless/ipw3945.ko
@@ -86,7 +86,7 @@
 	#dh_testroot
 
 	# Cleaning package
-	-$(MAKE) clean
+	-$(MAKE) SHELL=/bin/bash clean
 
 	dh_clean
 

Bug#420180: Pass SHELL=/bin/bash

[Daniel Baumann]

Loïc Minier wrote:
  I'll bump the severity to important as we're currently discussing
  making dash the default /bin/sh.

the value of having dash as /bin/sh is, that bash can be removed. that's
why i'll fix the makefile instead of calling it with bash.

-- 
Address:Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:  [EMAIL PROTECTED]
Internet:   http://people.panthera-systems.net/~daniel-baumann/

Bug#420180: Pass SHELL=/bin/bash

[Loïc Minier]

On Sat, Aug 04, 2007, Daniel Baumann wrote:
 the value of having dash as /bin/sh is, that bash can be removed. that's
 why i'll fix the makefile instead of calling it with bash.

 No, the first reason dash is being discussed is for its speed; dropping
 bash is out of the question and is a multi-year work which is probably
 not worth the effort.  Feel free to fix the upstream Makefile though :)
 I wouldn't have invested time in this myself as the driver is likely to
 be superseded by iwlwifi.

-- 
Loïc Minier

Bug#420180: Pass SHELL=/bin/bash

[Daniel Baumann]

Loïc Minier wrote:
  No, the first reason dash is being discussed is for its speed;

i know why in *debian* we'd like to have /bin/sh on dash.

  dropping bash is out of the question and is a multi-year work which is 
 probably
  not worth the effort.

that's why *ipw3945* should not require bash (although i hardly think
that at that time, ipw3945 will still be in debian).

  I wouldn't have invested time in this myself as the driver is likely to
  be superseded by iwlwifi.

i'm well aware of this.

-- 
Address:Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:  [EMAIL PROTECTED]
Internet:   http://people.panthera-systems.net/~daniel-baumann/