Bug#420974: xterm: Bug is not fixed, because KOI8-R is not only one cyrillic charset.

2007-06-29 Thread Yauhen Kharuzhy 
Package: xterm
Version: 226-1
Followup-For: Bug #420974


I use locales ru_RU.CP1251 and be_BY.CP1251, CP1251 is another cyrillic
charset, and this bug still exists for me and many users from ex-USSR.
Additionaly, another one-byte charsets exist, not only for cyrillic
symbols, and fixing this bug for KOI8-R users only is error.

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.19 (SMP w/1 CPU core)
Locale: LANG=be_BY.CP1251, LC_CTYPE=be_BY.CP1251 (charmap=CP1251)
Shell: /bin/sh linked to /bin/bash

Versions of packages xterm depends on:
ii  libc6 2.5-11 GNU C Library: Shared libraries
ii  libfontconfig12.4.2-1.2  generic font configuration library
ii  libice6   1:1.0.3-2  X11 Inter-Client Exchange library
ii  libncurses5   5.6-3  Shared libraries for terminal hand
ii  libsm62:1.0.3-1  X11 Session Management library
ii  libx11-6  2:1.0.3-7  X11 client-side library
ii  libxaw7   1:1.0.3-3  X11 Athena Widget library
ii  libxext6  1:1.0.3-2  X11 miscellaneous extension librar
ii  libxft2   2.1.12-2   FreeType-based font drawing librar
ii  libxmu6   1:1.0.3-1  X11 miscellaneous utility library
ii  libxt61:1.0.5-3  X11 toolkit intrinsics library
ii  xbitmaps  1.0.1-2Base X bitmaps

Versions of packages xterm recommends:
ii  xutils  1:7.1.ds.3-1 X Window System utility programs

-- no debconf information


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Bug#420974: xterm: Bug is not fixed, because KOI8-R is not only one cyrillic charset.

2007-06-29 Thread Thomas Dickey 
On Fri, Jun 29, 2007 at 08:00:15PM +0200, Yauhen Kharuzhy wrote:
> Package: xterm
> Version: 226-1
> Followup-For: Bug #420974
> 
> 
> I use locales ru_RU.CP1251 and be_BY.CP1251, CP1251 is another cyrillic
> charset, and this bug still exists for me and many users from ex-USSR.
> Additionaly, another one-byte charsets exist, not only for cyrillic
> symbols, and fixing this bug for KOI8-R users only is error.

iirc, all of those use printable C1 (128-159 codes), so the fix noted in
the changes should apply:

 * amend select/paste change from patch #225 by limiting it to
   non-UTF-8/non-KOI8-R encoding (Debian #420974).
 
since the internal check for the "non-KOI8-R" only checks if the
allowC1Printable resource is set (the "-k8" option).

Here's the related chunk in xterm's button.c:

@@ -1611,7 +1611,8 @@
GettingSelection(dpy, *type, line, *length);

 #if OPT_WIDE_CHARS
-   if (*type == XA_UTF8_STRING(dpy)) {
+   if (*type == XA_UTF8_STRING(dpy) &&
+   !(screen->wide_chars || screen->c1_printable)) {
rc = Xutf8TextPropertyToTextList(dpy, &text_prop,
 &text_list, &text_list_count);
if (text_list != NULL && text_list_count != 0) {

Some KOI8-R users don't use the option, but that's never been supported.

p.s: before reporting a bug not fixed, try testing it.

-- 
Thomas E. Dickey
http://invisible-island.net
ftp://invisible-island.net


pgpFXa6TwHYr3.pgp
Description: PGP signature