Bug#425352: please enable compression for png images

[Sebastian Harl]

tags 425352 = moreinfo

Hi,

On Mon, May 21, 2007 at 09:30:54AM +0200, Bas Zoetekouw wrote:
 Please enable better compression for png images that are output by
 rrdtool.  This simple patch should do just that:

As Bernd already pointed out [1], we're not going to enable that by
default. However, please feel free to provide a patch which enables
compression on demand using a command line option. I'd be happy to
include that and forward it upstream.

TIA,
Sebastian

[1] http://bugs.debian.org/425352#10

-- 
Sebastian tokkee Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin



signature.asc
Description: Digital signature

Bug#425352: please enable compression for png images

[Bas Zoetekouw]

Package: rrdtool
Version: 1.2.15-0.3
Severity: wishlist
Tags: patch

Please enable better compression for png images that are output by
rrdtool.  This simple patch should do just that:


--- rrdtool-1.2.15/src/rrd_gfx.c.eerst  2007-05-21 09:28:03.430687978 +0200
+++ rrdtool-1.2.15/src/rrd_gfx.c2007-05-21 09:26:50.913141309 +0200
@@ -827,7 +827,7 @@
   /* lets make this fast while ending up with some increass in image size */
   png_set_filter(png_ptr,0,PNG_FILTER_NONE);
   /* png_set_filter(png_ptr,0,PNG_FILTER_SUB); */
-  png_set_compression_level(png_ptr,1);
+  png_set_compression_level(png_ptr,Z_BEST_COMPRESSION);
   /* png_set_compression_strategy(png_ptr,Z_HUFFMAN_ONLY); */
   /* 
   png_set_filter(png_ptr,PNG_FILTER_TYPE_BASE,PNG_FILTER_SUB);



-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-4-686
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)

Versions of packages rrdtool depends on:
ii  libart-2.0-2  2.3.17-1   Library of functions for 2D graphi
ii  libc6 2.3.6.ds1-13   GNU C Library: Shared libraries
ii  libfreetype6  2.2.1-5FreeType 2 font engine, shared lib
ii  libpng12-01.2.15~beta5-1 PNG library - runtime
ii  librrd2   1.2.15-0.3 Time-series data storage and displ
ii  zlib1g1:1.2.3-13 compression library - runtime

rrdtool recommends no packages.

-- no debconf information


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]