Bug#439959: No link for custom_strings_inc.php

2007-08-28 Thread Alistair Cunningham

schönfeld / in-medias-res wrote:

Alistair Cunningham wrote:

There should be a symlink from core/custom_strings_inc.php to
/etc/mantis/custom_strings_inc.php. This would allow this code in
core/lang_api.php to work: 


I think you mean a link from /etc/mantis/custom_strings_inc.php to
$MANTIS_DIR/custom_strings_inc.php. But as the mantis package is not
shipped with a custom_strings file I don't really see a reason to ship a
link to a non-existing file. Do i miss something?


Patrick,

I mean that core/custom_strings_inc.php is a symlink to normal file 
/etc/mantis/custom_strings_inc.php. This would allow the system 
administrator to put custom strings in 
/etc/mantis/custom_strings_inc.php, and have them override the language 
strings (e.g. lang/strings_english.txt) in a way that won't break when 
upgrading the the package.


--
Alistair Cunningham
+1 888 468 3111
+44 20 799 39 799
sip:[EMAIL PROTECTED]
http://integrics.com/


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#439959: No link for custom_strings_inc.php

2007-08-28 Thread schönfeld / in-medias-res
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Alistair Cunningham wrote:
 There should be a symlink from core/custom_strings_inc.php to
 /etc/mantis/custom_strings_inc.php. This would allow this code in
 core/lang_api.php to work: 

I think you mean a link from /etc/mantis/custom_strings_inc.php to
$MANTIS_DIR/custom_strings_inc.php. But as the mantis package is not
shipped with a custom_strings file I don't really see a reason to ship a
link to a non-existing file. Do i miss something?

Best Regards

Patrick
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG1G4hTKIzE6LY9r8RArHaAJ9bWbMq3lmf126+g1Snvjlk14rQAgCcCj4H
xnVcb5jhk23xtf/cxA+pHjA=
=atiL
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#439959: No link for custom_strings_inc.php

2007-08-28 Thread Alistair Cunningham

Package: mantis
Version: 1.0.7+dfsg-1

There should be a symlink from core/custom_strings_inc.php to 
/etc/mantis/custom_strings_inc.php. This would allow this code in 
core/lang_api.php to work:


# Allow overriding strings declared in the language file.
# custom_strings_inc.php can use $g_active_language
$t_custom_strings = dirname ( dirname( __FILE__ ) ) . 
DIRECTORY_SEPARATOR . 'custom_strings_inc.php';

if ( file_exists( $t_custom_strings ) ) {
require( $t_custom_strings ); # this may be loaded multiple 
times, once per language

}

--
Alistair Cunningham
+1 888 468 3111
+44 20 799 39 799
sip:[EMAIL PROTECTED]
http://integrics.com/


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#439959: No link for custom_strings_inc.php

2007-08-28 Thread schönfeld / in-medias-res
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Alistair Cunningham wrote:
 I mean that core/custom_strings_inc.php is a symlink to normal file
 /etc/mantis/custom_strings_inc.php. This would allow the system
 administrator to put custom strings in
 /etc/mantis/custom_strings_inc.php, and have them override the language
 strings (e.g. lang/strings_english.txt) in a way that won't break when
 upgrading the the package.

That does not seem to be an optimal solution.

You should be able to use this procedure anyways:
1) create a custom_strings_inc.php in /etc/mantis
2) link it to /usr/share/mantis/www/

and finally
3) include it from config_local.inc.php

As config_local.inc.php is not touched during installation/upgrading
(neither are self-created files) this is the preferred way and should
not break when upgrading the package. If it would break, then it would
be a bug.

Best Regards

Patrick

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG1HCOTKIzE6LY9r8RApT3AJ9gWfMfs0qank7IWDyLhLRW1XkfPwCfQrOg
bgkcMEAR2XP0dv+6dNHzQEE=
=9srU
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#439959: No link for custom_strings_inc.php

2007-08-28 Thread Alistair Cunningham

schönfeld / in-medias-res wrote:

That does not seem to be an optimal solution.

You should be able to use this procedure anyways:
1) create a custom_strings_inc.php in /etc/mantis
2) link it to /usr/share/mantis/www/

and finally
3) include it from config_local.inc.php

As config_local.inc.php is not touched during installation/upgrading
(neither are self-created files) this is the preferred way and should
not break when upgrading the package. If it would break, then it would
be a bug.


The problem with that is the symlink in /usr/share/mantis/www is not 
part of the .deb. Therefore removing the debian package will break 
because the directory is not empty, and installing the package on a new 
machine will not include the symlink.


Alistair Cunningham
+1 888 468 3111
+44 20 799 39 799
sip:[EMAIL PROTECTED]
http://integrics.com/


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#439959: No link for custom_strings_inc.php

2007-08-28 Thread schönfeld / in-medias-res
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Alistair Cunningham schrieb:
 The problem with that is the symlink in /usr/share/mantis/www is not
 part of the .deb. Therefore removing the debian package will break

No, it will not really break. But leave the local modifications alone.
And thats fine, cause custom strings are really modifications and not
something everybody needs.

 because the directory is not empty, and installing the package on a new
 machine will not include the symlink.

Thats right. But where is the problem in this?

Anyways, I'll think about touch'ing a custom_strings.inc.php during
postinst and symlink it into the directory. This should solve your problems.

Best Regards

Patrick

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG1HJATKIzE6LY9r8RAnYoAJ0UigulghoVrf4WKEw7VaWE3+vLgACePBkA
KaoLGj5cbCxx+kVim3p8NxE=
=GT63
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#439959: No link for custom_strings_inc.php

2007-08-28 Thread Alistair Cunningham

schönfeld / in-medias-res wrote:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Alistair Cunningham schrieb:

The problem with that is the symlink in /usr/share/mantis/www is not
part of the .deb. Therefore removing the debian package will break


No, it will not really break. But leave the local modifications alone.
And thats fine, cause custom strings are really modifications and not
something everybody needs.


because the directory is not empty, and installing the package on a new
machine will not include the symlink.


Thats right. But where is the problem in this?

Anyways, I'll think about touch'ing a custom_strings.inc.php during
postinst and symlink it into the directory. This should solve your problems.

Best Regards

Patrick


Patrick,

Thank you. I will await your feedback.

--
Alistair Cunningham
+1 888 468 3111
+44 20 799 39 799
sip:[EMAIL PROTECTED]
http://integrics.com/



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]