Bug#444471: Various typos in manpages
Hi, On Wed, Oct 17, 2007 at 10:52:54PM +0200, [EMAIL PROTECTED] wrote: I think glibc is trying to do the right thing -- employing the names that are used on other implementations. I changed PTRACE_POKEUSR to PTRACE_POKEUSER, and PTRACE_PEEKUSR to PTRACE_PEEKUSER on this page. Seem okay? Yes. Thanks for your time. -- Nekral -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#444471: Various typos in manpages
tags 71 fixed-upstream thanks Hello Nicolas, Applied for upstream 2.68, but see my comment about one point below. Nicolas François wrote: Package: manpages Version: 2.63-1 Severity: minor Tags: patch Hello, Here are various typos which I checked are still present in 2.65. (manpages_typos.patch) I also have a question in madvise.2, I don't understand return file in: Free up a given range of pages and its associated backing store. Currently, only shmfs/tmpfs supports this; other filesystems return file with the error ENOSYS. Is it a typo or is my English more broken than I think? You are right. The word file should not be there. Fixed. Also, in spu_create.2: Shouldn't file handler be a file descriptor instead? (or is this equivalent?) You are correct. Fixed now. diff -rauN ../orig/manpages-2.63/man2/pciconfig_read.2 manpages-2.63/man2/pciconfig_read.2 --- ../orig/manpages-2.63/man2/pciconfig_read.2 2007-09-06 01:07:40.0 +0200 +++ manpages-2.63/man2/pciconfig_read.2 2007-09-28 20:23:08.0 +0200 @@ -55,7 +55,7 @@ .BR pciconfig_read () On success zero is returned. On error, \-1 is returned and -,I errno +.I errno is set appropriately. .TP .BR pciconfig_write () diff -rauN ../orig/manpages-2.63/man2/ptrace.2 manpages-2.63/man2/ptrace.2 --- ../orig/manpages-2.63/man2/ptrace.2 2007-09-06 01:07:18.0 +0200 +++ manpages-2.63/man2/ptrace.2 2007-09-28 20:27:36.0 +0200 @@ -131,7 +131,7 @@ .I addr in the child's USER area, which holds the registers and other information about the process -(see \fIlinux/user.h\fP and sys/user.h). +(see \fIlinux/user.h\fP and \fIsys/user.h\fP). The word is returned as the result of the .BR ptrace () call. @@ -146,7 +146,7 @@ in the child's memory. As above, the two requests are currently equivalent. .TP -.B PTRACE_POKEUSR +.B PTRACE_POKEUSER This is not correct. PTRACE_POKEUSR is right. Everything else was applied as you gave. Thank you for all of that work. Cheers, Michael -- Michael Kerrisk maintainer of Linux man pages Sections 2, 3, 4, 5, and 7 Want to help with man page maintenance? Grab the latest tarball at http://www.kernel.org/pub/linux/docs/manpages/ read the HOWTOHELP file and grep the source files for 'FIXME'. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#444471: Various typos in manpages
Justin Pryzby wrote: On Fri, Sep 28, 2007 at 11:22:28PM +0200, Nicolas François wrote: I also have a question in madvise.2, madvise.2 also says pagei(s) from changing the physical location of a pagei(s) if the parent Fixed for 2.68. Thanks, Michael -- Michael Kerrisk maintainer of Linux man pages Sections 2, 3, 4, 5, and 7 Want to help with man page maintenance? Grab the latest tarball at http://www.kernel.org/pub/linux/docs/manpages/ read the HOWTOHELP file and grep the source files for 'FIXME'. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#444471: Various typos in manpages
Hello Michael, Thanks again for the patch review. On Wed, Oct 17, 2007 at 08:16:12AM +0200, [EMAIL PROTECTED] wrote: Applied for upstream 2.68, but see my comment about one point below. @@ -146,7 +146,7 @@ in the child's memory. As above, the two requests are currently equivalent. .TP -.B PTRACE_POKEUSR +.B PTRACE_POKEUSER This is not correct. PTRACE_POKEUSR is right. After checking, it is quite strange because: /usr/include/linux/ptrace.h defines PTRACE_POKEUSR (from the Debian package linux-libc-dev 2.6.22-4) /usr/include/sys/ptrace.hdefines PTRACE_POKEUSER (from the Debian package libc6-dev 2.6.1-5) Also, the man2 ptrace page mentions both PTRACE_POKEUSR and PTRACE_POKEUSER (in the description of PTRACE_SETREGS and PTRACE_SETFPREGS). Are these ptrace requests standardized in SVr4 and 4.3BSD? I guess the glibc shall define PTRACE_POKEUSR (and redefine PTRACE_POKEUSER as an alias for backward compatibility). (and the same for he PEEK request) Kind Regards, -- Nekral -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#444471: Various typos in manpages
Nicolas, Thanks for persisting with your point. @@ -146,7 +146,7 @@ in the child's memory. As above, the two requests are currently equivalent. .TP -.B PTRACE_POKEUSR +.B PTRACE_POKEUSER This is not correct. PTRACE_POKEUSR is right. After checking, it is quite strange because: /usr/include/linux/ptrace.h defines PTRACE_POKEUSR (from the Debian package linux-libc-dev 2.6.22-4) /usr/include/sys/ptrace.hdefines PTRACE_POKEUSER (from the Debian package libc6-dev 2.6.1-5) Also, the man2 ptrace page mentions both PTRACE_POKEUSR and PTRACE_POKEUSER (in the description of PTRACE_SETREGS and PTRACE_SETFPREGS). It looks to me like I spoke to soon. I checked the kernel source but not the glibc source, and it looks as though you are right: glibc uses PTRACE_POKEUSER. Are these ptrace requests standardized in SVr4 and 4.3BSD? Looks like PTRACE_POKEUSER is on AIX and Solaris, but I couldn't find PTRACE_POKEUSR on any of the other systems I checked. I guess the glibc shall define PTRACE_POKEUSR (and redefine PTRACE_POKEUSER as an alias for backward compatibility). (and the same for he PEEK request) I think glibc is trying to do the right thing -- employing the names that are used on other implementations. I changed PTRACE_POKEUSR to PTRACE_POKEUSER, and PTRACE_PEEKUSR to PTRACE_PEEKUSER on this page. Seem okay? Cheers, Michael -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#444471: Various typos in manpages
Package: manpages
Version: 2.63-1
Severity: minor
Tags: patch
Hello,
Here are various typos which I checked are still present in 2.65.
(manpages_typos.patch)
I also have a question in madvise.2, I don't understand return file in:
Free up a given range of pages and its associated backing store.
Currently, only shmfs/tmpfs supports this; other filesystems return file
with the error ENOSYS.
Is it a typo or is my English more broken than I think?
Also, in spu_create.2:
Shouldn't file handler be a file descriptor instead? (or is this
equivalent?)
Thanks in advance,
--
Nekral
diff -rauN ../orig/manpages-2.63/man2/pciconfig_read.2 manpages-2.63/man2/pciconfig_read.2
--- ../orig/manpages-2.63/man2/pciconfig_read.2 2007-09-06 01:07:40.0 +0200
+++ manpages-2.63/man2/pciconfig_read.2 2007-09-28 20:23:08.0 +0200
@@ -55,7 +55,7 @@
.BR pciconfig_read ()
On success zero is returned.
On error, \-1 is returned and
-,I errno
+.I errno
is set appropriately.
.TP
.BR pciconfig_write ()
diff -rauN ../orig/manpages-2.63/man2/ptrace.2 manpages-2.63/man2/ptrace.2
--- ../orig/manpages-2.63/man2/ptrace.2 2007-09-06 01:07:18.0 +0200
+++ manpages-2.63/man2/ptrace.2 2007-09-28 20:27:36.0 +0200
@@ -131,7 +131,7 @@
.I addr
in the child's USER area,
which holds the registers and other information about the process
-(see \fIlinux/user.h\fP and sys/user.h).
+(see \fIlinux/user.h\fP and \fIsys/user.h\fP).
The word is returned as the result of the
.BR ptrace ()
call.
@@ -146,7 +146,7 @@
in the child's memory.
As above, the two requests are currently equivalent.
.TP
-.B PTRACE_POKEUSR
+.B PTRACE_POKEUSER
Copies the word
.IR data
to offset
@@ -169,7 +169,7 @@
from the child to location \fIdata\fP in the parent.
(\fIaddr\fP is ignored.)
.TP
-.BR PTRACE_SETREGS , PTRACE_SETFPREGS
+.BR PTRACE_SETREGS , PTRACE_SETFPREGS
Copies the child's general purpose or floating-point registers,
respectively, from location \fIdata\fP in the parent.
As for
@@ -325,7 +325,7 @@
the system call at the second stop.
(\fIaddr\fP is ignored.)
.TP
-.BR PTRACE_SYSEMU , PTRACE_SYSEMU_SINGLESTEP (since Linux 2.6.14)
+.BR PTRACE_SYSEMU , PTRACE_SYSEMU_SINGLESTEP (since Linux 2.6.14)
For
.BR PTRACE_SYSEMU ,
continue and stop on entry to the next syscall,
diff -rauN ../orig/manpages-2.63/man2/sigaction.2 manpages-2.63/man2/sigaction.2
--- ../orig/manpages-2.63/man2/sigaction.2 2007-09-06 01:11:36.0 +0200
+++ manpages-2.63/man2/sigaction.2 2007-09-28 20:32:09.0 +0200
@@ -265,7 +265,7 @@
.I si_code
is a value (not a bit mask)
indicating why this signal was sent.
-The following list shows the values can be placed in
+The following list shows the values which can be placed in
.I si_code
for any signal, along with reason that the signal was generated.
.RS 4
@@ -304,7 +304,7 @@
.\ through to 2.5.24 and then was backed out.
.RE
.PP
-The following values can be place in
+The following values can be placed in
.I si_code
for a
.B SIGILL
@@ -336,7 +336,7 @@
internal stack error
.RE
.PP
-The following values can be place in
+The following values can be placed in
.I si_code
for a
.B SIGFPE
@@ -368,7 +368,7 @@
subscript out of range
.RE
.PP
-The following values can be place in
+The following values can be placed in
.I si_code
for a
.B SIGSEGV
@@ -382,7 +382,7 @@
invalid permissions for mapped object
.RE
.PP
-The following values can be place in
+The following values can be placed in
.I si_code
for a
.B SIGBUS
@@ -399,7 +399,7 @@
object specific hardware error
.RE
.PP
-The following values can be place in
+The following values can be placed in
.I si_code
for a
.B SIGTRAP
@@ -413,7 +413,7 @@
process trace trap
.RE
.PP
-The following values can be place in
+The following values can be placed in
.I si_code
for a
.B SIGILL
@@ -439,7 +439,7 @@
stopped child has continued (since Linux 2.6.9)
.RE
.PP
-The following values can be place in
+The following values can be placed in
.I si_code
for a
.B SIGPOLL
diff -rauN ../orig/manpages-2.63/man3/setaliasent.3 manpages-2.63/man3/setaliasent.3
--- ../orig/manpages-2.63/man3/setaliasent.3 2007-07-29 08:21:37.0 +0200
+++ manpages-2.63/man3/setaliasent.3 2007-09-28 20:40:13.0 +0200
@@ -74,7 +74,7 @@
.nf
struct aliasent {
-char*alias_name; /* alias name */
+char*alias_name; /* alias name */
size_t alias_members_len;
char **alias_members; /* alias name list */
int alias_local;
diff -rauN ../orig/manpages-2.63/man5/locale.5 manpages-2.63/man5/locale.5
--- ../orig/manpages-2.63/man5/locale.5 2007-06-23 09:28:46.0 +0200
+++ manpages-2.63/man5/locale.5 2007-09-28 20:47:23.0 +0200
@@ -351,7 +351,7 @@
.I currency_symbol
or
.I int_curr_symbol
- should precede the formatted monetary quantity or set to
+should precede the formatted monetary quantity or set to
.B 0
if the symbol succeeds the value.
.TP
Bug#444471: Various typos in manpages
On Fri, Sep 28, 2007 at 11:22:28PM +0200, Nicolas François wrote: I also have a question in madvise.2, madvise.2 also says pagei(s) from changing the physical location of a pagei(s) if the parent
