Bug#451772: rt73-common: Still ships symlink in /lib/firmware
2007/11/18, Sven Joachim [EMAIL PROTECTED]: , | * The /lib/firmware/rt73.bin symlink is created with update-rt73-firmware | script, so the package won't conflict with rt73-firmware package. ` However, the symlink is still in the package, which means that Guess what, this just happened to me and the kernel oopses that followed after loading the driver without the firmware were not really pretty. :-/ I'm really sorry! It is my fault that the symlink is still in the package and I'm uploading fixed version just now. The driver still has many bugs and some of them aren't sworkarounded, yet. Please notice, the driver is still in unstable and didn't enter the lenny. -- .''`.Piotr Roszatycki : :' :mailto:[EMAIL PROTECTED] `. `' mailto:[EMAIL PROTECTED] `- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#451772: rt73-common: Still ships symlink in /lib/firmware
On Sun, 2007-11-25 at 22:08 +0100, Piotr Roszatycki wrote:
2007/11/18, Sven Joachim [EMAIL PROTECTED]:
,
| * The /lib/firmware/rt73.bin symlink is created with
update-rt73-firmware
| script, so the package won't conflict with rt73-firmware package.
`
However, the symlink is still in the package, which means that
Guess what, this just happened to me and the kernel oopses that
followed after loading the driver without the firmware were not
really pretty. :-/
I'm really sorry! It is my fault that the symlink is still in the
package and I'm uploading fixed version just now.
The driver still has many bugs and some of them aren't sworkarounded,
yet.
And most of them never will be - Ralink doesn't seem to support its
drivers for long, and the rt2x00 project has given up trying to patch
them. However, this should fix the probe routine so it doesn't crash:
--- rt73.orig/Module/rtmp_main.c
+++ rt73/Module/rtmp_main.c
@@ -2258,7 +2258,7 @@
res = register_netdev(netdev);
if (res) {
printk(register_netdev failed err=%d\n,res);
- goto out;
+ goto out_noregnetdev;
}
usb_set_intfdata(intf, pAd);
@@ -2268,16 +2268,19 @@
res = LoadFirmware(pAd, firmName);
if (res) {
DBGPRINT(RT_DEBUG_ERROR, Failed to request Firmware.\n);
- goto out;
+ goto out_nofirmware;
}
return 0;
-out:
+out_nofirmware:
+ rt73usb_close_debugfs();
+ unregister_netdev(netdev);
+out_noregnetdev:
free_netdev(netdev);
out_nonetdev:
kfree(pAd);
out_noalloc:
- module_put(THIS_MODULE);
+ usb_put_dev(dev);
return res;
}
-- END --
I haven't made any changes in SVN because I couldn't see where I should
add patch/unpatch commands in the packages file.
Please notice, the driver is still in unstable and didn't enter
the lenny.
Hopefully we can drop all the legacy drivers before lenny, since the new
drivers will be included in standard Linux kernels.
Ben.
--
Ben Hutchings
Computers are not intelligent. They only think they are.
signature.asc
Description: This is a digitally signed message part
Bug#451772: rt73-common: Still ships symlink in /lib/firmware
Package: rt73-common Version: 1:1.0.3.6-cvs20071114-dfsg1-1 Severity: important From debian/changelog: , | * The /lib/firmware/rt73.bin symlink is created with update-rt73-firmware | script, so the package won't conflict with rt73-firmware package. ` However, the symlink is still in the package, which means that - systems which had the firmware file (rt73.bin) in /lib/firmware before (that is the place where upstream places it) will be broken because it is removed; - the warning in the postinst script is never displayed, because the symlink exists. Guess what, this just happened to me and the kernel oopses that followed after loading the driver without the firmware were not really pretty. :-/ -- System Information: Debian Release: lenny/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: i386 (i686) Kernel: Linux 2.6.22.13 Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages rt73-common depends on: ii unzip 5.52-10De-archiver for .zip files ii wget 1.10.2-3 retrieves files from the web rt73-common recommends no packages. -- no debconf information -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
