Bug#457432: popularity-contest: Please include /lib/.+/ in the search space

2008-01-14 Thread Bill Allombert 
On Sat, Dec 22, 2007 at 12:32:35PM +0100, Johan Walles wrote:
 Package: popularity-contest
 Version: 1.42
 Severity: wishlist
 Tags: patch
 
 Please include /lib/.+/ in the search space.  This makes Gnome applets which 
 put files only in 
 /usr/lib/appletname/... get proper statistics, as well as kernel-module only 
 packages which put
 files in /lib/modules/... .

 Since only /lib and /usr/lib themselves, but not their subdirectories are 
 scanned by ldconfig,
 this doesn't add any false positives for libraries.

This assume only ldconfig is playing with /usr/lib. Unfortunately this
is not true, for example files under /usr/lib/locale/ are automatically
generated, and so are some python files in /usr/share/, etc.

The popularity-contest server use dependencies to get usage of package 
with NO FILES: they get as much usage as the packages that depend on
them, so it is not necessary to have files for all packages.

Cheers,
-- 
Bill. [EMAIL PROTECTED]

Imagine a large red swirl here. 



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#457432: [Popcon-developers] Bug#457432: popularity-contest: Please include /lib/.+/ in the search space

2008-01-14 Thread Petter Reinholdtsen 
[Bill Allombert]
 This assume only ldconfig is playing with /usr/lib. Unfortunately this
 is not true,

I thought the only problem was updates that happened regularly, as in
from cron.  I am only aware of ldconfig and manual page indexing being
called from cron and reading files in a way that disturb popcon votes.

 for example files under /usr/lib/locale/ are automatically
 generated,

The only ones I know about are not generated by cron byt during
package updates or by the sysadmin, and none of the files generated by
locale-gen are owned by any packages.

 and so are some python files in /usr/share/, etc.

Are you thinking of the .pyc files?  The .pyc files are as far as I
know only updated during package install, and neither are owned by any
package.

Both of these examples should not affect the popcon votes, as far as I
know, and I considered both when deciding to add the patch.  The only
think I was unsure about was the ldconfig update, and I checked it to
verify that it was not affecting this change.  Did I overlook
something?

Happy hacking,
-- 
Petter Reinholdtsen



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#457432: popularity-contest: Please include /lib/.+/ in the search space

2007-12-22 Thread Johan Walles 
Package: popularity-contest
Version: 1.42
Severity: wishlist
Tags: patch


--- popularity-contest-1.42/popularity-contest  2006-10-08 18:30:36.0 
+0200
+++ popularity-contest-1.42-johan/popularity-contest2007-12-22 
12:20:20.0 +0100
@@ -83,7 +83,7 @@
   while (FILES)
   {
 chop;
-m{/bin/|/sbin/|^/usr/games/|\.[ah]$|\.pm|^/boot/System\.map-} or next;
+m{/bin/|/sbin/|/lib/.+/|^/usr/games/|\.[ah]$|\.pm|^/boot/System\.map-} or 
next;
 -f $_ or next;
 my($dev,$ino,$mode,$nlink,$uid,$gid,$rdev,$size,
   $atime,$mtime,$ctime,$blksize,$blocks)

Please include /lib/.+/ in the search space.  This makes Gnome applets which 
put files only in 
/usr/lib/appletname/... get proper statistics, as well as kernel-module only 
packages which put
files in /lib/modules/... .

Since only /lib and /usr/lib themselves, but not their subdirectories are 
scanned by ldconfig,
this doesn't add any false positives for libraries.

  Regards //Johan

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (990, 'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.22-3-686 (SMP w/2 CPU cores)
Locale: LANG=sv_SE.UTF-8, LC_CTYPE=sv_SE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages popularity-contest depends on:
ii  debconf [debconf-2.0] 1.5.17 Debian configuration management sy
ii  dpkg  1.14.7 package maintenance system for Deb

Versions of packages popularity-contest recommends:
ii  cron  3.0pl1-100 management of regular background p
pn  mime-constructnone (no description available)
ii  postfix [mail-transport-agent 2.4.6-2High-performance mail transport ag

-- debconf information:
  popularity-contest/submiturls:
* popularity-contest/participate: true
* popularity-contest/intro:
  popularity-contest/hostid-failed:
  popularity-contest/use-http: false



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]