Bug#462058: [SPAM?] Bug#462058: Acknowledgement (python-django: problem when extracting PostgreSQL's version number)
On 06 Feb 08:55, Raphael Hertzog wrote: On Tue, 05 Feb 2008, Brett Parker wrote: On 05 Feb 20:49, Brett Parker wrote: On 03 Feb 23:09, Raphael Hertzog wrote: Any progress? Well, I've nearly finished a patch for the 0.96 branch, just tidying it a bit now... should be commited to SVN this evening. I've commited a fix to svn that's working for me, keeps previous behaviour for full numerical version numbers and seems to be the least nasty way of doing it that I could find. Ok, I'll review and upload later. Did you forward it to upstream already? Does it concern the experimental version too? It also concerns the experimental version, but as things were moved around, I need to generate a (slightly different) patch for that which I'll forward upstream and add to the ticket open there. -- Brett Parker -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#462058: [SPAM?] Bug#462058: Acknowledgement (python-django: problem when extracting PostgreSQL's version number)
On 03 Feb 23:09, Raphael Hertzog wrote: On Wed, 23 Jan 2008, Brett Parker wrote: This has been reported already upstream at http://code.djangoproject.com/ticket/6433. Unfortunately both patches (yours and the one on that ticket) have slightly interesting bugs... For example, the patch on that ticket would parse 8.3RC3 - [8, 33] which is (clearly) wrong. Yours has an issue that isn't currently a problem in postgres, but maybe at sometime in the future, if you had the string 10.1RC3 your version would end up with [1, 0, 1] which is obviously not the desired effect! I'm looking in to this bug, and will be tracking upstreams dealings with it. Any progress? Well, I've nearly finished a patch for the 0.96 branch, just tidying it a bit now... should be commited to SVN this evening. -- Brett Parker -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#462058: [SPAM?] Bug#462058: Acknowledgement (python-django: problem when extracting PostgreSQL's version number)
On 05 Feb 20:49, Brett Parker wrote: On 03 Feb 23:09, Raphael Hertzog wrote: Any progress? Well, I've nearly finished a patch for the 0.96 branch, just tidying it a bit now... should be commited to SVN this evening. I've commited a fix to svn that's working for me, keeps previous behaviour for full numerical version numbers and seems to be the least nasty way of doing it that I could find. Thanks, -- Brett Parker -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#462058: [SPAM?] Bug#462058: Acknowledgement (python-django: problem when extracting PostgreSQL's version number)
On Tue, 05 Feb 2008, Brett Parker wrote: On 05 Feb 20:49, Brett Parker wrote: On 03 Feb 23:09, Raphael Hertzog wrote: Any progress? Well, I've nearly finished a patch for the 0.96 branch, just tidying it a bit now... should be commited to SVN this evening. I've commited a fix to svn that's working for me, keeps previous behaviour for full numerical version numbers and seems to be the least nasty way of doing it that I could find. Ok, I'll review and upload later. Did you forward it to upstream already? Does it concern the experimental version too? Cheers, -- Raphaël Hertzog Le best-seller français mis à jour pour Debian Etch : http://www.ouaza.com/livre/admin-debian/
Bug#462058: [SPAM?] Bug#462058: Acknowledgement (python-django: problem when extracting PostgreSQL's version number)
On Wed, 23 Jan 2008, Brett Parker wrote: This has been reported already upstream at http://code.djangoproject.com/ticket/6433. Unfortunately both patches (yours and the one on that ticket) have slightly interesting bugs... For example, the patch on that ticket would parse 8.3RC3 - [8, 33] which is (clearly) wrong. Yours has an issue that isn't currently a problem in postgres, but maybe at sometime in the future, if you had the string 10.1RC3 your version would end up with [1, 0, 1] which is obviously not the desired effect! I'm looking in to this bug, and will be tracking upstreams dealings with it. Any progress? Cheers, -- Raphaël Hertzog Le best-seller français mis à jour pour Debian Etch : http://www.ouaza.com/livre/admin-debian/
Bug#462058: [SPAM?] Bug#462058: Acknowledgement (python-django: problem when extracting PostgreSQL's version number)
This has been reported already upstream at http://code.djangoproject.com/ticket/6433. Unfortunately both patches (yours and the one on that ticket) have slightly interesting bugs... For example, the patch on that ticket would parse 8.3RC3 - [8, 33] which is (clearly) wrong. Yours has an issue that isn't currently a problem in postgres, but maybe at sometime in the future, if you had the string 10.1RC3 your version would end up with [1, 0, 1] which is obviously not the desired effect! I'm looking in to this bug, and will be tracking upstreams dealings with it. Thanks! -- Brett Parker -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#462058: [SPAM?] Bug#462058: Acknowledgement (python-django: problem when extracting PostgreSQL's version number)
Debian Bug Tracking System wrote:
Thank you for the problem report you have sent regarding Debian.
This is an automatically generated reply, to let you know your message has
been received. It is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.
The attached patch fixes the problem for me.
hth
Jerome Alet
--- base.py 2007-10-26 21:21:35.0 +0200
+++ base.py.new 2008-01-22 09:27:17.995217070 +0100
@@ -54,7 +54,13 @@
global postgres_version
if not postgres_version:
cursor.execute(SELECT version())
-postgres_version = [int(val) for val in cursor.fetchone()[0].split()[1].split('.')]
+ postgres_version = []
+ raw_version = cursor.fetchone()[0]
+ for c in raw_version :
+ if c.isdigit() :
+ postgres_version.append(int(c))
+ elif c != . :
+ break
if settings.DEBUG:
return util.CursorDebugWrapper(cursor, self)
return cursor
