Bug#463129: mode_option or mode parameter (was: i810fb module parameter 'mode_option' inconsistent with other framebuffer modules)
On Tue, 2008-02-05 at 08:08 +0100, [EMAIL PROTECTED] wrote: Hi, Few days ago, a bug was reported that the i810fb uses mode_option parameters while other framebuffers uses the mode parameter to set initial mode. It was spotted later that some drivers uses mode_option, some uses mode and some does use none. I want to ask what is a correct way. I can rework at least some of the drivers to a standard way, but I don't know what the standard is. With your permission, I have cc:'ed your question to my original Debian bug report, From Documentation/fb/modedb.txt: --- When a frame buffer device receives a video= option it doesn't know, it should consider that to be a video mode option. If no frame buffer device is specified in a video= option, fbmem considers that to be a global video mode option. Valid mode specifiers (mode_option argument): ... From this I believe that 'mode_option' is the standard way, It also indicates that the parameter name itself is optional, but I am not sure if there is an overall Linux standard for indicating optional parameter names. Kind regards, Alain P.S.: Krzysztof, maybe it would be a good idea to update fbmode.txt too, as there are now many more framebuffer drivers which support video mode naming. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#463129: mode_option or mode parameter (was: i810fb module parameter 'mode_option' inconsistent with other framebuffer modules)
On Tue, 2008-02-05 at 12:42 +0100, Alain Kalker wrote: P.S.: Krzysztof, maybe it would be a good idea to update fbmode.txt too, as there are now many more framebuffer drivers which support video mode naming. I have to rephrase that, the situation is much more complicated (sigh). The only pattern I see is that drivers which support ModeDB (e.g. i810fb) use the parameter name 'video_mode' which can then be optional, while others (e.g. cirrusfb) use hardcoded video modes and _require_ the parameter name to be present, which must then be called 'mode'. Kind regards, Alain -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#463129: mode_option or mode parameter (was: i810fb module parameter 'mode_option' inconsistent with other framebuffer modules)
Alain Kalker napisał: From Documentation/fb/modedb.txt: --- When a frame buffer device receives a video= option it doesn't know, it should consider that to be a video mode option. If no frame buffer device is specified in a video= option, fbmem considers that to be a global video mode option. Valid mode specifiers (mode_option argument): ... From this I believe that mode_option is the standard way, It also indicates that the parameter name itself is optional, but I am not sure if there is an overall Linux standard for indicating optional parameter names. If the mode_option is the correct one please email Andrew Morton to remove the patch I made for i810fb. I will fix drivers which use the mode option. P.S.: Krzysztof, maybe it would be a good idea to update fbmode.txt too, as there are now many more framebuffer drivers which support video mode naming. I'll update it with every driver I reworked. Regards, Krzysztof Pogoda na najblizsze dni. Sprawdz http://link.interia.pl/f1ce1
Bug#463129: mode_option or mode parameter (was: i810fb module parameter 'mode_option' inconsistent with other framebuffer modules)
On Tue, 2008-02-05 at 13:09 +0100, Alain Kalker wrote: parameter name 'video_mode' That should be 'mode_option'. Need More Coffee ASAP -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#463129: mode_option or mode parameter (was: i810fb module parameter 'mode_option' inconsistent with other framebuffer modules)
On Tue, 2008-02-05 at 13:40 +0100, [EMAIL PROTECTED] wrote: Alain Kalker napisał: From Documentation/fb/modedb.txt: --- When a frame buffer device receives a video= option it doesn't know, it should consider that to be a video mode option. If no frame buffer device is specified in a video= option, fbmem considers that to be a global video mode option. Valid mode specifiers (mode_option argument): ... From this I believe that mode_option is the standard way, It also indicates that the parameter name itself is optional, but I am not sure if there is an overall Linux standard for indicating optional parameter names. If the mode_option is the correct one please email Andrew Morton to remove the patch I made for i810fb. I will fix drivers which use the mode option. Done. P.S.: Krzysztof, maybe it would be a good idea to update fbmode.txt too, as there are now many more framebuffer drivers which support video mode naming. I'll update it with every driver I reworked. Thanks! Regards, Alain
