Bug#468143: collectd: sensors plugin stopped working after upgrade
Hi Sebastian, On Fri, Apr 18, 2008 at 09:27:53AM +0200, Sebastian Harl wrote: On Fri, Apr 18, 2008 at 08:22:07AM +0200, Florian Forster wrote: Please give the attached patch a try and tell me if it worked or not. I'm sure Sebastian or some howto can tell you how to do integrate that into the package building process, if necessary. I've prepared a package of a 4.3.2 + that patch snapshot. You can find it at [1] - for instructions how to build the package see one of my follow-up e-mails to this bug report ([2]). Feedback would be very appreciated. [1] http://debian.tokkee.org/tmp/collectd/collectd_4.3.2.1.g33d82fc-1.dsc [2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=468143#32 Has anyone of you tested this patch so far? collectd 4.3.3 has just been released which includes that patch. I'm going to close this bug again in the next upload but I'd really like some positive feedback before doing so. That patch solved it ... the sensors-plugin is working for me now. Cheers and many thanks ... Armin -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#468143: collectd: sensors plugin stopped working after upgrade
Has anyone of you tested this patch so far? collectd 4.3.3 has just been released which includes that patch. I'm going to close this bug again in the next upload but I'd really like some positive feedback before doing so. TIA, Sebastian Yes, the patch works for me as I already said in http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=468143#42 Ondrej -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#468143: collectd: sensors plugin stopped working after upgrade
Hi, On Fri, Apr 18, 2008 at 09:27:53AM +0200, Sebastian Harl wrote: > On Fri, Apr 18, 2008 at 08:22:07AM +0200, Florian Forster wrote: > > Please give the attached patch a try and tell me if it worked or not. > > I'm sure Sebastian or some howto can tell you how to do integrate that > > into the package building process, if necessary. > > I've prepared a package of a 4.3.2 + that patch snapshot. You can find > it at [1] - for instructions how to build the package see one of my > follow-up e-mails to this bug report ([2]). Feedback would be very > appreciated. > [1] http://debian.tokkee.org/tmp/collectd/collectd_4.3.2.1.g33d82fc-1.dsc > [2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=468143#32 Has anyone of you tested this patch so far? collectd 4.3.3 has just been released which includes that patch. I'm going to close this bug again in the next upload but I'd really like some positive feedback before doing so. TIA, Sebastian -- Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/ Those who would give up Essential Liberty to purchase a little Temporary Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin signature.asc Description: Digital signature
Bug#468143: collectd: sensors plugin stopped working after upgrade
reopen 468143 found 468143 4.3.2-1 tags 468143 + patch pending fixed-upstream thanks Hi, On Fri, Apr 18, 2008 at 08:22:07AM +0200, Florian Forster wrote: > while writing a reply and interpreting the log output you've provided, I > stumbled across the bug. The function which is responsible for > formatting the chip name does so depending on the type of the chip. The > returned status variable is only set in one out of three branches, > though :/ A schoolbook example of ``harmful initialization''.. D'oh :-/ Thanks for the patch, Florian! > Please give the attached patch a try and tell me if it worked or not. > I'm sure Sebastian or some howto can tell you how to do integrate that > into the package building process, if necessary. I've prepared a package of a 4.3.2 + that patch snapshot. You can find it at [1] - for instructions how to build the package see one of my follow-up e-mails to this bug report ([2]). Feedback would be very appreciated. I've reopened the bug for now. After some positive feedback, I will include Florian's patch in the next upload. An updated backports.org package will be available as soon as that new version migrates to testing. TIA, Sebastian [1] http://debian.tokkee.org/tmp/collectd/collectd_4.3.2.1.g33d82fc-1.dsc [2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=468143#32 -- Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/ Those who would give up Essential Liberty to purchase a little Temporary Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin signature.asc Description: Digital signature
Bug#468143: collectd: sensors plugin stopped working after upgrade
Hi Alex,
while writing a reply and interpreting the log output you've provided, I
stumbled across the bug. The function which is responsible for
formatting the chip name does so depending on the type of the chip. The
returned status variable is only set in one out of three branches,
though :/ A schoolbook example of ``harmful initialization''..
Please give the attached patch a try and tell me if it worked or not.
I'm sure Sebastian or some howto can tell you how to do integrate that
into the package building process, if necessary.
Regards,
-octo
--
Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
http://verplant.org/
diff --git a/src/sensors.c b/src/sensors.c
index 2a0a9ea..173ed9c 100644
--- a/src/sensors.c
+++ b/src/sensors.c
@@ -189,14 +189,14 @@ static int sensors_snprintf_chip_name (char *buf, size_t buf_size,
}
else if (chip->bus == SENSORS_CHIP_NAME_BUS_DUMMY)
{
- snprintf (buf, buf_size, "%s-%s-%04x",
+ status = snprintf (buf, buf_size, "%s-%s-%04x",
chip->prefix,
chip->busname,
chip->addr);
}
else
{
- snprintf (buf, buf_size, "%s-i2c-%d-%02x",
+ status = snprintf (buf, buf_size, "%s-i2c-%d-%02x",
chip->prefix,
chip->bus,
chip->addr);
signature.asc
Description: Digital signature
Bug#468143: collectd: sensors plugin stopped working after upgrade
On Wednesday 16 April 2008, Sebastian Harl wrote: > Hrm, just a guess, but could you please try to install some 2.10.x > version of lm-sensors and try again? Please also try the sensors command > again. I guess you can get a 2.10.x package from > http://snapshot.debian.net/. Tried version 2.10.5, sensors still works, collectd doesn't. dpkg -l | grep sensors ii ksensors 0.7.3-15 lm-sensors frontend for KDE ii libsensors-dev 1:2.10.5-3 lm-sensors development kit ii libsensors31:2.10.5-3 library to read temperature/voltage/fan sens rc libsensors41:3.0.1-4 library to read temperature/voltage/fan sens ii lm-sensors 1:2.10.5-2 utilities to read temperature/voltage/fan se $grep sensors /tmp/collectd.dbg [2008-04-16 10:12:14] type = sensors [2008-04-16 10:12:14] file = /usr/lib/collectd/sensors.so [2008-04-16 10:12:14] [thread #3055348624] plugin: plugin_read_thread: Handling sensors [2008-04-16 10:12:14] sensors plugin: sensors_load_conf: Ignoring subfeature `in0_min', because (feature->mapping != SENSORS_NO_MAPPING). [2008-04-16 10:12:14] sensors plugin: sensors_load_conf: Ignoring subfeature `in0_max', because (feature->mapping != SENSORS_NO_MAPPING). [2008-04-16 10:12:14] sensors plugin: sensors_load_conf: Ignoring subfeature `in1', because `sensors_get_ignored' told me so. [2008-04-16 10:12:14] sensors plugin: sensors_load_conf: Ignoring subfeature `in1_min', because (feature->mapping != SENSORS_NO_MAPPING). [2008-04-16 10:12:14] sensors plugin: sensors_load_conf: Ignoring subfeature `in1_max', because (feature->mapping != SENSORS_NO_MAPPING). [2008-04-16 10:12:14] sensors plugin: sensors_load_conf: Ignoring subfeature `in2_min', because (feature->mapping != SENSORS_NO_MAPPING). [2008-04-16 10:12:14] sensors plugin: sensors_load_conf: Ignoring subfeature `in2_max', because (feature->mapping != SENSORS_NO_MAPPING). [2008-04-16 10:12:14] sensors plugin: sensors_load_conf: Ignoring subfeature `in3_min', because (feature->mapping != SENSORS_NO_MAPPING). [2008-04-16 10:12:14] sensors plugin: sensors_load_conf: Ignoring subfeature `in3_max', because (feature->mapping != SENSORS_NO_MAPPING). [2008-04-16 10:12:14] sensors plugin: sensors_load_conf: Ignoring subfeature `in4_min', because (feature->mapping != SENSORS_NO_MAPPING). [2008-04-16 10:12:14] sensors plugin: sensors_load_conf: Ignoring subfeature `in4_max', because (feature->mapping != SENSORS_NO_MAPPING). [2008-04-16 10:12:14] sensors plugin: sensors_load_conf: Ignoring subfeature `in5_min', because (feature->mapping != SENSORS_NO_MAPPING). [2008-04-16 10:12:14] sensors plugin: sensors_load_conf: Ignoring subfeature `in5_max', because (feature->mapping != SENSORS_NO_MAPPING). [2008-04-16 10:12:14] sensors plugin: sensors_load_conf: Ignoring subfeature `in6_min', because (feature->mapping != SENSORS_NO_MAPPING). [2008-04-16 10:12:14] sensors plugin: sensors_load_conf: Ignoring subfeature `in6_max', because (feature->mapping != SENSORS_NO_MAPPING). [2008-04-16 10:12:14] sensors plugin: sensors_load_conf: Ignoring subfeature `fan1_min', because (feature->mapping != SENSORS_NO_MAPPING). [2008-04-16 10:12:14] sensors plugin: sensors_load_conf: Ignoring subfeature `fan1_div', because (feature->mapping != SENSORS_NO_MAPPING). [2008-04-16 10:12:14] sensors plugin: sensors_load_conf: Ignoring subfeature `fan2_min', because (feature->mapping != SENSORS_NO_MAPPING). [2008-04-16 10:12:14] sensors plugin: sensors_load_conf: Ignoring subfeature `fan2_div', because (feature->mapping != SENSORS_NO_MAPPING). [2008-04-16 10:12:14] sensors plugin: sensors_load_conf: Ignoring subfeature `fan3_min', because (feature->mapping != SENSORS_NO_MAPPING). [2008-04-16 10:12:14] sensors plugin: sensors_load_conf: Ignoring subfeature `fan3_div', because (feature->mapping != SENSORS_NO_MAPPING). [2008-04-16 10:12:14] sensors plugin: sensors_load_conf: Ignoring subfeature `temp1_over', because (feature->mapping != SENSORS_NO_MAPPING). [2008-04-16 10:12:14] sensors plugin: sensors_load_conf: Ignoring subfeature `temp1_hyst', because (feature->mapping != SENSORS_NO_MAPPING). [2008-04-16 10:12:14] sensors plugin: sensors_load_conf: Ignoring subfeature `temp2_over', because (feature->mapping != SENSORS_NO_MAPPING). [2008-04-16 10:12:14] sensors plugin: sensors_load_conf: Ignoring subfeature `temp2_hyst', because (feature->mapping != SENSORS_NO_MAPPING). [2008-04-16 10:12:14] sensors plugin: sensors_load_conf: Ignoring subfeature `temp3_over', because (feature->mapping != SENSORS_NO_MAPPING). [2008-04-16 10:12:14] sensors plugin: sensors_load_conf: Ignoring subfeature `temp3_hyst', because (feature->mapping != SENSORS_NO_MAPPING). [2008-04-16 10:12:14] sensors plugin: se
Bug#468143: collectd: sensors plugin stopped working after upgrade
Hi, On Wed, Apr 16, 2008 at 10:05:35AM +0200, Alex wrote: > unfortunately, the updated packages doesn't change anything. Still no sensor > data logged. :-/ > There are also multiple versions of libsensors used on my system, as the > fixes had to do with bugs in libsensors[34], this might be relevant > although sensors (libsensors4) and ksensors (libsensors3) both work > correctly, whereas collectd (libsensors3) doesn't. Hrm, just a guess, but could you please try to install some 2.10.x version of lm-sensors and try again? Please also try the sensors command again. I guess you can get a 2.10.x package from http://snapshot.debian.net/. TIA, Sebastian -- Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/ Those who would give up Essential Liberty to purchase a little Temporary Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin signature.asc Description: Digital signature
Bug#468143: collectd: sensors plugin stopped working after upgrade
Hello, unfortunately, the updated packages doesn't change anything. Still no sensor data logged. There are also multiple versions of libsensors used on my system, as the fixes had to do with bugs in libsensors[34], this might be relevant although sensors (libsensors4) and ksensors (libsensors3) both work correctly, whereas collectd (libsensors3) doesn't. ldd /usr/bin/sensors linux-gate.so.1 => (0xb7f8c000) libsensors.so.4 => /usr/lib/libsensors.so.4 (0xb7f68000) libc.so.6 => /lib/i686/cmov/libc.so.6 (0xb7e1a000) libm.so.6 => /lib/i686/cmov/libm.so.6 (0xb7df5000) /lib/ld-linux.so.2 (0xb7f8d000) ldd /usr/lib/collectd/sensors.so linux-gate.so.1 => (0xb7f85000) libsensors.so.3 => /usr/lib/libsensors.so.3 (0xb7f34000) libc.so.6 => /lib/i686/cmov/libc.so.6 (0xb7de6000) libm.so.6 => /lib/i686/cmov/libm.so.6 (0xb7dc1000) libsysfs.so.2 => /lib/libsysfs.so.2 (0xb7db7000) /lib/ld-linux.so.2 (0x8000) ldd /usr/bin/ksensors linux-gate.so.1 => (0xb7f26000) libkdeui.so.4 => /usr/lib/libkdeui.so.4 (0xb7c25000) libkdecore.so.4 => /usr/lib/libkdecore.so.4 (0xb79e2000) libsensors.so.3 => /usr/lib/libsensors.so.3 (0xb79ac000) libstdc++.so.6 => /usr/lib/libstdc++.so.6 (0xb78bf000) Alex. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#468143: collectd: sensors plugin stopped working after upgrade
On Wednesday 27 February 2008, Sebastian Harl wrote: > Could you please set the debug level to "info" and check if any messages > turn up in syslog? I currently have no idea what this might be caused by > but I will have a closer look at it soonish. It already is. Collectd is completely silent, except for a message at shutdown. LogLevel info Feb 28 07:27:14 waxy collectd[29639]: Exiting normally Feb 28 07:27:14 waxy collectdmon[29638]: Info: collectd terminated with exit status 0 Feb 28 07:27:14 waxy collectdmon[29638]: Info: shutting down collectdmon Alex. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#468143: collectd: sensors plugin stopped working after upgrade
Hi Alex, On Wed, Feb 27, 2008 at 11:13:10AM +0100, Alex Hermann wrote: > After the upgrade of collectd from 4.2.1-1 to 4.3.0-1, the sensors plugin > fails to collect data. No messages in syslog or anywhere else. The sensors > command-line utility still shows all values: Could you please set the debug level to "info" and check if any messages turn up in syslog? I currently have no idea what this might be caused by but I will have a closer look at it soonish. Thanks for reporting this. Cheers, Sebastian -- Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/ Those who would give up Essential Liberty to purchase a little Temporary Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin signature.asc Description: Digital signature
Bug#468143: collectd: sensors plugin stopped working after upgrade
Package: collectd Version: 4.3.0-1 Severity: normal After the upgrade of collectd from 4.2.1-1 to 4.3.0-1, the sensors plugin fails to collect data. No messages in syslog or anywhere else. The sensors command-line utility still shows all values: $ sensors asb100-i2c-1-2d Adapter: SMBus nForce2 adapter at 5500 VCore 1: +1.70 V (min = +1.31 V, max = +1.97 V) +3.3V:+3.33 V (min = +2.96 V, max = +3.63 V) +5V: +5.00 V (min = +4.49 V, max = +5.51 V) +12V:+11.61 V (min = +9.55 V, max = +14.41 V) -12V (reserved): -12.13 V (min = -0.00 V, max = -0.00 V) -5V (reserved): -5.06 V (min = -0.00 V, max = -0.00 V) CPU Fan: 3609 RPM (min = -1 RPM, div = 2) Chassis Fan:0 RPM (min = -1 RPM, div = 2) Power Fan: 0 RPM (min = -1 RPM, div = 2) M/B Temp: +43.0°C (high = +80.0°C, hyst = +75.0°C) CPU Temp (Intel): +26.0°C (high = +80.0°C, hyst = +75.0°C) Power Temp: +126.0°C (high = +80.0°C, hyst = +75.0°C) CPU Temp (AMD): +25.0°C (high = +80.0°C, hyst = +75.0°C) cpu0_vid:+1.650 V There is no configuration for the sensors plugin, so it should collect data from all sensors. -- System Information: Debian Release: lenny/sid APT prefers unstable APT policy: (500, 'unstable'), (10, 'experimental') Architecture: i386 (i686) Kernel: Linux 2.6.23.12-cfs-v24.1-server (PREEMPT) Locale: LANG=en_US.UTF-8, LC_CTYPE=nl_NL.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages collectd depends on: ii debconf [debconf-2.0] 1.5.19 Debian configuration management sy ii libc6 2.7-8 GNU C Library: Shared libraries ii librrd2 1.2.27-1 Time-series data storage and displ Versions of packages collectd recommends: ii libcurl3-gnutls 7.18.0-1 Multi-protocol file transfer libra ii libdbus-1-3 1.1.4-1simple interprocess messaging syst ii libhal1 0.5.10-5 Hardware Abstraction Layer - share ii libkrb53 1.6.dfsg.3~beta1-3 MIT Kerberos runtime libraries ii libmysqlclient15off 5.0.51a-3 MySQL database client library ii liboping0 0.3.5-1C/C++ library to generate ICMP_ECH ii libpcap0.80.9.8-2System interface for user-level pa ii libperl5.85.8.8-12 Shared Perl library ii libsensors3 1:2.10.5-5 library to read temperature/voltag ii libsnmp15 5.4.1~dfsg-6 SNMP (Simple Network Management Pr ii libvirt0 0.4.0-5library for interfacing with diffe ii libxml2 2.6.31.dfsg-1 GNOME XML library ii perl 5.8.8-12 Larry Wall's Practical Extraction ii rrdtool 1.2.27-1 Time-series data storage and displ -- debconf information: * collectd/auto-migrate-3-4: false * collectd/migration-3-4: -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
