Bug#477791: grub: Wrong splash image path construction

[Petter Reinholdtsen]

I ran into this problem too in Debian Edu, with / and /boot/ on
separate partisions.  /boot is /dev/hda1, and / is on LVM
(/dev/mapper/vg_system-root).  In this setting, update-grub generate

  splashimage=(hd0,0)boot/grub/splash.xpm.gz

The correct setting would be

  splashimage=(hd0,0)/grub/splash.xpm.gz

This make it very hard to provide a grub splash screen automatically
during installation.  I was working on updating the debian-edu-artwork
package to provide this, but the current result is a error during boot
about being unable to read the splash image.

Happy hacking,
-- 
Petter Reinholdtsen



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#477791: grub: Wrong splash image path construction

[Petter Reinholdtsen]

tags 477791 + patch
thanks

This patch solve the issue, but making sure to use the path to
/boot/grub/ relative to the grub root partition, in this case
/boot/, making the splashimage entry show up as
(hd0,0)/grub/splash.xpm.gz.

diff -u grub-0.97/debian/update-grub grub-0.97/debian/update-grub
--- grub-0.97/debian/update-grub
+++ grub-0.97/debian/update-grub
@@ -755,7 +755,8 @@

 echo -n Searching for splash image ...  2
 current_splash=`grep '^splashimage=' ${menu_file} || true`
-splashimage_path=splashimage=${grub_root_device}${grub_dir##${kernel_dir}}/splash.xpm.gz
+grub_dir_rel=`make_system_path_relative_to_its_root $grub_dir`
+splashimage_path=splashimage=${grub_root_device}/${grub_dir_rel##${kernel_dir}}/splash.xpm.gz
 if [ `sed -e /^$start/,/^$end/d $menu_file | grep -c '^splashimage='` != 0 
] ; then
#checks for splashscreen defined outside the autoupdated part
splashimage=$(grep '^splashimage=' ${menu_file})

Please get this fix into Lenny.

Happy hacking,
-- 
Petter Reinholdtsen



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#477791: grub: Wrong splash image path construction

[Roland Stigge]

Package: grub
Version: 0.97-36
Severity: normal

Hi,

in /usr/sbin/update-grub:721, we have:

splashimage_path=splashimage=${grub_root_device}${grub_dir##${kernel_dir}}/splash.xpm.gz

with

grub_root_device=(hd0,2)
grub_dir=/boot/grub
kernel_dir=/boot

this results in:

splashimage=(hd0,2)/grub/splash.xpm.gz

Which is not correct because as seen above, I have /boot as a
subdirectory on the boot device (hd0,2), not as a separate partition.

Thanks for considering,

Roland

-- Package-specific info:

*** BEGIN /proc/mounts
/dev/hda3 / ext3 rw,errors=remount-ro,commit=5,data=ordered 0 0
/dev/hda3 /dev/.static/dev ext3 rw,errors=remount-ro,commit=5,data=ordered 0 0
/dev/hda2 /mnt/windows ntfs 
ro,uid=0,gid=0,fmask=0177,dmask=077,nls=iso8859-1,errors=continue,mft_zone_multiplier=1
 0 0
*** END /proc/mounts

*** BEGIN /proc/mounts
rootfs / rootfs rw 0 0
none /sys sysfs rw,nosuid,nodev,noexec 0 0
none /proc proc rw,nosuid,nodev,noexec 0 0
udev /dev tmpfs rw 0 0
/dev/hda3 / ext3 rw,errors=remount-ro,commit=5,data=ordered 0 0
/dev/hda3 /dev/.static/dev ext3 rw,errors=remount-ro,commit=5,data=ordered 0 0
tmpfs /lib/init/rw tmpfs rw,nosuid 0 0
usbfs /proc/bus/usb usbfs rw,nosuid,nodev,noexec 0 0
tmpfs /dev/shm tmpfs rw,nosuid,nodev 0 0
devpts /dev/pts devpts rw,nosuid,noexec 0 0
/dev/hda2 /mnt/windows ntfs 
ro,uid=0,gid=0,fmask=0177,dmask=077,nls=iso8859-1,errors=continue,mft_zone_multiplier=1
 0 0
rpc_pipefs /var/lib/nfs/rpc_pipefs rpc_pipefs rw 0 0
nfsd /proc/fs/nfsd nfsd rw 0 0
binfmt_misc /proc/sys/fs/binfmt_misc binfmt_misc rw,nosuid,nodev,noexec 0 0
*** END /proc/mounts

*** BEGIN /proc/mounts

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.24-rt1 (SMP w/1 CPU core; PREEMPT)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) (ignored: LC_ALL 
set to en_GB.UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages grub depends on:
ii  grub-common  1.96+20080413-1 GRand Unified Bootloader, version 
ii  libc62.7-10  GNU C Library: Shared libraries
ii  libncurses5  5.6+20080405-1  Shared libraries for terminal hand

grub recommends no packages.

-- debconf-show failed



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]