Bug#482456: [Buildd-tools-devel] Bug#482456: sbuild: Build package with epoch in a directory name containing a colon, leading make to fail

2008-05-25 Thread Roger Leigh
tags 482456 + confirmed patch fixed-upstream pending
thanks

Raphael Hertzog [EMAIL PROTECTED] writes:

 When you implemented the change to give explicitely the directory in which
 to unpack the source package, you included the full version in the name of
 that directory... however quite a few packages have epochs and their
 version contains a colon. When you put a filename with a colon
 as a dependency of some make target, it can lead to strange failures
 with messages *** multiple target patterns.  Stop..

The version numbers now have the epoch stripped out.

Committed patch:
http://git.debian.org/?p=buildd-tools/sbuild.git;a=commitdiff;h=33e6557fe539d004c3568e4ba58b0d47183227cc


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


pgpvmuT4xWOKn.pgp
Description: PGP signature


Bug#482456: [Buildd-tools-devel] Bug#482456: sbuild: Build package with epoch in a directory name containing a colon, leading make to fail

2008-05-23 Thread Roger Leigh
Raphael Hertzog [EMAIL PROTECTED] writes:

 On Thu, 22 May 2008, Raphael Hertzog wrote:
 When you implemented the change to give explicitely the directory in which
 to unpack the source package, you included the full version in the name of
 that directory...

 I might be mistaken as I just noticed that the colon is not the in the
 directory name corresponding to the top of the source package but higher
 in the hierarchy:
 make[1]: Entering directory 
 `/build/user-enigmail_2:0.95.0+1-3.1-amd64-eHJUfP/enigmail_0.95.0+1-3.1'

 So it might be a problem that affects only lucas's rebuild infrastructure.
 Not sure, I will wait his input.

I'll fix up both cases.  I'll remove the epoch from the first and
format the version exactly as dpkg-source expects it in the second.


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


pgpEoCM881P5U.pgp
Description: PGP signature


Bug#482456: sbuild: Build package with epoch in a directory name containing a colon, leading make to fail

2008-05-22 Thread Raphael Hertzog
Package: sbuild
Version: 0.57.3-1
Severity: important

When you implemented the change to give explicitely the directory in which
to unpack the source package, you included the full version in the name of
that directory... however quite a few packages have epochs and their
version contains a colon. When you put a filename with a colon
as a dependency of some make target, it can lead to strange failures
with messages *** multiple target patterns.  Stop..

See for example the enigmail package:
[...]
 /usr/bin/fakeroot debian/rules clean
make -f 
/build/user-enigmail_2:0.95.0+1-3.1-amd64-eHJUfP/enigmail_0.95.0+1-3.1/debian/rules.thunderbird
 MOZ_APP_NAME=icedove clean
make[1]: Entering directory 
`/build/user-enigmail_2:0.95.0+1-3.1-amd64-eHJUfP/enigmail_0.95.0+1-3.1'
/build/user-enigmail_2:0.95.0+1-3.1-amd64-eHJUfP/enigmail_0.95.0+1-3.1/debian/rules.thunderbird:56:
 *** multiple target patterns.  Stop.
make[1]: Leaving directory 
`/build/user-enigmail_2:0.95.0+1-3.1-amd64-eHJUfP/enigmail_0.95.0+1-3.1'
make: *** [clean] Error 2
dpkg-buildpackage: failure: /usr/bin/fakeroot debian/rules clean gave error 
exit status 2
**

This is a fairly important regression, it affects at least 28 source packages.
Please choose a directory name with the version stripped from its epoch. Ideally
you would use the official name source-upstream so that you also avoid
the warnings that appear in some cases:
dpkg-source: warning: .orig directory name xjump_2.7.5-4.orig is not 
package-upstreamversion (wanted xjump-2.7.5.orig)

Cheers,
-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 
'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.24-1-686 (SMP w/1 CPU core)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages sbuild depends on:
ii  adduser   3.107  add and remove users and groups
ii  apt   0.7.12 Advanced front-end for dpkg
ii  dctrl-tools   2.12   Command-line tools to process Debi
ii  devscripts2.10.28scripts to make the life of a Debi
ii  dpkg-dev  1.14.19package building tools for Debian
ii  perl  5.10.0-10  Larry Wall's Practical Extraction 
ii  perl-modules  5.10.0-10  Core Perl modules
ii  postfix [mail-transport-agent 2.5.2-0High-performance mail transport ag
ii  schroot   1.2.0-1Execute commands in a chroot envir

Versions of packages sbuild recommends:
ii  debootstrap   1.0.9  Bootstrap a basic Debian system
ii  fakeroot  1.9.5  Gives a fake root environment

-- no debconf information



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#482456: sbuild: Build package with epoch in a directory name containing a colon, leading make to fail)

2008-05-22 Thread Raphael Hertzog
For reference, it also leads to many failures with *** target pattern
contains no `%'.  Stop. (there are 40 of those, so it's around 70
FTBFS due to that already, at least for lucas since he uses the packaged
sbuild)

Cheers,
-- 
Raphaël Hertzog

Le best-seller français mis à jour pour Debian Etch :
http://www.ouaza.com/livre/admin-debian/



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#482456: sbuild: Build package with epoch in a directory name containing a colon, leading make to fail

2008-05-22 Thread Raphael Hertzog
On Thu, 22 May 2008, Raphael Hertzog wrote:
 When you implemented the change to give explicitely the directory in which
 to unpack the source package, you included the full version in the name of
 that directory...

I might be mistaken as I just noticed that the colon is not the in the
directory name corresponding to the top of the source package but higher
in the hierarchy:
 make[1]: Entering directory 
 `/build/user-enigmail_2:0.95.0+1-3.1-amd64-eHJUfP/enigmail_0.95.0+1-3.1'

So it might be a problem that affects only lucas's rebuild infrastructure.
Not sure, I will wait his input.

Cheers,
-- 
Raphaël Hertzog

Le best-seller français mis à jour pour Debian Etch :
http://www.ouaza.com/livre/admin-debian/



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]