Bug#482952: yakuake: Move tab left/right hotkey moves the previous visited tab
Hi, On Fri, Apr 24, 2009 at 07:59:48AM +0100, jrw wrote: On Wed, Apr 22, 2009 at 11:20 AM, Ana Guerrero a...@debian.org wrote: On Tue, Apr 21, 2009 at 07:43:36PM +0100, jrw wrote: Tags: patch I completely forgot about this bug, sorry :) Maybe it's too obsolete now... This patch changes the name of a bunch of variables (kde code is hard to understand), adds docs, and (to actually fix the bug), adds a signal itemSelected - slotResetAffect... This resets the affect position pointer every time we select a new view so operations happen on the new view until the user makes a new right click. I also removed some calls to the reset function which are redundant now. This also fixes moving a tab after moving *to* a different tab using shift+arrow which I didn't notice in the original report. I forgot about it too, so.. :) Current yakuake version is 2.9.4 made to work with KDE 4.2 in unstable, did you made the patch against the KDE 3 version of the current KDE 4 one? FWIW, I can not reproduce your problem in current KDE 4 from unstable. Ana The patch is against the kde3 version 2.8.1-1. I don't really want to install all of kde4 to test this bug is fixed; it's a 100mb download and I'm still a bit nervous about losing the functions I rely on currently ;). I understand, it is a huge change. Just in case I wasn't exact enough, here is a precise sequence which triggers the bug: - open yakuake - open a new terminal - click on the first terminal - open a new terminal - ctrl+shift left - nothing happens (it's trying to move terminal #1 left) - ctrl+shift left again - now the current terminal moves No, i have not been unable to trigger this in kde4's yakuake. If it is fixed... well, no harm I guess, but it would be nice to see a 2.8.1-2 for the kde3 holdouts (or perhaps even yakuake-kde3 package?). We are not keeping KDE 3 in the archive, so there is not much point in keeping the kde3 apps. They will go dissappearing little to little. Ana -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#482952: yakuake: Move tab left/right hotkey moves the previous visited tab
On Wed, Apr 22, 2009 at 11:20 AM, Ana Guerrero a...@debian.org wrote: On Tue, Apr 21, 2009 at 07:43:36PM +0100, jrw wrote: Tags: patch I completely forgot about this bug, sorry :) Maybe it's too obsolete now... This patch changes the name of a bunch of variables (kde code is hard to understand), adds docs, and (to actually fix the bug), adds a signal itemSelected - slotResetAffect... This resets the affect position pointer every time we select a new view so operations happen on the new view until the user makes a new right click. I also removed some calls to the reset function which are redundant now. This also fixes moving a tab after moving *to* a different tab using shift+arrow which I didn't notice in the original report. I forgot about it too, so.. :) Current yakuake version is 2.9.4 made to work with KDE 4.2 in unstable, did you made the patch against the KDE 3 version of the current KDE 4 one? FWIW, I can not reproduce your problem in current KDE 4 from unstable. Ana The patch is against the kde3 version 2.8.1-1. I don't really want to install all of kde4 to test this bug is fixed; it's a 100mb download and I'm still a bit nervous about losing the functions I rely on currently ;). Just in case I wasn't exact enough, here is a precise sequence which triggers the bug: - open yakuake - open a new terminal - click on the first terminal - open a new terminal - ctrl+shift left - nothing happens (it's trying to move terminal #1 left) - ctrl+shift left again - now the current terminal moves If it is fixed... well, no harm I guess, but it would be nice to see a 2.8.1-2 for the kde3 holdouts (or perhaps even yakuake-kde3 package?). Thanks for your attention. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#482952: yakuake: Move tab left/right hotkey moves the previous visited tab
On Tue, Apr 21, 2009 at 07:43:36PM +0100, jrw wrote: Tags: patch I completely forgot about this bug, sorry :) Maybe it's too obsolete now... This patch changes the name of a bunch of variables (kde code is hard to understand), adds docs, and (to actually fix the bug), adds a signal itemSelected - slotResetAffect... This resets the affect position pointer every time we select a new view so operations happen on the new view until the user makes a new right click. I also removed some calls to the reset function which are redundant now. This also fixes moving a tab after moving *to* a different tab using shift+arrow which I didn't notice in the original report. I forgot about it too, so.. :) Current yakuake version is 2.9.4 made to work with KDE 4.2 in unstable, did you made the patch against the KDE 3 version of the current KDE 4 one? FWIW, I can not reproduce your problem in current KDE 4 from unstable. Ana -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#482952: yakuake: Move tab left/right hotkey moves the previous visited tab
Tags: patch
I completely forgot about this bug, sorry :) Maybe it's too obsolete now...
This patch changes the name of a bunch of variables (kde code is hard
to understand), adds docs, and (to actually fix the bug), adds a
signal itemSelected - slotResetAffect... This resets the affect
position pointer every time we select a new view so operations happen
on the new view until the user makes a new right click. I also
removed some calls to the reset function which are redundant now.
This also fixes moving a tab after moving *to* a different tab using
shift+arrow which I didn't notice in the original report.
diff --git a/yakuake/src/main_window.cpp b/yakuake/src/main_window.cpp
index 7a15bde..62e8703 100644
--- a/yakuake/src/main_window.cpp
+++ b/yakuake/src/main_window.cpp
@@ -380,10 +380,9 @@ void MainWindow::slotRemoveSession(int session_id)
void MainWindow::slotHandleRemoveSession(KAction::ActivationReason reason, Qt::ButtonState /* state */)
{
if (reason == KAction::PopupMenuActivation
- tab_bar-pressedPosition() != -1)
+ tab_bar-affectPosition() != -1)
{
-slotRemoveSession(tab_bar-sessionIdForTabPosition(tab_bar-pressedPosition()));
-tab_bar-resetPressedPosition();
+slotRemoveSession(tab_bar-sessionIdForTabPosition(tab_bar-affectPosition()));
}
else
slotRemoveSession();
@@ -653,10 +652,9 @@ void MainWindow::windowActivationChange(bool old_active)
void MainWindow::slotHandleHorizontalSplit(KAction::ActivationReason reason, Qt::ButtonState /* state */)
{
if (reason == KAction::PopupMenuActivation
- tab_bar-pressedPosition() != -1)
+ tab_bar-affectPosition() != -1)
{
-slotSplitHorizontally(tab_bar-sessionIdForTabPosition(tab_bar-pressedPosition()));
-tab_bar-resetPressedPosition();
+slotSplitHorizontally(tab_bar-sessionIdForTabPosition(tab_bar-affectPosition()));
}
else
slotSplitHorizontally();
@@ -665,10 +663,9 @@ void MainWindow::slotHandleHorizontalSplit(KAction::ActivationReason reason, Qt:
void MainWindow::slotHandleVerticalSplit(KAction::ActivationReason reason, Qt::ButtonState /* state */)
{
if (reason == KAction::PopupMenuActivation
- tab_bar-pressedPosition() != -1)
+ tab_bar-affectPosition() != -1)
{
-slotSplitVertically(tab_bar-sessionIdForTabPosition(tab_bar-pressedPosition()));
-tab_bar-resetPressedPosition();
+slotSplitVertically(tab_bar-sessionIdForTabPosition(tab_bar-affectPosition()));
}
else
slotSplitVertically();
@@ -678,10 +675,9 @@ void MainWindow::slotHandleVerticalSplit(KAction::ActivationReason reason, Qt::B
void MainWindow::slotHandleRemoveTerminal(KAction::ActivationReason reason, Qt::ButtonState /* state */)
{
if (reason == KAction::PopupMenuActivation
- tab_bar-pressedPosition() != -1)
+ tab_bar-affectPosition() != -1)
{
-slotRemoveTerminal(tab_bar-sessionIdForTabPosition(tab_bar-pressedPosition()));
-tab_bar-resetPressedPosition();
+slotRemoveTerminal(tab_bar-sessionIdForTabPosition(tab_bar-affectPosition()));
}
else
slotRemoveTerminal();
@@ -1323,7 +1319,7 @@ void MainWindow::slotPollMouse()
if (pos.y() == 0)
{
-if (Settings::screen() == 0)
+if (Settings::screen() == 0)
slotToggleState(); // no need to check x since yakuake should open where the mouse pointer is
else if (pos.x() = getDesktopGeometry().x() pos.x() = (getDesktopGeometry().x() + getDesktopGeometry().width()))
slotToggleState();
diff --git a/yakuake/src/tab_bar.cpp b/yakuake/src/tab_bar.cpp
index 72347db..52aa26b 100644
--- a/yakuake/src/tab_bar.cpp
+++ b/yakuake/src/tab_bar.cpp
@@ -21,7 +21,6 @@
#include klocale.h
#include kpopupmenu.h
-
TabBar::TabBar(QWidget* parent, const char* name, bool translucency, const QString skin)
: TranslucentWidget(parent, name, translucency)
{
@@ -41,15 +40,9 @@ TabBar::~TabBar()
delete minus_button;
}
-int TabBar::pressedPosition()
-{
-return tabs_widget-pressedPosition();
-}
-
-
-void TabBar::resetPressedPosition()
+int TabBar::affectPosition()
{
-tabs_widget-resetPressedPosition();
+return tabs_widget-affectPosition();
}
void TabBar::addItem(int session_id)
diff --git a/yakuake/src/tab_bar.h b/yakuake/src/tab_bar.h
index 6e8f3a0..2e05449 100644
--- a/yakuake/src/tab_bar.h
+++ b/yakuake/src/tab_bar.h
@@ -41,8 +41,8 @@ class TabBar : public TranslucentWidget
void setSessionMenu(KPopupMenu* menu);
-int pressedPosition();
-void resetPressedPosition();
+int affectPosition();
+// void resetAffectPosition();
void addItem(int session_id);
int removeItem(int session_id);
diff --git a/yakuake/src/tabbed_widget.cpp b/yakuake/src/tabbed_widget.cpp
index c2b3961..46c4649 100644
--- a/yakuake/src/tabbed_widget.cpp
+++
Bug#482952: yakuake: Move tab left/right hotkey moves the previous visited tab
Package: yakuake Version: 2.8.1-1 Severity: normal Steps to reproduce: - have at least two tabs open (because the first tab cannot move left) - visit a tab that is not the first tab - create another new tab - press the left hotkey The tab you created the new shell from will be moved instead of the newly created one. Also works for the move tab right hotkey. Right clicking the desired tab and selecting `move session...' is not affected. Thank you. -- System Information: Debian Release: lenny/sid APT prefers testing APT policy: (500, 'testing') Architecture: i386 (i686) Kernel: Linux 2.6.24-1-686 (SMP w/1 CPU core) Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages yakuake depends on: ii kdelibs4c2a 4:3.5.9.dfsg.1-4core libraries and binaries for al ii konsole 4:3.5.9.dfsg.1-2+b1 X terminal emulator for KDE ii libc62.7-10 GNU C Library: Shared libraries ii libgcc1 1:4.3.0-3 GCC support library ii libqt3-mt3:3.3.8b-5 Qt GUI Library (Threaded runtime v ii libstdc++6 4.3.0-3 The GNU Standard C++ Library v3 yakuake recommends no packages. -- no debconf information -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
