Bug#486744: [epiphany-browser] Carsh when increeasing font size
On Sun, Sep 07, 2008 at 02:56:37PM +0100, Ben Hutchings wrote: I am able to reproduce this using Santiago's example. The crash occurs in nsCachedStyleData::GetStyleData(const nsStyleStructID aSID) which is inlined into nsRuleNode::GetStyleBackground(nsStyleContext* aContext, PRBool aComputeData) which is generated from the macro at layout/style/nsRuleNode.cpp:5070. The flow of control in GetStyleBackground() has passed the (disabled) assertion NS_NOTREACHED(could not create style struct); and continued to return static_castconst nsStyleBackground *( mPresContext-PresShell()-StyleSet()- DefaultStyleData()-GetStyleData(eStyleStruct_Background)); where mPresContext()-PresShell() has returned NULL. It seems to me that this nsPresContext has been destroyed. Perhaps Epiphany is doing something wrong with reference-counting of nsPresContext. No, that's not it. Putting breakpoints on the constructor and destructor shows me the following sequence of events: nsPresContext constructed at 0x9d6c958 begin loading nsPresContext constructed at 0x9e92ea8 nsPresContext destroyed at 0x9d6c958 end loading begin zoom crash mPresContext points to 0xa35edf4 gdb is being extremely uncooperative, so I'm going to take a break from investigating this now. Ben. -- Ben Hutchings Design a system any fool can use, and only a fool will want to use it. signature.asc Description: Digital signature
Bug#486744: [epiphany-browser] Carsh when increeasing font size
On Sun, Sep 07, 2008 at 04:23:16PM +0100, Ben Hutchings wrote: On Sun, Sep 07, 2008 at 02:56:37PM +0100, Ben Hutchings wrote: I am able to reproduce this using Santiago's example. The crash occurs in nsCachedStyleData::GetStyleData(const nsStyleStructID aSID) which is inlined into nsRuleNode::GetStyleBackground(nsStyleContext* aContext, PRBool aComputeData) which is generated from the macro at layout/style/nsRuleNode.cpp:5070. The flow of control in GetStyleBackground() has passed the (disabled) assertion NS_NOTREACHED(could not create style struct); and continued to return static_castconst nsStyleBackground *( mPresContext-PresShell()-StyleSet()- DefaultStyleData()-GetStyleData(eStyleStruct_Background)); where mPresContext()-PresShell() has returned NULL. It seems to me that this nsPresContext has been destroyed. Perhaps Epiphany is doing something wrong with reference-counting of nsPresContext. No, that's not it. Putting breakpoints on the constructor and destructor shows me the following sequence of events: nsPresContext constructed at 0x9d6c958 begin loading nsPresContext constructed at 0x9e92ea8 nsPresContext destroyed at 0x9d6c958 end loading begin zoom crash mPresContext points to 0xa35edf4 gdb is being extremely uncooperative, so I'm going to take a break from investigating this now. Maybe removing /usr/lib/xulrunner-1.9/dependentlibs.list can help. Mike -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#486744: [epiphany-browser] Carsh when increeasing font size
On Sun, Jul 06, 2008 at 01:03:54PM +0200, Mike Hommey wrote:
On Sun, Jul 06, 2008 at 12:42:01PM +0200, Andreas Barth wrote:
Hi,
* Mike Hommey ([EMAIL PROTECTED]) [080706 10:41]:
On Fri, Jun 20, 2008 at 11:28:05AM +0200, Alexander Sack [EMAIL
PROTECTED] wrote:
On Fri, Jun 20, 2008 at 01:07:09AM +0200, Mike Hommey wrote:
On Fri, Jun 20, 2008 at 12:43:04AM +0200, Mike Hommey wrote:
On Fri, Jun 20, 2008 at 12:38:52AM +0200, Mike Hommey wrote:
On Wed, Jun 18, 2008 at 12:48:42AM +0200, Josselin Mouette wrote:
Le mercredi 18 juin 2008 à 00:18 +0200, Mazen NEIFER a écrit :
Browse
http://aljazeera.net/NR/exeres/8BAC4176-2B16-450F-B8DA-7127702A17AF.htm
and try to increase font size and it will crash.
This is indeed reproducible. Interestingly enough, a very
similar bug
happens in devhelp when trying to increase the font size.
I???m attaching a full backtrace with debugging symbols.
Interestingly, while I can reproduce with epiphany, I can't with
iceweasel. Some values of the zoom factor may be triggering this
issue...
FWIW, iceweasel is setting zoom factor to 1.1, 1.2, 1.3, ...
I tried some less intriguing values for zoom factors in epiphany, and
it
didn't change anything. It still crashes.
We had this zoom crash here _before_ respinning epiphany-browser on
top of the final xulrunner Are you sure its a fresh build?
I build it myself yesterday. Though not against final xulrunner, but rc2,
which is the same.
Any news on this bug? Does it still happen? How bad is it, should it
block testing migration?
It still happens reliably for me with the given url, though it doesn't
happen with other urls. So I would say it is not /that/ bad.
Now, I got to the point where I don't know where the bug is anymore...
I roughly duplicated epiphany code for zoom handling in the gtkembed
test in xulrunner (in case it would make a difference whether the zoom
API is called from javascript or C) and... it doesn't crash...
Attached, you'll find a patch for this test. If you want to try for
yourself, apply it to current xulrunner source, run debian/rules build,
then make -C embedding/browser/gtk/tests, and finally,
dist/bin/run-mozilla.sh embedding/browser/gtk/tests/TestGtkEmbed
Then go to the aljazeera.net url, and click on zoom (you can click
several times, but not too many times, there is no failsafe)
Mike
diff --git a/embedding/browser/gtk/tests/Makefile.in
b/embedding/browser/gtk/tests/Makefile.in
index 9eb984a..984e4b0 100644
--- a/embedding/browser/gtk/tests/Makefile.in
+++ b/embedding/browser/gtk/tests/Makefile.in
@@ -46,6 +46,7 @@ include $(DEPTH)/config/autoconf.mk
MODULE = gtkembedmoz
REQUIRES = xpcom \
dom \
+ docshell \
$(NULL)
CPPSRCS = \
diff --git a/embedding/browser/gtk/tests/TestGtkEmbed.cpp
b/embedding/browser/gtk/tests/TestGtkEmbed.cpp
index 3c7223d..8170aaf 100644
--- a/embedding/browser/gtk/tests/TestGtkEmbed.cpp
+++ b/embedding/browser/gtk/tests/TestGtkEmbed.cpp
@@ -51,6 +51,11 @@
#include nsServiceManagerUtils.h
#include nsIObserverService.h
+#include nsIInterfaceRequestorUtils.h
+#include nsIDocShell.h
+#include nsIContentViewer.h
+#include nsIMarkupDocumentViewer.h
+
#include nsStringAPI.h
#include gtkmozembed_glue.cpp
@@ -71,6 +76,7 @@ typedef struct _TestGtkBrowser {
GtkWidget *stopButton;
GtkWidget *forwardButton;
GtkWidget *reloadButton;
+ GtkWidget *zoomButton;
GtkWidget *urlEntry;
GtkWidget *mozEmbed;
GtkWidget *progressAreaHBox;
@@ -107,6 +113,8 @@ static void forward_clicked_cb (GtkButton *button,
TestGtkBrowser *browser);
static void reload_clicked_cb (GtkButton *button,
TestGtkBrowser *browser);
+static void zoom_clicked_cb(GtkButton *button,
+ TestGtkBrowser *browser);
static void url_activate_cb(GtkEditable *widget,
TestGtkBrowser *browser);
static void menu_open_new_cb (GtkMenuItem *menuitem,
@@ -221,6 +229,12 @@ main(int argc, char **argv)
return 1;
}
+ rv = GTKEmbedGlueStartupInternal();
+ if (NS_FAILED(rv)) {
+fprintf(stderr, Couldn't find GTKMozEmbed symbols.);
+return 1;
+ }
+
char *lastSlash = strrchr(xpcomPath, '/');
if (lastSlash)
*lastSlash = '\0';
@@ -416,6 +430,16 @@ new_gtk_browser(guint32 chromeMask)
0, // XXX replace with icon
GTK_SIGNAL_FUNC(reload_clicked_cb),
browser);
+
+ // new zoom button
+ browser-zoomButton =
+gtk_toolbar_append_item(GTK_TOOLBAR(browser-toolbar),
+ Zoom,
+ Zoom,
+
Bug#486744: [epiphany-browser] Carsh when increeasing font size
On Sat, Jul 12, 2008 at 09:55:28AM +0200, Mike Hommey wrote: Now, I got to the point where I don't know where the bug is anymore... I roughly duplicated epiphany code for zoom handling in the gtkembed test in xulrunner (in case it would make a difference whether the zoom API is called from javascript or C) and... it doesn't crash... Attached, you'll find a patch for this test. If you want to try for yourself, apply it to current xulrunner source, run debian/rules build, then make -C embedding/browser/gtk/tests, and finally, dist/bin/run-mozilla.sh embedding/browser/gtk/tests/TestGtkEmbed Then go to the aljazeera.net url, and click on zoom (you can click several times, but not too many times, there is no failsafe) I could reproduce with galeon, though it doesn't happen as reliably as with epiphany. Even stranger, if you run galeon with a new user (no $HOME/.* directories around), then it *doesn't* crash. Then you restart galeon (so, after some $HOME/.* directories were created), then it *does* crash. Epiphany, OTOH, crashes even when $HOME is empty. Mike -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#486744: [epiphany-browser] Carsh when increeasing font size
On Fri, Jun 20, 2008 at 11:28:05AM +0200, Alexander Sack wrote: On Fri, Jun 20, 2008 at 01:07:09AM +0200, Mike Hommey wrote: On Fri, Jun 20, 2008 at 12:43:04AM +0200, Mike Hommey wrote: On Fri, Jun 20, 2008 at 12:38:52AM +0200, Mike Hommey wrote: On Wed, Jun 18, 2008 at 12:48:42AM +0200, Josselin Mouette wrote: reassign 486744 xulrunner-1.9 1.9~rc2-3 thanks Le mercredi 18 juin 2008 à 00:18 +0200, Mazen NEIFER a écrit : Package: epiphany-browser Version: 2.22.2-2 Severity: serious --- Please enter the report below this line. --- Browse http://aljazeera.net/NR/exeres/8BAC4176-2B16-450F-B8DA-7127702A17AF.htm and try to increase font size and it will crash. This is indeed reproducible. Interestingly enough, a very similar bug happens in devhelp when trying to increase the font size. I’m attaching a full backtrace with debugging symbols. Interestingly, while I can reproduce with epiphany, I can't with iceweasel. Some values of the zoom factor may be triggering this issue... FWIW, iceweasel is setting zoom factor to 1.1, 1.2, 1.3, ... I tried some less intriguing values for zoom factors in epiphany, and it didn't change anything. It still crashes. We had this zoom crash here _before_ respinning epiphany-browser on top of the final xulrunner Are you sure its a fresh build? You still have this zoom crash: I just tried the ubuntu-8.04.1-desktop-i386.iso livecd, installed epiphany-browser in it, went to the given url, zoomed in, and boom. Mike -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#486744: [epiphany-browser] Carsh when increeasing font size
Hi, * Mike Hommey ([EMAIL PROTECTED]) [080706 10:41]: On Fri, Jun 20, 2008 at 11:28:05AM +0200, Alexander Sack [EMAIL PROTECTED] wrote: On Fri, Jun 20, 2008 at 01:07:09AM +0200, Mike Hommey wrote: On Fri, Jun 20, 2008 at 12:43:04AM +0200, Mike Hommey wrote: On Fri, Jun 20, 2008 at 12:38:52AM +0200, Mike Hommey wrote: On Wed, Jun 18, 2008 at 12:48:42AM +0200, Josselin Mouette wrote: Le mercredi 18 juin 2008 à 00:18 +0200, Mazen NEIFER a écrit : Browse http://aljazeera.net/NR/exeres/8BAC4176-2B16-450F-B8DA-7127702A17AF.htm and try to increase font size and it will crash. This is indeed reproducible. Interestingly enough, a very similar bug happens in devhelp when trying to increase the font size. I???m attaching a full backtrace with debugging symbols. Interestingly, while I can reproduce with epiphany, I can't with iceweasel. Some values of the zoom factor may be triggering this issue... FWIW, iceweasel is setting zoom factor to 1.1, 1.2, 1.3, ... I tried some less intriguing values for zoom factors in epiphany, and it didn't change anything. It still crashes. We had this zoom crash here _before_ respinning epiphany-browser on top of the final xulrunner Are you sure its a fresh build? I build it myself yesterday. Though not against final xulrunner, but rc2, which is the same. Any news on this bug? Does it still happen? How bad is it, should it block testing migration? Cheers, Andi -- http://home.arcor.de/andreas-barth/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#486744: [epiphany-browser] Carsh when increeasing font size
On Sun, Jul 06, 2008 at 12:42:01PM +0200, Andreas Barth wrote: Hi, * Mike Hommey ([EMAIL PROTECTED]) [080706 10:41]: On Fri, Jun 20, 2008 at 11:28:05AM +0200, Alexander Sack [EMAIL PROTECTED] wrote: On Fri, Jun 20, 2008 at 01:07:09AM +0200, Mike Hommey wrote: On Fri, Jun 20, 2008 at 12:43:04AM +0200, Mike Hommey wrote: On Fri, Jun 20, 2008 at 12:38:52AM +0200, Mike Hommey wrote: On Wed, Jun 18, 2008 at 12:48:42AM +0200, Josselin Mouette wrote: Le mercredi 18 juin 2008 à 00:18 +0200, Mazen NEIFER a écrit : Browse http://aljazeera.net/NR/exeres/8BAC4176-2B16-450F-B8DA-7127702A17AF.htm and try to increase font size and it will crash. This is indeed reproducible. Interestingly enough, a very similar bug happens in devhelp when trying to increase the font size. I???m attaching a full backtrace with debugging symbols. Interestingly, while I can reproduce with epiphany, I can't with iceweasel. Some values of the zoom factor may be triggering this issue... FWIW, iceweasel is setting zoom factor to 1.1, 1.2, 1.3, ... I tried some less intriguing values for zoom factors in epiphany, and it didn't change anything. It still crashes. We had this zoom crash here _before_ respinning epiphany-browser on top of the final xulrunner Are you sure its a fresh build? I build it myself yesterday. Though not against final xulrunner, but rc2, which is the same. Any news on this bug? Does it still happen? How bad is it, should it block testing migration? It still happens reliably for me with the given url, though it doesn't happen with other urls. So I would say it is not /that/ bad. Mike -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#486744: [epiphany-browser] Carsh when increeasing font size
On Fri, Jun 20, 2008 at 01:07:09AM +0200, Mike Hommey wrote: On Fri, Jun 20, 2008 at 12:43:04AM +0200, Mike Hommey wrote: On Fri, Jun 20, 2008 at 12:38:52AM +0200, Mike Hommey wrote: On Wed, Jun 18, 2008 at 12:48:42AM +0200, Josselin Mouette wrote: reassign 486744 xulrunner-1.9 1.9~rc2-3 thanks Le mercredi 18 juin 2008 à 00:18 +0200, Mazen NEIFER a écrit : Package: epiphany-browser Version: 2.22.2-2 Severity: serious --- Please enter the report below this line. --- Browse http://aljazeera.net/NR/exeres/8BAC4176-2B16-450F-B8DA-7127702A17AF.htm and try to increase font size and it will crash. This is indeed reproducible. Interestingly enough, a very similar bug happens in devhelp when trying to increase the font size. I’m attaching a full backtrace with debugging symbols. Interestingly, while I can reproduce with epiphany, I can't with iceweasel. Some values of the zoom factor may be triggering this issue... FWIW, iceweasel is setting zoom factor to 1.1, 1.2, 1.3, ... I tried some less intriguing values for zoom factors in epiphany, and it didn't change anything. It still crashes. We had this zoom crash here _before_ respinning epiphany-browser on top of the final xulrunner Are you sure its a fresh build? - Alexander -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#486744: [epiphany-browser] Carsh when increeasing font size
On Fri, Jun 20, 2008 at 11:28:05AM +0200, Alexander Sack [EMAIL PROTECTED] wrote: On Fri, Jun 20, 2008 at 01:07:09AM +0200, Mike Hommey wrote: On Fri, Jun 20, 2008 at 12:43:04AM +0200, Mike Hommey wrote: On Fri, Jun 20, 2008 at 12:38:52AM +0200, Mike Hommey wrote: On Wed, Jun 18, 2008 at 12:48:42AM +0200, Josselin Mouette wrote: reassign 486744 xulrunner-1.9 1.9~rc2-3 thanks Le mercredi 18 juin 2008 à 00:18 +0200, Mazen NEIFER a écrit : Package: epiphany-browser Version: 2.22.2-2 Severity: serious --- Please enter the report below this line. --- Browse http://aljazeera.net/NR/exeres/8BAC4176-2B16-450F-B8DA-7127702A17AF.htm and try to increase font size and it will crash. This is indeed reproducible. Interestingly enough, a very similar bug happens in devhelp when trying to increase the font size. I’m attaching a full backtrace with debugging symbols. Interestingly, while I can reproduce with epiphany, I can't with iceweasel. Some values of the zoom factor may be triggering this issue... FWIW, iceweasel is setting zoom factor to 1.1, 1.2, 1.3, ... I tried some less intriguing values for zoom factors in epiphany, and it didn't change anything. It still crashes. We had this zoom crash here _before_ respinning epiphany-browser on top of the final xulrunner Are you sure its a fresh build? I build it myself yesterday. Though not against final xulrunner, but rc2, which is the same. Mike -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#486744: [epiphany-browser] Carsh when increeasing font size
On Wed, Jun 18, 2008 at 12:48:42AM +0200, Josselin Mouette wrote: reassign 486744 xulrunner-1.9 1.9~rc2-3 thanks Le mercredi 18 juin 2008 à 00:18 +0200, Mazen NEIFER a écrit : Package: epiphany-browser Version: 2.22.2-2 Severity: serious --- Please enter the report below this line. --- Browse http://aljazeera.net/NR/exeres/8BAC4176-2B16-450F-B8DA-7127702A17AF.htm and try to increase font size and it will crash. This is indeed reproducible. Interestingly enough, a very similar bug happens in devhelp when trying to increase the font size. I’m attaching a full backtrace with debugging symbols. Interestingly, while I can reproduce with epiphany, I can't with iceweasel. Some values of the zoom factor may be triggering this issue... Mike -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#486744: [epiphany-browser] Carsh when increeasing font size
On Fri, Jun 20, 2008 at 12:38:52AM +0200, Mike Hommey wrote: On Wed, Jun 18, 2008 at 12:48:42AM +0200, Josselin Mouette wrote: reassign 486744 xulrunner-1.9 1.9~rc2-3 thanks Le mercredi 18 juin 2008 à 00:18 +0200, Mazen NEIFER a écrit : Package: epiphany-browser Version: 2.22.2-2 Severity: serious --- Please enter the report below this line. --- Browse http://aljazeera.net/NR/exeres/8BAC4176-2B16-450F-B8DA-7127702A17AF.htm and try to increase font size and it will crash. This is indeed reproducible. Interestingly enough, a very similar bug happens in devhelp when trying to increase the font size. I’m attaching a full backtrace with debugging symbols. Interestingly, while I can reproduce with epiphany, I can't with iceweasel. Some values of the zoom factor may be triggering this issue... FWIW, iceweasel is setting zoom factor to 1.1, 1.2, 1.3, ... Mike -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#486744: [epiphany-browser] Carsh when increeasing font size
On Fri, Jun 20, 2008 at 12:43:04AM +0200, Mike Hommey wrote: On Fri, Jun 20, 2008 at 12:38:52AM +0200, Mike Hommey wrote: On Wed, Jun 18, 2008 at 12:48:42AM +0200, Josselin Mouette wrote: reassign 486744 xulrunner-1.9 1.9~rc2-3 thanks Le mercredi 18 juin 2008 à 00:18 +0200, Mazen NEIFER a écrit : Package: epiphany-browser Version: 2.22.2-2 Severity: serious --- Please enter the report below this line. --- Browse http://aljazeera.net/NR/exeres/8BAC4176-2B16-450F-B8DA-7127702A17AF.htm and try to increase font size and it will crash. This is indeed reproducible. Interestingly enough, a very similar bug happens in devhelp when trying to increase the font size. I’m attaching a full backtrace with debugging symbols. Interestingly, while I can reproduce with epiphany, I can't with iceweasel. Some values of the zoom factor may be triggering this issue... FWIW, iceweasel is setting zoom factor to 1.1, 1.2, 1.3, ... I tried some less intriguing values for zoom factors in epiphany, and it didn't change anything. It still crashes. Mike -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#486744: [epiphany-browser] Carsh when increeasing font size
Package: epiphany-browser Version: 2.22.2-2 Severity: serious --- Please enter the report below this line. --- Browse http://aljazeera.net/NR/exeres/8BAC4176-2B16-450F-B8DA-7127702A17AF.htm and try to increase font size and it will crash. --- System information. --- Architecture: i386 Kernel: Linux 2.6.25-2-686 Debian Release: lenny/sid 500 unstableftp.fr.debian.org --- Package information. --- Depends (Version) | Installed ==-+-=== epiphany-gecko | 2.22.2-2 OR epiphany-webkit| signature.asc Description: Ceci est une partie de message numériquement signée
