Bug#493678: patch from Fedora

[Russell Coker]

The following patch (from Fedora rawhide) fixes this issue.



diff -ru libtheora-1.0~beta3.bak/lib/enc/x86_32/dct_decode_mmx.c 
libtheora-1.0~beta3/lib/enc/x86_32/dct_decode_mmx.c
--- libtheora-1.0~beta3.bak/lib/enc/x86_32/dct_decode_mmx.c 2008-08-04 
15:30:57.0 +1000
+++ libtheora-1.0~beta3/lib/enc/x86_32/dct_decode_mmx.c 2008-08-04 
16:06:00.0 +1000
@@ -21,6 +21,9 @@
 
 #if defined(USE_ASM)
 
+/* Disabled as this asm results in text relocations, which is BAD */
+#if 0
+
 static const __attribute__((aligned(8),used)) ogg_int64_t V3= 
0x0003000300030003LL;
 static const __attribute__((aligned(8),used)) ogg_int64_t V804= 
0x0804080408040804LL;
 
@@ -172,12 +175,17 @@
 );
 }
 
+#endif
+
 /* install our implementation in the function table */
 void dsp_mmx_dct_decode_init(DspFunctions *funcs)
 {
+/* Disabled as this asm results in text relocations, which is BAD */
+#if 0
   TH_DEBUG(enabling accelerated x86_32 mmx dct decode functions.\n);
   funcs-FilterVert = FilterVert__mmx;
   funcs-FilterHoriz = FilterHoriz__mmx;
+#endif
 }
 
 #endif /* USE_ASM */



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#493678: patch from Fedora

[Ivo Emanuel Gonçalves]

Russell,

We are aware of SELinux problems in the assembly code and we have made
some recent changes to address it.  As such your patch may not be
needed in fact.  Please confirm this by getting the latest version
from SVN and testing.  It would be much appreciated.

-Ivo



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#493678: patch from Fedora

[Russell Coker]

On Monday 04 August 2008 20:52, Ivo Emanuel Gonçalves [EMAIL PROTECTED] 
wrote:
 We are aware of SELinux problems in the assembly code and we have made
 some recent changes to address it.  As such your patch may not be
 needed in fact.  Please confirm this by getting the latest version
 from SVN and testing.  It would be much appreciated.

I have checked testing (Lenny) and unstable and not found any more recent 
versions.

Please email me the .deb and I'll test it out.



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#493678: patch from Fedora

[Ivo Emanuel Gonçalves]

On 8/4/08, Russell Coker [EMAIL PROTECTED] wrote:
 I have checked testing (Lenny) and unstable and not found any more recent
 versions.

I reckon you misunderstood what I tried to say.  When I said latest
version from SVN I meant the Theora's makers (Xiph) repository.
Non-Debian specific patches always go upstream.

Here, I created a source package based on the latest SVN revision:
http://spreadopenmedia.org/tmp/libtheora-1.0beta4svn.tar.bz2

-Ivo



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]