Bug#494199: Patch for angband preinst bug

2008-09-03 Thread Matthew Vernon
tags 494199 patch
quit

Hi,

Attached is a patch that fixes this bug. Please apply it :-)

Thanks,

Matthew
--- preinst.orig2008-09-03 19:58:29.0 +0100
+++ preinst 2008-09-03 19:59:02.0 +0100
@@ -73,15 +73,17 @@
 for dir in apex bone save user; do
 if [ -d /var/lib/games/angband/$dir ]; then
 test -d /var/games/angband/$dir || mkdir -p 
/var/games/angband/$dir
-for file in /var/lib/games/angband/$dir/*; do
-basefile=$(basename $file)
-if [ X$basefile = Xdelete.me ]; then
-continue;
-fi
-test -e /var/games/angband/$dir/$basefile ||   
 \
-cp -f /var/lib/games/angband/$dir/$basefile
 \
-/var/games/angband/$dir/$basefile
-done
+   if ls /var/games/angband/$dir | grep . /dev/null ; then
+   for file in /var/lib/games/angband/$dir/*; do
+   basefile=$(basename $file)
+   if [ X$basefile = Xdelete.me ]; then
+   continue;
+   fi
+   test -e /var/games/angband/$dir/$basefile ||
\
+   cp -f /var/lib/games/angband/$dir/$basefile 
\
+   /var/games/angband/$dir/$basefile
+   done
+   fi
 fi
 done
 fi

-- 
At least you know where you are with Microsoft.
True. I just wish I'd brought a paddle.
http://www.debian.org


Bug#494199:

2008-08-11 Thread Matthew Vernon

Hi again,

I think the problem is due to failing to check that /var/lib/games/ 
angband/save has any files in it - if it doesn't, then you see the  
failure mode described.


HTH,

Matthew

--
Matthew Vernon MA VetMB LGSM MRCVS
Farm Animal Epidemiology and Informatics Unit
Department of Veterinary Medicine, University of Cambridge
http://www.cus.cam.ac.uk/~mcv21/






--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#494199: angband: pre-inst fails on upgrade from version 1:3.0.5-1

2008-08-08 Thread Matthew Vernon
Hi,

I downloaded the source, and simulated the pre-inst run with +x
set. The script output is below, which I hope helps.

Regards,

Matthew

Script started on Fri Aug  8 21:28:51 2008
[EMAIL PROTECTED]:~# bash -x 
~matthew/programming/angband/angband-3.0.6/debian/preinst install 1:3.0.5-1
+ set -e
+ package_name=angband
+ '[' -z angband ']'
+ case $1 in
+ :
+ '[' -L /var/games/angband/data ']'
+ '[' -d /usr/lib/angband/data ']'
+ : dpkg-divert --package foo --add --rename : --divert /usr/bin/other.real 
/usr/bin/other
+ test set = set
+ '[' -d /var/lib/games/angband ']'
+ for dir in apex bone save user
+ '[' -d /var/lib/games/angband/apex ']'
+ test -d /var/games/angband/apex
+ for file in '/var/lib/games/angband/$dir/*'
++ basename /var/lib/games/angband/apex/scores.raw
+ basefile=scores.raw
+ '[' Xscores.raw = Xdelete.me ']'
+ test -e /var/games/angband/apex/scores.raw
+ for dir in apex bone save user
+ '[' -d /var/lib/games/angband/bone ']'
+ for dir in apex bone save user
+ '[' -d /var/lib/games/angband/save ']'
+ test -d /var/games/angband/save
+ for file in '/var/lib/games/angband/$dir/*'
++ basename '/var/lib/games/angband/save/*'
+ basefile='*'
+ '[' 'X*' = Xdelete.me ']'
+ test -e /var/games/angband/save/0.Root /var/games/angband/save/1000.Mcv21 
/var/games/angband/save/1002.Ptc24 /var/games/angband/save/1006.Apc27 
/var/games/angband/save/1007.Jon /var/games/angband/save/1009.Rob 
/var/games/angband/save/1011.Mike /var/games/angband/save/1015.Daniel 
/var/games/angband/save/1018.Vyvyan /var/games/angband/save/1024.Matthew 
/var/games/angband/save/1026.Osd1000 /var/games/angband/save/1028.Webhamster 
/var/games/angband/save/1032.Skitson /var/games/angband/save/1046.Bagpuss
/home/matthew/programming/angband/angband-3.0.6/debian/preinst: line 81: test: 
too many arguments
+ cp -f '/var/lib/games/angband/save/*' /var/games/angband/save/0.Root 
/var/games/angband/save/1000.Mcv21 /var/games/angband/save/1002.Ptc24 
/var/games/angband/save/1006.Apc27 /var/games/angband/save/1007.Jon 
/var/games/angband/save/1009.Rob /var/games/angband/save/1011.Mike 
/var/games/angband/save/1015.Daniel /var/games/angband/save/1018.Vyvyan 
/var/games/angband/save/1024.Matthew /var/games/angband/save/1026.Osd1000 
/var/games/angband/save/1028.Webhamster /var/games/angband/save/1032.Skitson 
/var/games/angband/save/1046.Bagpuss
cp: target `/var/games/angband/save/1046.Bagpuss' is not a directory
[EMAIL PROTECTED]:~# 
Script done on Fri Aug  8 21:29:07 2008


-- 
At least you know where you are with Microsoft.
True. I just wish I'd brought a paddle.
http://www.debian.org



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#494199: angband: pre-inst fails on upgrade from version 1:3.0.5-1

2008-08-07 Thread Matthew Vernon
Package: angband
Version: 1:3.0.5-1
Severity: important

Hi,

Trying to upgrade angband is currently failing in pre-inst.

/var/lib/dpkg/tmp.ci/preinst: line 115: test: too many arguments
cp: target `/var/games/angband/save/1046.Bagpuss' is not a directory
dpkg: error processing /var/cache/apt/archives/angband_1%3a3.0.6-4_i386.deb 
(--install):
 subprocess pre-installation script returned error exit status 1

Thanks,

Matthew

-- System Information:
Debian Release: 3.1
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages angband depends on:
ii  libc6  2.3.6.ds1-13etch7 GNU C Library: Shared libraries
ii  libice61:1.0.1-2 X11 Inter-Client Exchange library
ii  libncurses55.5-5 Shared libraries for terminal hand
ii  libsm6 1:1.0.1-3 X11 Session Management library
ii  libx11-6   2:1.0.3-7 X11 client-side library
ii  libxaw71:1.0.2-4 X11 Athena Widget library
ii  libxext6   1:1.0.1-2 X11 miscellaneous extension librar
ii  libxmu61:1.0.2-2 X11 miscellaneous utility library
ii  libxt6 1:1.0.2-2 X11 toolkit intrinsics library
ii  xlibs  4.3.0.dfsg.1-14sarge7 X Keyboard Extension (XKB) configu

angband recommends no packages.

-- no debconf information



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]