Bug#495178: [Pkg-javascript-devel] Bug#495178: Bug#495178: (no subject)
Hi Thomas, On Wed, 2013-07-31 at 08:02 +0200, Thomas Bechtold wrote: On Tue, Jul 30, 2013 at 09:36:53PM +0200, Jonas Smedegaard wrote: Quoting Thomas Bechtold (2013-07-30 19:47:10) forgot to describe the attached debdiff. The patch adds a Build-Depends to yui-compressor and generates jquery.min.js. That's it. I recommend against using a different and inferior compressor than the one well tested upstream: uglify. I updated the attached debdiff and use node-uglify now. The filesize with uglify is much better (105841 with yui, 95024 with uglify) Thank you, but your changes are not good. The jQuery Makefile already runs the uglify, so we do not need to put it in the debian/rules. I released libjs-jquery 1.7.2+debian-1 with uglifyjs, but uglify is not in Wheezy and Julien Cristau made an NMU to replace uglify with yui-compressor. The best way to fix libjs-jquery is to revert the NMU [0] [0] http://miud.in/1DX0 Cheers, -- Marcelo Jorge Vieira xmpp:me...@jabber-br.org http://metaldot.alucinados.com signature.asc Description: This is a digitally signed message part
Bug#495178: [Pkg-javascript-devel] Bug#495178: Bug#495178: (no subject)
Hi Marcelo, On 08/02/2013 01:49 AM, Marcelo Jorge Vieira wrote: Thank you, but your changes are not good. The jQuery Makefile already runs the uglify, so we do not need to put it in the debian/rules. I released libjs-jquery 1.7.2+debian-1 with uglifyjs, but uglify is not in Wheezy and Julien Cristau made an NMU to replace uglify with yui-compressor. The best way to fix libjs-jquery is to revert the NMU [0] Oh. I missed that. That's of course the better solution. Thanks for fixing the bug! Cheers, Tom signature.asc Description: OpenPGP digital signature
Bug#495178: (no subject)
Hi, forgot to describe the attached debdiff. The patch adds a Build-Depends to yui-compressor and generates jquery.min.js. That's it. Any Comments? Cheers, Tom signature.asc Description: OpenPGP digital signature
Bug#495178: [Pkg-javascript-devel] Bug#495178: (no subject)
Quoting Thomas Bechtold (2013-07-30 19:47:10) forgot to describe the attached debdiff. The patch adds a Build-Depends to yui-compressor and generates jquery.min.js. That's it. I recommend against using a different and inferior compressor than the one well tested upstream: uglify. - Jonas -- * Jonas Smedegaard - idealist Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: signature
Bug#495178: [Pkg-javascript-devel] Bug#495178: Bug#495178: (no subject)
On 07/30/2013 03:36 PM, Jonas Smedegaard wrote: Quoting Thomas Bechtold (2013-07-30 19:47:10) forgot to describe the attached debdiff. The patch adds a Build-Depends to yui-compressor and generates jquery.min.js. That's it. I recommend against using a different and inferior compressor than the one well tested upstream: uglify. I think you're suggesting that this package should use the uglify javascript minifier, rather than the yui minifier. Do you mean node-uglify or ruby-uglifier or something else? Does the debian javascript packaging team want to settle on a best practices minifier and document it someplace? --dkg signature.asc Description: OpenPGP digital signature
Bug#495178: [Pkg-javascript-devel] Bug#495178: Bug#495178: (no subject)
Quoting Daniel Kahn Gillmor (2013-07-30 22:39:07) On 07/30/2013 03:36 PM, Jonas Smedegaard wrote: Quoting Thomas Bechtold (2013-07-30 19:47:10) forgot to describe the attached debdiff. The patch adds a Build-Depends to yui-compressor and generates jquery.min.js. That's it. I recommend against using a different and inferior compressor than the one well tested upstream: uglify. I think you're suggesting that this package should use the uglify javascript minifier, rather than the yui minifier. Do you mean node-uglify or ruby-uglifier or something else? I mean node-uglify. I believe that's the tool the jquery project uses themselves for their minification. I elaborated more on this at bug#679665. Does the debian javascript packaging team want to settle on a best practices minifier and document it someplace? Good idea! In my opinion we should start simple and recommend use of node-uglify in our Policy wiki page. (then later we can consider introducing a package to auto-(re-)compress allowing local admin to deviate from a default compressor) What do others in the team think? - Jonas -- * Jonas Smedegaard - idealist Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: signature
