Bug#499598: [Dbconfig-common-devel] Bug#499598: movabletype-opensource: seems to depend on dbconfig-common, should be pre-depends

2010-09-08 Thread Dominic Hargreaves
On Tue, Sep 07, 2010 at 11:39:30PM +0200, sean finney wrote:
 hi,
 
 On Tue, Sep 07, 2010 at 09:41:45PM +0100, Dominic Hargreaves wrote:
  What's the correct thing to do here? I'm afraid I can't come up with
  the reference for the author of dbconfig-common suggests thing.
  
  I'm also not sure why, for example, this comes up here but not in,
  for example, request-tracker3.8.
 
 what is the actual confusing error message?  I didn't see it in the
 bug report.

I don't remember it now unfortunately, but...

 generally speaking the need for pre-depends shouldn't be necessary, since
 this only affects the preinst and config maintainer scripts, and of these
 only the config script is used by the dbconfig-common code.  in the postinst
 (where dbconfig can be guaranteed to be installed and configured already),
 dbconfig-common does an internal check to see if the config script was
 run, and if not it calls this code again before continuing and everything
 should be fine.

Yup, makes sense.

 i'm going to go on a hunch and assume that perhaps the config maintainer
 script isn't testing for the existance of the dbconfig config hooks before
 trying to source it?  i.e.
 
 . /usr/share/dbconfig-common/dpkg/config
 dbc_go $pkg $1
 
 vs
 
 if [ -f /usr/share/dbconfig-common/dpkg/config ]; then
   . /usr/share/dbconfig-common/dpkg/config
   dbc_go $pkg $1
 fi
 
 maybe that's the case?

Yes, you're spot on, and I now feel quite silly for not thinking of
that...

Many thanks,
Dominic.

-- 
Dominic Hargreaves | http://www.larted.org.uk/~dom/
PGP key 5178E2A5 from the.earth.li (keyserver,web,email)



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#499598: [Dbconfig-common-devel] Bug#499598: movabletype-opensource: seems to depend on dbconfig-common, should be pre-depends

2010-09-07 Thread sean finney
hi,

On Tue, Sep 07, 2010 at 09:41:45PM +0100, Dominic Hargreaves wrote:
 What's the correct thing to do here? I'm afraid I can't come up with
 the reference for the author of dbconfig-common suggests thing.
 
 I'm also not sure why, for example, this comes up here but not in,
 for example, request-tracker3.8.

what is the actual confusing error message?  I didn't see it in the
bug report.

generally speaking the need for pre-depends shouldn't be necessary, since
this only affects the preinst and config maintainer scripts, and of these
only the config script is used by the dbconfig-common code.  in the postinst
(where dbconfig can be guaranteed to be installed and configured already),
dbconfig-common does an internal check to see if the config script was
run, and if not it calls this code again before continuing and everything
should be fine.

i'm going to go on a hunch and assume that perhaps the config maintainer
script isn't testing for the existance of the dbconfig config hooks before
trying to source it?  i.e.

. /usr/share/dbconfig-common/dpkg/config
dbc_go $pkg $1

vs

if [ -f /usr/share/dbconfig-common/dpkg/config ]; then
. /usr/share/dbconfig-common/dpkg/config
dbc_go $pkg $1
fi

maybe that's the case?



sean


signature.asc
Description: Digital signature