Bug#501396: A guess

[Theppitak Karoonboonyanan]

On Wed, Jan 28, 2009 at 11:53 AM, Theppitak Karoonboonyanan
t...@linux.thai.net wrote:

 I also saw this bug. And I managed to workaround it in my machine with
 the attached patch.

What's going on with this bug? Is the patch OK?
I can also prepare an NMU if you agree.

Regards,
-- 
Theppitak Karoonboonyanan
http://linux.thai.net/~thep/



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#501396: A guess

[Robert Gerlach]

Patch works fine, thanks.


This message was sent using IMP, the Internet Messaging Program.





--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#501396: A guess

[Theppitak Karoonboonyanan]

On Wed, Jan 28, 2009 at 11:53 AM, Theppitak Karoonboonyanan
t...@linux.thai.net wrote:

 I also saw this bug. And I managed to workaround it in my machine with
 the attached patch.

Oops. Forgot the patch.

-- 
Theppitak Karoonboonyanan
http://linux.thai.net/~thep/
--- /usr/bin/calamaris.orig	2009-01-28 10:40:45.0 +0700
+++ /usr/bin/calamaris	2009-01-28 11:34:48.0 +0700
@@ -4048,13 +4048,13 @@
 
   if ($max_x_data  0) {
 # show last $max_x_data Values
-$min_x = ($...@$xaxis_ref} + $max_x_data  0) ? 0
-  : $...@$xaxis_ref} + $max_x_data + 1;
-$max_x = $...@$xaxis_ref};
+$min_x = ($#{$xaxis_ref} + $max_x_data  0) ? 0
+  : $#{$xaxis_ref} + $max_x_data + 1;
+$max_x = $#{$xaxis_ref};
   } else {
 # show first $max_x_data Values
 $min_x = 0;
-$max_x = ($...@$xaxis_ref}  $max_x_data) ? $max_x_data : $...@$xaxis_ref};
+$max_x = ($#{$xaxis_ref}  $max_x_data) ? $max_x_data : $#{$xaxis_ref};
   }
 
   my $graph = calamaris::calBars3d-new($width, int($width/3*2));
@@ -4080,7 +4080,7 @@
   ($factor0, $unit0) = getfactor(max(@$yaxis1_ref[$min_x..$max_x]),9);
   $yaxis1_ref = reformatarray($factor0, $yaxis1_ref) if ($factor0  1);
   my %graph_label = (x_label		= '',
-		 y_label		= $unit0 $...@$legend_ref}[0],
+		 y_label		= $unit0 ${$legend_ref}[0],
 		 title		= '',
 		 two_axes		= '0',
 		 x_labels_vertical	= '1',
@@ -4111,8 +4111,8 @@
 push @data, [...@$yaxis2_ref[$min_x..$max_x]];
 push @data, [...@$yaxis3_ref[$min_x..$max_x]] if ref($yaxis3_ref);
 push @data, [...@$yaxis4_ref[$min_x..$max_x]] if ref($yaxis4_ref);
-%graph_label = ( y1_label		= $unit0 $...@$legend_ref}[0],
-		y2_label		= $unit1 $...@$legend_ref}[1],
+%graph_label = ( y1_label		= $unit0 ${$legend_ref}[0],
+		y2_label		= $unit1 ${$legend_ref}[1],
 		two_axes		= '1',
 		bar_spacing		= '0',
 		set_spacing		= '6', );

Bug#501396: A guess

[Theppitak Karoonboonyanan]

package calamaris
tags 501396 + patch
severity 501396 important
thanks

I also saw this bug. And I managed to workaround it in my machine with
the attached patch. My guess is that the $xxx_ref variables could be
immediately referenced with ${$xxx_ref} without the prefix @.
Probably some Perl syntax changes in 5.10?

This also eliminates the warning messages regarding the use of
uninitialized values.

I'm not sure if it's a correct fix. Feel free to correct it if it isn't.

With this, I think the bug should be important, if not RC. Although it
does not affect the default configuration, I think most people
want to see the graph report.

-- 
Theppitak Karoonboonyanan
http://linux.thai.net/~thep/



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org