Bug#501516: Main-Class: entry has space appended by jh_manifest

2008-10-10 Thread Matthew Johnson
tag 501516 pending
thanks

On Tue Oct 07 23:55, Richard Cole wrote:
 This is called to write out entries such as Main-Class and it always
 appends a space after each entry. But sun-java-6 doesn't work if the
 Main-Class entry is followed by a space.
 
 A fix for this is to prepend a space, except for the first line,
 rather than always appending a space.

Thanks, I've uploaded a fix for this.

 You should probably also handle the case when a word is greater than
 71 characters, although I don't know what the standard allows for in
 this case (or indeed if there is a standard).

Me neither, so I'm going to ignore it at the moment.

Matt
-- 
Matthew Johnson


signature.asc
Description: Digital signature


Bug#501516: Main-Class: entry has space appended by jh_manifest

2008-10-07 Thread Richard Cole
Subject: Main-Class: entry has space appended by jh_manifest
Package: javahelper
Version: 0.15
Severity: important

*** Please type your report below this line ***

From jh_manifest:

def splitWrite(f, line):
   words = line.split()
   i = 0
   for w in words:
  if i+len(w)  71:
 f.write(\n )
 i = 0
  f.write(w+ )
  i = i + len(w) + 1
   f.write(\n)

This is called to write out entries such as Main-Class and it always
appends a space after each entry. But sun-java-6 doesn't work if the
Main-Class entry is followed by a space.

A fix for this is to prepend a space, except for the first line,
rather than always appending a space.

  if !isFirst:
f.write( )
  else:
isFirst = false
  f.write(w)

You should probably also handle the case when a word is greater than
71 characters, although I don't know what the standard allows for in
this case (or indeed if there is a standard).

regards,

Richard.


-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (900, 'testing'), (800, 'unstable'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.18-53.1.13.el5PAE (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages javahelper depends on:
ii  debhelper 7.0.15 helper programs for debian/rules
ii  devscripts2.10.35scripts to make the life of a Debi
ii  fastjar   2:0.95-4   Jar creation utility
ii  gcj   4:4.3.2-2  The GNU Java compiler
ii  python2.5.2-2An interactive high-level object-o
ii  python-debian 0.1.10 Python modules to work with Debian
ii  python-scriptutil 1-1Python module which provides the f
ii  realpath  1.12   Return the canonicalized absolute
ii  zip   2.32-1 Archiver for .zip files

javahelper recommends no packages.

javahelper suggests no packages.

-- no debconf information



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]