Bug#503713: Investigating Lenny release blocker bug: #503713
José Luis Tallón wrote: > Christian Perrier wrote: > >> Quoting Sebastiaan Couwenberg ([EMAIL PROTECTED]): >> >> >>> -BEGIN PGP SIGNED MESSAGE- >>> Hash: SHA1 >>> >>> tags 503713 patch >>> thanks >>> >>> José Luis Tallón wrote: >>> >>> I look forward to your suggestion and/or patch. >>> Time did not allow me to finish this yesterday, but I managed to finish >>> up testing the patch today. >>> >>> >> José Luis, any plans to prepare an upload? I'd be happy to sponsor it >> if needed as fixing two RC bugs during this week-end would continue my >> "one RC bug per week-end" series... >> >> http://devel.adv-solutions.net/debian/pool/main/admin/bindgraph/bindgraph_0.2a-4.dsc Includes fixes for the config file overwriting, dutch localization update, permissions on query log. Thanks, J.L. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#503713: Investigating Lenny release blocker bug: #503713
Sebastiaan Couwenberg wrote: > Christian Perrier wrote: > > Quoting José Luis Tallón ([EMAIL PROTECTED]): > > >>> José Luis, any plans to prepare an upload? I'd be happy to sponsor it > >>> if needed as fixing two RC bugs during this week-end would continue my > >>> "one RC bug per week-end" series... > >>> > >> Indeed. If real life allows me, I think I can have the patch ready and > >> tested sometime tonight. > > > Any news? People, I have been much overloaded since Friday (sorry 'bout that, Christian). There are some other issues which I would like to cover with this upload, so I'd rather prepare it myself. Thank you for your support J.L. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#503713: Investigating Lenny release blocker bug: #503713
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Christian Perrier wrote: > Quoting José Luis Tallón ([EMAIL PROTECTED]): > >>> José Luis, any plans to prepare an upload? I'd be happy to sponsor it >>> if needed as fixing two RC bugs during this week-end would continue my >>> "one RC bug per week-end" series... >>> >> Indeed. If real life allows me, I think I can have the patch ready and >> tested sometime tonight. > > > Any news? > If it's OK with José Luis, I can upload an updated (source) package to mentors.d.n with the patch I posted in Message #22, so it can be sponsored. Regards, Bas - -- GnuPG: 0x77A975AD -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkka3loACgkQRWRRA3epda3WtwCgjOcFgRa8EuAFakMDSTWeJQUe cskAni/BFmZGxXW/e/yfVqCj4XwrDDKL =EE9d -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#503713: Investigating Lenny release blocker bug: #503713
Quoting José Luis Tallón ([EMAIL PROTECTED]): > > José Luis, any plans to prepare an upload? I'd be happy to sponsor it > > if needed as fixing two RC bugs during this week-end would continue my > > "one RC bug per week-end" series... > > > Indeed. If real life allows me, I think I can have the patch ready and > tested sometime tonight. Any news? signature.asc Description: Digital signature
Bug#503713: Investigating Lenny release blocker bug: #503713
Christian Perrier wrote: > Quoting Sebastiaan Couwenberg ([EMAIL PROTECTED]): > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> tags 503713 patch >> thanks >> >> José Luis Tallón wrote: >> >>> I look forward to your suggestion and/or patch. >>> >> Time did not allow me to finish this yesterday, but I managed to finish >> up testing the patch today. >> > > > José Luis, any plans to prepare an upload? I'd be happy to sponsor it > if needed as fixing two RC bugs during this week-end would continue my > "one RC bug per week-end" series... > Indeed. If real life allows me, I think I can have the patch ready and tested sometime tonight. Thank you for your support, Christian. J.L. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#503713: Investigating Lenny release blocker bug: #503713
Quoting Sebastiaan Couwenberg ([EMAIL PROTECTED]): > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > tags 503713 patch > thanks > > José Luis Tallón wrote: > > I look forward to your suggestion and/or patch. > > Time did not allow me to finish this yesterday, but I managed to finish > up testing the patch today. José Luis, any plans to prepare an upload? I'd be happy to sponsor it if needed as fixing two RC bugs during this week-end would continue my "one RC bug per week-end" series... signature.asc Description: Digital signature
Bug#503713: Investigating Lenny release blocker bug: #503713
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
tags 503713 patch
thanks
José Luis Tallón wrote:
> I look forward to your suggestion and/or patch.
Time did not allow me to finish this yesterday, but I managed to finish
up testing the patch today.
I've attached my proposed patch:
It sources the /etc/default/bindgraph in debian/config if it exists and
uses the DNS_LOG value to set the selection in debconf before prompting.
It also uses a more strict expression to check if the
/etc/default/bindgraph needs to be modified.
mailgraph uses as similar approach, except that it uses all debconf
questions to generate /etc/default/mailgraph and sources it to set the
current values in debconf for all mailgraphs questions. This may be an
option too, this was my initial approach, but that patch deferred to
much from your package as it is now, so I chose this more limited
approach for now.
You probably also want to purge the settings from the debconf database
in debian/postrm with db_purge to start fresh after the package has been
purged.
Regards,
Bas
- --
GnuPG: 0x77A975AD
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkkRs6cACgkQRWRRA3epda2UOgCgibWgu6HzMqRyRXVYzJYEhAOw
u44An1oM/3bPEdqGRzcq/o/toPtOCw3a
=dL5g
-END PGP SIGNATURE-
diff -ruN ../bindgraph-0.2a.old/debian/changelog ../bindgraph-0.2a/debian/changelog
--- ../bindgraph-0.2a.old/debian/changelog 2008-11-04 16:53:40.0 +0100
+++ ../bindgraph-0.2a/debian/changelog 2008-11-04 16:40:13.0 +0100
@@ -1,3 +1,12 @@
+bindgraph (0.2a-3.2) unstable; urgency=low
+
+ * Non-maintainer upload.
+ * Change maintainer scripts to preserve changes to /etc/default/bindgraph
+by using those settings (if available) in debconf before prompting.
+(Closes: 503713)
+
+ -- Sebastiaan Couwenberg <[EMAIL PROTECTED]> Tue, 04 Nov 2008 16:27:47 +0100
+
bindgraph (0.2a-3.1) unstable; urgency=low
* Non-maintainer upload.
diff -ruN ../bindgraph-0.2a.old/debian/config ../bindgraph-0.2a/debian/config
--- ../bindgraph-0.2a.old/debian/config 2008-11-04 16:53:40.0 +0100
+++ ../bindgraph-0.2a/debian/config 2008-11-05 15:26:51.0 +0100
@@ -12,7 +12,14 @@
case "$1" in
configure|reconfigure)
-
+ if [ -f /etc/default/bindgraph ]; then
+ . /etc/default/bindgraph
+
+ if [ -n "$DNS_LOG" ]; then
+db_set bindgraph/logfile "$DNS_LOG"
+ fi
+ fi
+
db_input medium bindgraph/start_on_boot || true
db_go
diff -ruN ../bindgraph-0.2a.old/debian/postinst ../bindgraph-0.2a/debian/postinst
--- ../bindgraph-0.2a.old/debian/postinst 2008-11-04 16:53:40.0 +0100
+++ ../bindgraph-0.2a/debian/postinst 2008-11-05 15:27:05.0 +0100
@@ -60,18 +60,19 @@
if [ ! -f $DEFAULTS ]; then
echo "DNS_LOG=$LOGFILE" > $DEFAULTS
echo "LOG_FORMAT=${log_ver}" >> $DEFAULTS
-
- elif [ -z "`grep $LOGFILE $DEFAULTS`" ]; then
+ fi
+
+ if [ -z "`egrep "^\s*DNS_LOG\s*=\s*$LOGFILE\s*$" $DEFAULTS`" ]; then
# update log file location
mv $DEFAULTS $DEFAULTS.tmp
- grep -v DNS_LOG $DEFAULTS.tmp > $DEFAULTS
+ egrep -v "^\s*DNS_LOG\s*=" $DEFAULTS.tmp > $DEFAULTS
echo "DNS_LOG=$LOGFILE" >> $DEFAULTS
rm -f $DEFAULTS.tmp
fi
if [ -n "$2" ]; then
# if we are upgrading, update config :-)
- if [ -z "`grep LOG_FORMAT ${DEFAULTS}`" ]; then
+ if [ -z "`egrep "^\s*LOG_FORMAT\s*=" ${DEFAULTS}`" ]; then
echo "LOG_FORMAT=${log_ver}" >> $DEFAULTS
fi
fi
Bug#503713: Investigating Lenny release blocker bug: #503713
Sebastiaan Couwenberg wrote: > I've been looking in to this bug because I use this package myself too, > and because it is among the RC bugs blocking lenny. > > As I wrote in my message to control@ [1], I merged this issue with > #481103 because they report the same issue only for a different version > of the package. Ok. Thank you for your efforts. I look forward to your suggestion and/or patch. Regards, J.L. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#503713: Investigating Lenny release blocker bug: #503713
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
I've been looking in to this bug because I use this package myself too,
and because it is among the RC bugs blocking lenny.
As I wrote in my message to control@ [1], I merged this issue with
#481103 because they report the same issue only for a different version
of the package.
This issue is similar to #433510 reported against mailgraph [2], which
changed the maintainer scripts to only generate the /etc/default/
configuration file if it does not exist and to source it otherwise.
The following section in debian/postinst appears to be the culprit that
changes the /etc/default/bindgraph file, specifically lines 64-70:
[...]
31 DEFAULTS=/etc/default/bindgraph
[...]
40 db_get bindgraph/logfile || true
41 LOGFILE="$RET"
[...]
52 # Solve #293819
53 BIND_VER="`dpkg -l bind9 | awk '/^ii/ { print $3; }'`"
54 if [ -n $BIND_VER ] && dpkg --compare-versions "$BIND_VER"
ge '9.3' ; then
55 log_ver="bind93" ;
56 else
57 log_ver="bind92" ;
58 fi
59
60 if [ ! -f $DEFAULTS ]; then
61 echo "DNS_LOG=$LOGFILE" > $DEFAULTS
62 echo "LOG_FORMAT=${log_ver}" >> $DEFAULTS
63
64 elif [ -z "`grep $LOGFILE $DEFAULTS`" ]; then
65 # update log file location
66 mv $DEFAULTS $DEFAULTS.tmp
67 grep -v DNS_LOG $DEFAULTS.tmp > $DEFAULTS
68 echo "DNS_LOG=$LOGFILE" >> $DEFAULTS
69 rm -f $DEFAULTS.tmp
70 fi
71
72 if [ -n "$2" ]; then
73 # if we are upgrading, update config :-)
74 if [ -z "`grep LOG_FORMAT ${DEFAULTS}`" ]; then
75 echo "LOG_FORMAT=${log_ver}" >> $DEFAULTS
76 fi
77 fi
[...]
The Debconf config.dat contains the following for bindgraph/logfile:
Name: bindgraph/logfile
Template: bindgraph/logfile
Value: /var/log/bind9-query.log
Owners: bindgraph
If the value of DNS_LOG in /etc/default/bindgraph does not match the
debconf bindgraph/logfile value, the debconf value is set in
/etc/default/bindgraph.
This logic seems to have been introduced to fix #318458 if I look at the
changelog and bug in question:
bindgraph (0.2a-3) unstable; urgency=high
* Reconfigure now updates logfile location (Closes: 318458)
I'll have a look to see if the bindgrapg maintainer scripts can be
modified to resemble those of mailgraph to fix this issue and not to
regress the previous issues.
Regards,
Bas
References:
[1]: http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=7;bug=503713
[2]: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=433510
- --
GnuPG: 0x77A975AD
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkkQSh8ACgkQRWRRA3epda2hsgCfSK1EojO8L8mNI44DXg1y5e5S
JzIAn0Hk/aMh/n+clCzKTh+55qGeRbmk
=mXmx
-END PGP SIGNATURE-
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
