Bug#504820: ncurses: FTBFS on GNU/kFreeBSD
The chunk of code you're pointing to hasn't changed for a long time (it's in ncurses 4.2). If it's broken now, it's either because tset's use of header files has changed, or that kFreeBSD's headers have changed. The ncurses 5.6+20081004-1 have been built fine, the ncurses 5.6+20081011-1 failed. http://buildd.debian-ports.org/fetch.php?pkg=ncursesver=5.6%2B20081004-1arch=kfreebsd-i386stamp=1223562651file=logas=raw http://buildd.debian-ports.org/fetch.php?pkg=ncursesver=5.6%2B20081011-1arch=kfreebsd-i386stamp=1224188242file=logas=raw The Toolchain package versions, including kFreeBSD's headers in both buildd logs are the same. It would be helpful to know the exact problem (what the particular value is that's undefined, and why it's not defined versus the configure script). At the problematic line is TAB3 | ONLCR | OCRNL | ONLRET. Our current kFreeBSD's headers contains only #define ONLCR (1 1) #define XTABS 0x0c00 #define TAB3 XTABS Some of definition should be privided only for compatibility, I should look into later. It looks like we (GNU/kFreeBSD) need a clean up here. Petr -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#504820: ncurses: FTBFS on GNU/kFreeBSD
oh... (that's surprising, since I might have expected some portability issue with TAB3, but not OCRNL or ONLRET since they're defined in X/Open). Didn't ncurses 5.6 compile with kFreeBSD? They did, the problem started with ncurses 5.6+20081011-1 (5.6+20081004-1 have been ok), see http://buildd.debian-ports.org/build.php?arch=pkg=ncurses Petr -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#504820: ncurses: FTBFS on GNU/kFreeBSD
On Mon, 10 Nov 2008, Petr Salinger wrote: The chunk of code you're pointing to hasn't changed for a long time (it's in ncurses 4.2). If it's broken now, it's either because tset's use of header files has changed, or that kFreeBSD's headers have changed. The ncurses 5.6+20081004-1 have been built fine, the ncurses 5.6+20081011-1 failed. http://buildd.debian-ports.org/fetch.php?pkg=ncursesver=5.6%2B20081004-1arch=kfreebsd-i386stamp=1223562651file=logas=raw http://buildd.debian-ports.org/fetch.php?pkg=ncursesver=5.6%2B20081011-1arch=kfreebsd-i386stamp=1224188242file=logas=raw The Toolchain package versions, including kFreeBSD's headers in both buildd logs are the same. It would be helpful to know the exact problem (what the particular value is that's undefined, and why it's not defined versus the configure script). At the problematic line is TAB3 | ONLCR | OCRNL | ONLRET. Our current kFreeBSD's headers contains only #define ONLCR (1 1) #define XTABS 0x0c00 #define TAB3 XTABS oh... (that's surprising, since I might have expected some portability issue with TAB3, but not OCRNL or ONLRET since they're defined in X/Open). Didn't ncurses 5.6 compile with kFreeBSD? Some of definition should be privided only for compatibility, I should look into later. It looks like we (GNU/kFreeBSD) need a clean up here. yes - -- Thomas E. Dickey http://invisible-island.net ftp://invisible-island.net -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#504820: ncurses: FTBFS on GNU/kFreeBSD
On Mon, 10 Nov 2008, Petr Salinger wrote: oh... (that's surprising, since I might have expected some portability issue with TAB3, but not OCRNL or ONLRET since they're defined in X/Open). Didn't ncurses 5.6 compile with kFreeBSD? They did, the problem started with ncurses 5.6+20081011-1 (5.6+20081004-1 have been ok), see http://buildd.debian-ports.org/build.php?arch=pkg=ncurses 20081011 adds this change to tset.c (perhaps it introduces a different set of included files - noting that the ifdef reflects a problem long ago with SunOS): --- ncurses-5.6-20081004+/progs/tset.c 2008-09-13 18:55:15.0 + +++ ncurses-5.6-20081011/progs/tset.c 2008-10-11 19:26:19.0 + @@ -89,9 +89,12 @@ char *ttyname(int fd); #endif -/* this is just to stifle a missing-prototype warning */ -#ifdef linux -# include sys/ioctl.h +#if HAVE_SIZECHANGE +# if !defined(sun) || !TERMIOS +# if HAVE_SYS_IOCTL_H +# include sys/ioctl.h +# endif +# endif #endif #if NEED_PTEM_H -- Thomas E. Dickey http://invisible-island.net ftp://invisible-island.net -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#504820: ncurses: FTBFS on GNU/kFreeBSD
On Fri, Nov 07, 2008 at 04:20:10PM +0100, Petr Salinger wrote:
Package: ncurses
Severity: important
Version: 5.7-1
Tags: patch
User: [EMAIL PROTECTED]
Usertags: kfreebsd
Hi,
the current version fails to build on GNU/kFreeBSD.
Which of the values isn't defined?
The chunk of code you're pointing to hasn't changed for a long time (it's
in ncurses 4.2). If it's broken now, it's either because tset's use of
header files has changed, or that kFreeBSD's headers have changed.
The only relevant change that I can see in the configure script would be
this item:
20070217
+ add pattern for GNU/kFreeBSD configuration to CF_XOPEN_SOURCE,
which matches an earlier change to CF_SHARED_OPTS, from xterm #224
fixes.
It would be helpful to know the exact problem (what the particular value
is that's undefined, and why it's not defined versus the configure script).
-#ifdef TAB3
+#if defined(TAB3) defined(ONLCR) defined(OCRNL) defined(ONLRET)
if (oldmode.c_oflag (TAB3 | ONLCR | OCRNL | ONLRET)) {
oldmode.c_oflag = (TAB3 | ONLCR | OCRNL | ONLRET);
SET_TTY(STDERR_FILENO, oldmode);
--
Thomas E. Dickey
http://invisible-island.net
ftp://invisible-island.net
pgpQdq5qnmMgY.pgp
Description: PGP signature
Bug#504820: ncurses: FTBFS on GNU/kFreeBSD
Package: ncurses
Severity: important
Version: 5.7-1
Tags: patch
User: [EMAIL PROTECTED]
Usertags: kfreebsd
Hi,
the current version fails to build on GNU/kFreeBSD.
It needs small tweak, se bellow.
It would also be nice if you can ask upstream
to include this change.
Thanks in advance
Petr
--- progs/tset.c
+++ progs/tset.c
@@ -981,7 +981,7 @@
PC = pad_char[0];
#endif /* OBSOLETE */
-#ifdef TAB3
+#if defined(TAB3) defined(ONLCR) defined(OCRNL) defined(ONLRET)
if (oldmode.c_oflag (TAB3 | ONLCR | OCRNL | ONLRET)) {
oldmode.c_oflag = (TAB3 | ONLCR | OCRNL | ONLRET);
SET_TTY(STDERR_FILENO, oldmode);
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
