Bug#506707: Info received (Bug#506707: patch)

2010-04-02 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Simultaneous input terminals were done in November by Robert, Output
terminals were done by me. The configuration part was left out of 1.98
on purpose so only advanced users can get to this feature. Today I
merged this part into experimental

@Jeff: it's not nice to claim you have implemented this when in fact you
only created configuration template.
Jeff Clark wrote:
 Minor update to patch.  Eliminated duplicate 'serial' command when
 GRUB_TERMINAL variable is used instead of GRUB_TERMINAL_INPUT and
 GRUB_TERMINAL_OUTPUT.

 

 ___
 Pkg-grub-devel mailing list
 pkg-grub-de...@lists.alioth.debian.org
 http://lists.alioth.debian.org/mailman/listinfo/pkg-grub-devel


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko




signature.asc
Description: OpenPGP digital signature


Bug#506707: Info received (Bug#506707: patch)

2010-04-02 Thread Jeff Clark
@Vladimir: I made no such claim.  Please refer to my original message,
and the point of this bug report.  Everything here (and the patch I
submitted) clearly deal with configuration only.  I have no interest
in taking credit for anyone's effort but my own.



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#506707: Info received (Bug#506707: patch)

2010-04-02 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Jeff Clark wrote:
 @Vladimir: I made no such claim.  Please refer to my original message,
 and the point of this bug report.  Everything here (and the patch I
 submitted) clearly deal with configuration only.  I have no interest
 in taking credit for anyone's effort but my own.

   
Ok, then I'm sorry of implying such an accusation based on short message
I misunderstood.


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko




signature.asc
Description: OpenPGP digital signature


Bug#506707: Info received (Bug#506707: patch)

2010-03-07 Thread Marc Haber
tags #506707 patch
thanks

On Mon, Feb 22, 2010 at 04:02:50AM -0600, Jeff Clark wrote:
 Minor update to patch.  Eliminated duplicate 'serial' command when
 GRUB_TERMINAL variable is used instead of GRUB_TERMINAL_INPUT and
 GRUB_TERMINAL_OUTPUT.

Hi,

I tried the patch from
https://savannah.gnu.org/support/download.php?file_id=19772

The fil can simply be dumped into debian/patches, the patch is then
applied automatically (and does apply cleanly). The resulting grub can
get a GRUB_TERMINAL='serial console' in /etc/default/grub and shows
the menu on both real and serial console. It is useable on both
consoles.

Please apply this patch in time for squeeze, it would really be a
shame not to have this functionality in Debian squeeze. It is
important for datacenter use.

Greetings
Marc

-- 
-
Marc Haber | I don't trust Computers. They | Mailadresse im Header
Mannheim, Germany  |  lose things.Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#506707: patch

2010-02-22 Thread Jeff Clark
My first patch submission was not thoroughly tested, sorry!  Attached
is a patch against debian unstable grub2 1.98~20100128.  The same
patch needs a minor tweak to apply cleanly to the experimental
package.

Tested successfully using these GRUB_TERMINAL values:

*unset* - verified existing functionality (default gfxterm/console)
'console' - verified, skip gfxterm - normal console
'serial console' - verified simultaneous I/O to console and serial port
'serial gfxterm' - verified simultaneous gfxterm and serial I/O

-Jeff

On Fri, Feb 19, 2010 at 7:46 PM, Jeff Clark d...@zaplabs.com wrote:
 Package: grub-common
 Version: 1.98~20100128-1.2
 Severity: normal

 patches attached to support multiple terminals (simultaneous serial and 
 console) configuration.  Correctly adds 'terminal console serial' to grub.cfg 
 when GRUB_TERMINAL is set to 'serial console' in /etc/defaults/grub.



10_simultaneous_terminal.patch
Description: Binary data


Bug#506707: Info received (Bug#506707: patch)

2010-02-22 Thread Jeff Clark
Minor update to patch.  Eliminated duplicate 'serial' command when
GRUB_TERMINAL variable is used instead of GRUB_TERMINAL_INPUT and
GRUB_TERMINAL_OUTPUT.


10_simultaneous_terminal_v2.patch
Description: Binary data


Bug#506707: patch

2010-02-19 Thread Jeff Clark
Package: grub-common
Version: 1.98~20100128-1.2
Severity: normal

patches attached to support multiple terminals (simultaneous serial and 
console) configuration.  Correctly adds 'terminal console serial' to grub.cfg 
when GRUB_TERMINAL is set to 'serial console' in /etc/defaults/grub.


-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.32-trunk-686-bigmem (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages grub-common depends on:
ii  base-files  5.1  Debian base system miscellaneous f
ii  dpkg1.15.5.6 Debian package management system
ii  gettext-base0.17-9   GNU Internationalization utilities
ii  install-info4.13a.dfsg.1-5   Manage installed documentation in 
ii  libc6   2.10.2-5 Embedded GNU C Library: Shared lib
ii  libfreetype62.3.11-1 FreeType 2 font engine, shared lib
ii  zlib1g  1:1.2.3.4.dfsg-3 compression library - runtime

Versions of packages grub-common recommends:
ii  os-prober 1.35   utility to detect other OSes on a 

Versions of packages grub-common suggests:
pn  grub-emu  none (no description available)
pn  multiboot-doc none (no description available)

-- no debconf information
--- /etc/grub.d/00_header.old   2010-02-14 13:56:02.0 -0600
+++ /etc/grub.d/00_header   2010-02-19 18:51:39.0 -0600
@@ -59,19 +59,21 @@
 }
 EOF
 
-case ${GRUB_TERMINAL_INPUT}:${GRUB_TERMINAL_OUTPUT} in
-  serial:* | *:serial)
-if ! test -e ${grub_prefix}/serial.mod ; then
-  echo Serial terminal not available on this platform. 2 ; exit 1
-fi
-
-if [ x${GRUB_SERIAL_COMMAND} = x ] ; then
-  grub_warn Requested serial terminal but GRUB_SERIAL_COMMAND is 
unspecified. Default parameters will be used.
-  GRUB_SERIAL_COMMAND=serial
-fi
-echo ${GRUB_SERIAL_COMMAND}
-  ;;
-esac
+for GRUB_TERMINAL in ${GRUB_TERMINAL_INPUT} ${GRUB_SERIAL_OUTPUT}; do
+  case ${GRUB_TERMINAL} in
+serial)
+  if ! test -e ${grub_prefix}/serial.mod ; then
+echo Serial terminal not available on this platform. 2 ; exit 1
+  fi
+  
+  if [ x${GRUB_SERIAL_COMMAND} = x ] ; then
+grub_warn Requested serial terminal but GRUB_SERIAL_COMMAND is 
unspecified. Default parameters will be used.
+GRUB_SERIAL_COMMAND=serial
+  fi
+  echo ${GRUB_SERIAL_COMMAND}
+;;
+  esac
+done
 
 case x${GRUB_TERMINAL_INPUT} in
   x)
--- /usr/sbin/grub-mkconfig.old 2010-02-14 13:56:02.0 -0600
+++ /usr/sbin/grub-mkconfig 2010-02-19 18:57:00.0 -0600
@@ -140,60 +140,62 @@
   GRUB_TERMINAL_OUTPUT=${GRUB_TERMINAL}
 fi
 
-case x${GRUB_TERMINAL_OUTPUT} in
-  x | xgfxterm)
-# If this platform supports gfxterm, try to use it.
-if test -e ${grub_prefix}/gfxterm.mod ; then
-  # FIXME: this should do something smarter than just loading first
-  # video backend.
-  GRUB_VIDEO_BACKEND=$(head -n 1 ${grub_prefix}/video.lst || true)
-  if [ -n ${GRUB_VIDEO_BACKEND} ] ; then
-GRUB_TERMINAL_OUTPUT=gfxterm
-  elif [ ${GRUB_TERMINAL_OUTPUT} = gfxterm ] ; then
-echo No suitable backend could be found for gfxterm. 2 ; exit 1
+for GRUB_TERMINAL in ${GRUB_TERMINAL_INPUT} ${GRUB_TERMINAL_OUTPUT}; do
+  case x${GRUB_TERMINAL} in
+x | xgfxterm)
+  # If this platform supports gfxterm, try to use it.
+  if test -e ${grub_prefix}/gfxterm.mod ; then
+# FIXME: this should do something smarter than just loading first
+# video backend.
+GRUB_VIDEO_BACKEND=$(head -n 1 ${grub_prefix}/video.lst || true)
+if [ -n ${GRUB_VIDEO_BACKEND} ] ; then
+  GRUB_TERMINAL_OUTPUT=gfxterm
+elif [ ${GRUB_TERMINAL} = gfxterm ] ; then
+  echo No suitable backend could be found for gfxterm. 2 ; exit 1
+fi
   fi
-fi
-  ;;
-  xconsole | xserial | xofconsole) ;;
-  *) echo Invalid output terminal \${GRUB_TERMINAL_OUTPUT}\ 2 ; exit 1 ;;
-esac
-
-# check for terminals that require fonts
-case ${GRUB_TERMINAL_OUTPUT} in
-  gfxterm)
-if [ -n $GRUB_FONT ] ; then
-  if is_path_readable_by_grub ${GRUB_FONT}  /dev/null ; then
-GRUB_FONT_PATH=${GRUB_FONT}
-   else
- echo No such font or not readable by grub: ${GRUB_FONT} 2
- exit 1
-   fi
-else
-  for dir in ${pkgdatadir} /boot/grub /usr/share/grub ; do
-for basename in unicode unifont ascii; do
- path=${dir}/${basename}.pf2
-  if is_path_readable_by_grub ${path}  /dev/null ; then
-   GRUB_FONT_PATH=${path}
- else
-   continue
- fi
- if [ ${basename} = ascii ] ; then
-   # make sure all our children behave in