Bug#506755: Patch fixing this bug

2008-11-25 Thread Jérémie Corbier
On Mon, Nov 24, 2008 at 06:04:53PM +0100, Daniel Baumann wrote:
 for the records: if you create a patch, pay attention to the details,
 e.g. it's a significant difference if you copy one file out of a
 directory and remove that directory with rm -rf, or if you move the file
 out and rmdir it later.

For the records, I did pay attention to the details and I know the difference
between a cp and a mv...  libtpm.so is a private module (or at least it should
be) and providing all the symlinks and the .la archive is utterly pointless.

-- 
Jérémie
 /* Steinbach's Guideline for Systems Programming:
``Never test for an error condition
  you don't know how to handle.''*/


pgpfOaSJAXgIK.pgp
Description: PGP signature


Bug#506755: Patch fixing this bug

2008-11-25 Thread Daniel Baumann
Jérémie Corbier wrote:
 For the records, I did pay attention to the details and I know the difference
 between a cp and a mv...  libtpm.so is a private module (or at least it should
 be) and providing all the symlinks and the .la archive is utterly pointless.

that is not the point of the bug report, nor mentioned in the changelog.

-- 
Address:Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:  [EMAIL PROTECTED]
Internet:   http://people.panthera-systems.net/~daniel-baumann/



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#506755: Patch fixing this bug

2008-11-24 Thread Jérémie Corbier
tags 506755 +patch
thanks

Please find attached a patch fixing this issue.

Cheers,

-- 
Jérémie Corbier
 /* Patient: Doctor, it hurts when I do this!
Doctor: Well, then don't do it. */
diff -u libengine-tpm-openssl-0.4.1+20071221/debian/rules libengine-tpm-openssl-0.4.1+20071221/debian/rules
--- libengine-tpm-openssl-0.4.1+20071221/debian/rules
+++ libengine-tpm-openssl-0.4.1+20071221/debian/rules
@@ -69,8 +69,9 @@
 
 	$(MAKE) DESTDIR=$(CURDIR)/debian/libengine-tpm-openssl install
 
-	mv debian/libengine-tpm-openssl/usr/lib/openssl/engines debian/libengine-tpm-openssl/usr/lib
-	rmdir debian/libengine-tpm-openssl/usr/lib/openssl
+	mkdir -p debian/libengine-tpm-openssl/usr/lib/ssl/engines
+	cp debian/libengine-tpm-openssl/usr/lib/openssl/engines/libtpm.so debian/libengine-tpm-openssl/usr/lib/ssl/engines
+	rm -rf debian/libengine-tpm-openssl/usr/lib/openssl
 
 	install -D -m 0644 openssl.cnf.sample debian/libengine-tpm-openssl/usr/share/doc/libengine-tpm-openssl/examples/openssl.cnf
 
diff -u libengine-tpm-openssl-0.4.1+20071221/debian/changelog libengine-tpm-openssl-0.4.1+20071221/debian/changelog
--- libengine-tpm-openssl-0.4.1+20071221/debian/changelog
+++ libengine-tpm-openssl-0.4.1+20071221/debian/changelog
@@ -1,3 +1,11 @@
+libengine-tpm-openssl (0.4.1+20071221-3.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Install libtpm.so into the correct directory /usr/lib/ssl/engines
+(Closes: #506755).
+
+ -- Jérémie Corbier [EMAIL PROTECTED]  Mon, 24 Nov 2008 15:34:14 +0100
+
 libengine-tpm-openssl (0.4.1+20071221-3) unstable; urgency=low
 
   * Reordering rules file.


pgpeNU6PUXVzz.pgp
Description: PGP signature


Bug#506755: Patch fixing this bug

2008-11-24 Thread Daniel Baumann
Jérémie Corbier wrote:
 Please find attached a patch fixing this issue.

for the records: if you create a patch, pay attention to the details,
e.g. it's a significant difference if you copy one file out of a
directory and remove that directory with rm -rf, or if you move the file
out and rmdir it later.

-- 
Address:Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:  [EMAIL PROTECTED]
Internet:   http://people.panthera-systems.net/~daniel-baumann/



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]