gark...@mailueberfall.de wrote
I understand that you don't agree with the bug being grave. The point is
that I use it mainly for watching TV.
This is practically not possible anymore now since the VDR playback
breaks on every channel switch due to xdg-screensaver hogging the audio
handle. For that usage it is definately a grave bug because it rendered
my main application useless.
I know this may not affect all users, but I also find it a bit harsh to
say a bug is clearly not grave just because one is mainly using a xine
plugin that has been effectively broken now.
I sympathise, but the definition is:
grave
makes the package in question unusable or mostly so, or causes
data loss, or introduces a security hole allowing access to the
accounts of users who use the package.
I think that this bug is:
important
a bug which has a major effect on the usability of a package,
without rendering it completely unusable to everyone.
but it's up to the maintainer to decide.
Just as a remark regarding your intended fix: I haven't yet seen the
place where xine does a wait() or waitpid() for those forked childs to
clean up the zombies. If there is a place, ok, I just havn't seen it
yet.
I added signal(SIGCHLD, SIG_IGN) which should make that unnecessary.
Also, the change I actually made to xine-ui *does* include a loop to
close fds 3-255 (sadly there is no easy way to find out what the last
open fd is). So unless xine is opening a *huge* number of files I can't
understand this bug.
Please could you run ls -l /proc/$pid/fd/ for the pid of the
xdg-screensaver process when this bug is triggered?
If I startup the XVDR plugin, I see three pid's of xdg-screensaver. Upon
each TV channel switch, there's one more. They also don't seem to
terminate, so the list is growing. Aren't they supposed to just signal a
suspend and then terminate themselves?
Which version of xdg-utils do you have installed? There was a bug in
that which could result in zombie processes, but I fixed that before
making this change.
Ben.
signature.asc
Description: This is a digitally signed message part
