Package: skyeye
Version: 1.2.5-1
Severity: serious
Tags: patch
Usertags: implicit-pointer-conversion

Our automated buildd log filter[1] detected a problem that is likely to
cause your package to segfault on architectures where the size of a
pointer is greater than the size of an integer, such as ia64 and amd64.

  Function `get_sym' implicitly converted to pointer at utils/main/skyeye.c:200

This is often due to a missing function prototype definition.
For more information, see [2].

Though it is guaranteed that this codepath will cause a segfault on certain
architectures, it is not guaranteed that this codepath would ever be executed
(e.g., if the returned pointer is never dereferenced). However, this bug
does prevent the ia64 buildd from successfully building this package, resulting
in a practical FTBFS issue and warranting the serious severity.

[1] http://people.debian.org/~dannf/check-implicit-pointer-functions
[2] http://wiki.debian.org/ImplicitPointerConversions

-- 
dann frazier

diff -urpN skyeye-1.2.5.orig/utils/profile/symbol.h skyeye-1.2.5/utils/profile/symbol.h
--- skyeye-1.2.5.orig/utils/profile/symbol.h	2008-05-15 08:40:58.000000000 -0600
+++ skyeye-1.2.5/utils/profile/symbol.h	2009-02-19 18:28:25.636833631 -0700
@@ -73,6 +73,7 @@ void ARMul_TaskSwitch(ARMul_State *state
 ARMword ARMul_TaskCreate(ARMul_State *state);
 void ARMul_ReportEnergy(ARMul_State *state, FILE* pf);
 void ARMul_Consolidate(ARMul_State *state);
+char *get_sym(ARMword address);
 
 #endif
 #endif
diff -urpN skyeye-1.2.5.orig/utils/main/skyeye.c skyeye-1.2.5/utils/main/skyeye.c
--- skyeye-1.2.5.orig/utils/main/skyeye.c	2008-05-02 10:07:09.000000000 -0600
+++ skyeye-1.2.5/utils/main/skyeye.c	2009-02-19 18:36:45.901755129 -0700
@@ -46,6 +46,7 @@ with this program; if not, write to the 
 
 #include <setjmp.h>
 #include "code_cov.h"
+#include "symbol.h"
 
 /**
  * A global variable , point to the current archtecture

Reply via email to