Bug#516285: [Adduser-devel] Bug#516285: Bug#516285: It seems to accept anything for 'yes'
tags #516285 help thanks On Sat, Sep 19, 2009 at 09:54:36PM +0200, Joerg Hoh wrote: > I tend to agree on the point made by Enrico. The change isn't invasive and > does not affect the translations. > But there are several situations that adduser goes into a kind of > interactive mode asking questions. > > We should handle all such situations consistently. I agree, but looking at the bug list, I think there are more important things to attend. I would, however, blindly apply a patch submitted by anybody. Greetings Marc -- - Marc Haber | "I don't trust Computers. They | Mailadresse im Header Mannheim, Germany | lose things."Winona Ryder | Fon: *49 621 31958061 Nordisch by Nature | How to make an American Quilt | Fax: *49 621 31958062 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#516285: [Adduser-devel] Bug#516285: Bug#516285: It seems to accept anything for 'yes'
Hi On Sat, Feb 21, 2009 at 12:12:11PM +, Stephen Gran wrote: > > > > My rationale was that if garbage is detected, then one cannot assume to > > be able to interpret the will of the user. In this case, it's quite > > easy to just ask again, instead of going on and creating an account with > > data that can potentially contain garbage. > > Yeah, I can see that point of view. I tend to think of adduser as a > program designed to be called from maintainer scripts, and it's > usefulnss to admins is kind of secondary (sort of like update-rc.d or > something). This has led to lots of places in the code making > assumptions that if you're not actively saying no, we should proceed. Surprisingly this questions only occurs when you add a "regular" user; in the codepath which creates system users there is no question like this. > > But ultimately, I'll accept any judgement on this: it isn't really a big > > deal. > > Fair enough - I'll think on it and see what Joerg has to say, and go > from there. I tend to agree on the point made by Enrico. The change isn't invasive and does not affect the translations. But there are several situations that adduser goes into a kind of interactive mode asking questions. We should handle all such situations consistently. Joerg -- What did you do to the cat? It looks half-dead. -Schroedinger's wife pgpbEB0gbxZo8.pgp Description: PGP signature
Bug#516285: [Adduser-devel] Bug#516285: It seems to accept anything for 'yes'
This one time, at band camp, Enrico Zini said: > On Fri, Feb 20, 2009 at 01:40:09PM +, Stephen Gran wrote: > > This one time, at band camp, Enrico Zini said: > > > Is the information correct? [Y/n] p > > > pico:/# adduser enrico > > > adduser: The user `enrico' already exists. > > > pico:/# > > > Apparently, it was happy to take 'p' for a yes. > > Since the default is 'yes', the code only looks to see if you've > > actively negated the action. I think, while perhaps slightly silly, > > this is ultimately correct. > > My rationale was that if garbage is detected, then one cannot assume to > be able to interpret the will of the user. In this case, it's quite > easy to just ask again, instead of going on and creating an account with > data that can potentially contain garbage. Yeah, I can see that point of view. I tend to think of adduser as a program designed to be called from maintainer scripts, and it's usefulnss to admins is kind of secondary (sort of like update-rc.d or something). This has led to lots of places in the code making assumptions that if you're not actively saying no, we should proceed. > But ultimately, I'll accept any judgement on this: it isn't really a big > deal. Fair enough - I'll think on it and see what Joerg has to say, and go from there. Cheers, -- - | ,''`.Stephen Gran | | : :' :sg...@debian.org | | `. `'Debian user, admin, and developer | |`- http://www.debian.org | - signature.asc Description: Digital signature
Bug#516285: [Adduser-devel] Bug#516285: It seems to accept anything for 'yes'
On Fri, Feb 20, 2009 at 01:40:09PM +, Stephen Gran wrote: > This one time, at band camp, Enrico Zini said: > > Is the information correct? [Y/n] p > > pico:/# adduser enrico > > adduser: The user `enrico' already exists. > > pico:/# > > Apparently, it was happy to take 'p' for a yes. > Since the default is 'yes', the code only looks to see if you've > actively negated the action. I think, while perhaps slightly silly, > this is ultimately correct. My rationale was that if garbage is detected, then one cannot assume to be able to interpret the will of the user. In this case, it's quite easy to just ask again, instead of going on and creating an account with data that can potentially contain garbage. But ultimately, I'll accept any judgement on this: it isn't really a big deal. Ciao, Enrico -- GPG key: 1024D/797EBFAB 2000-12-05 Enrico Zini signature.asc Description: Digital signature
Bug#516285: [Adduser-devel] Bug#516285: It seems to accept anything for 'yes'
This one time, at band camp, Enrico Zini said: > Is the information correct? [Y/n] p > pico:/# adduser enrico > adduser: The user `enrico' already exists. > pico:/# > > Apparently, it was happy to take 'p' for a yes. Since the default is 'yes', the code only looks to see if you've actively negated the action. I think, while perhaps slightly silly, this is ultimately correct. Cheers, -- - | ,''`.Stephen Gran | | : :' :sg...@debian.org | | `. `'Debian user, admin, and developer | |`- http://www.debian.org | - signature.asc Description: Digital signature
Bug#516285: It seems to accept anything for 'yes'
Package: adduser Version: 3.110 Severity: minor Hello, thanks for maintaining adduser. I was quite surprised when I was creating a test user and I got this: pico:/# adduser enrico Adding user `enrico' ... Adding new group `enrico' (1000) ... Adding new user `enrico' (1000) with group `enrico' ... The home directory `/home/enrico' already exists. Not copying from `/etc/skel'. adduser: Warning: The home directory `/home/enrico' does not belong to the user you are currently creating. Enter new UNIX password: Retype new UNIX password: passwd: password updated successfully Changing the user information for enrico Enter the new value, or press ENTER for the default Full Name []: p Room Number []: p Work Phone []: p Home Phone []: p Other []: p Is the information correct? [Y/n] p pico:/# adduser enrico adduser: The user `enrico' already exists. pico:/# Apparently, it was happy to take 'p' for a yes. Ciao, Enrico -- System Information: Debian Release: 5.0 APT prefers testing APT policy: (500, 'testing') Architecture: amd64 (x86_64) Kernel: Linux 2.6.26-1-amd64 (SMP w/2 CPU cores) Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages adduser depends on: ii debconf [debconf-2.0] 1.5.24 Debian configuration management sy ii passwd1:4.1.1-6 change and administer password and ii perl-base 5.10.0-19 minimal Perl system adduser recommends no packages. Versions of packages adduser suggests: ii liblocale-gettext-perl1.05-4 Using libc functions for internati ii perl-modules 5.10.0-19 Core Perl modules -- debconf information: adduser/homedir-permission: true -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
